[Dovecot] upgrade convert omissions

[Nick Edwards]

It did not convert over some things:

protocol imap {
       listen = *:143
       mail_plugins = quota imap_quota
       imap_client_workarounds = outlook-idle
       ssl_listen = *:993
}


protocol pop3 {
       pop3_uidl_format = %f
       mail_plugins = quota
       pop3_client_workarounds = outlook-no-nuls oe-ns-eoh
}


protocol lda {
       mail_plugins = quota cmusieve
       quota_full_tempfail = no
       log_path = /var/log/dovecot/deliver.log
       deliver_log_format = msgid=%m: from=%f: %$
       auth_socket_path = /var/run/dovecot/auth-master
}

I ended up with

service imap-login {
 inet_listener imap {
   address = *
   port = 143
 }
 inet_listener imaps {
   address = *
   port = 993
 }
 process_limit = 1024
 service_count = 1
}
service imap {
 process_limit = 1024
}
service pop3-login {
 process_limit = 1024
 service_count = 1
}
service pop3 {
 process_limit = 1024
}

It looks like service-foobar is replacing stuff inside protocol {} but
protocol still exists in examples, kind of confusing.

Oh what about service-pop3, different than examples and service-imap,
where's pop3s ? I guess I'll just copy the service pop3 section from
an example file.
Does all this mean the protocol section is not needed? or everything
inside of them I had is no longer valid? No LDA specific logging
converted, it did not include the quota stuff in where it is needed
(mail_plugins went MIA), but did inside converted plugin
section.

I did note the conversion warned that workarounds = outlook-idle is no
longer needed, but nothing about the other stuff.

Just concerns me if it ignored some needed stuff, what else did it ignore.

Nik (who is rather reluctant to use series 2 and break everything and
stay with 1.2)

Below is the  new conf file:
auth_cache_negative_ttl = 0
auth_cache_ttl = 5 mins
auth_mechanisms = plain login
auth_verbose = yes
disable_plaintext_auth = no
first_valid_uid = 95
last_valid_uid = 95
listen = *,::
log_path = /var/log/dovecot/pop3.log
login_log_format_elements = user=<%u> method=%m rip=%r %c
mail_location = maildir:/vmail/%d/%n/Maildir
mail_nfs_index = yes
mail_nfs_storage = yes
maildir_very_dirty_syncs = yes
mmap_disable = yes
passdb {
 args = /etc/dovecot-sql.conf
 driver = sql
}
plugin {
 quota = maildir
 quota_rule = *:storage=1000M
 quota_rule2 = Trash:storage=100M
 quota_rule3 = Junk:ignore
 quota_rule4 = Spam:ignore
 quota_warning = storage=90%% /usr/local/bin/quotawarn-90.sh
 quota_warning2 = storage=75%% /usr/local/bin/quotawarn-75.sh
}
pop3_lock_session = yes
protocols = imap pop3
service auth {
 unix_listener /var/spool/postfix/private/auth {
   group = postfix
   mode = 0660
   user = postfix
 }
 unix_listener auth-master {
   mode = 0600
   user = vmail
 }
 user = vmail
}
service imap-login {
 inet_listener imap {
   address = *
   port = 143
 }
 inet_listener imaps {
   address = *
   port = 993
 }
 process_limit = 1024
 service_count = 1
}
service imap {
 process_limit = 1024
}
service pop3-login {
 process_limit = 1024
 service_count = 1
}
service pop3 {
 process_limit = 1024
}
shutdown_clients = no
ssl_cert = </etc/ssl/certs/mail.crt
ssl_key = </etc/ssl/certs/mail.key
userdb {
 args = /etc/dovecot-sql.conf
 driver = sql
}