[dovecot/core] 06cb4a: imap: Fix command ambiguity checking with special ...

GitHub noreply at github.com
Tue Nov 13 14:00:13 EET 2018


  Branch: refs/heads/master-2.3
  Home:   https://github.com/dovecot/core
  Commit: 06cb4a068b1a6732a3bd21cdfd335fb7433c6ddc
      https://github.com/dovecot/core/commit/06cb4a068b1a6732a3bd21cdfd335fb7433c6ddc
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-11-13 (Tue, 13 Nov 2018)

  Changed paths:
    M src/imap/imap-client.c

  Log Message:
  -----------
  imap: Fix command ambiguity checking with special plugins

If the tagged line is already sent, that command can't result in ambiguity
anymore.

A cleaner fix would be to add a new _WAIT_SYNC_OUTPUT state, but that
requires all the existing code to understand that new state correctly, so it
has a higher chance of breaking something. So at least for now don't add it.


  Commit: a7276f21ce4049517f4d489c8e8469d5ce6e9248
      https://github.com/dovecot/core/commit/a7276f21ce4049517f4d489c8e8469d5ce6e9248
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-11-13 (Tue, 13 Nov 2018)

  Changed paths:
    M src/login-common/login-proxy.c

  Log Message:
  -----------
  login-proxy: Fix logging reason when kicking non-logged in connections

Use the same reason as for logged in connections.


  Commit: 385745317804a71bc76a3cec33d804330a13f037
      https://github.com/dovecot/core/commit/385745317804a71bc76a3cec33d804330a13f037
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-11-13 (Tue, 13 Nov 2018)

  Changed paths:
    M src/lib-dict/dict-client.c

  Log Message:
  -----------
  dict-client: Avoid excessive CPU usage while waiting commands to finish

client_dict_add_timeout() adds the timeout thinking that the dict no longer
has any work to do, so it can be freed soon. However, if other work is
added before that, the timeout just keeps getting called over and over
again. This is especially bad with the default idle timeout of 0.


Compare: https://github.com/dovecot/core/compare/7fe29d2d8f60...385745317804
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the dovecot-cvs mailing list