[dovecot/core] 97e308: pop3: Do not expunge \Deleted mails without QUIT

[GitHub]

  Branch: refs/heads/master-2.3
  Home:   https://github.com/dovecot/core
  Commit: 97e3086eec24bfb849a0d8422992b822e0733601
      https://github.com/dovecot/core/commit/97e3086eec24bfb849a0d8422992b822e0733601
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-13 (Tue, 13 Nov 2018)

  Changed paths:
    M src/pop3/pop3-client.h
    M src/pop3/pop3-commands.c

  Log Message:
  -----------
  pop3: Do not expunge \Deleted mails without QUIT

Prevents loss of email if connection
is unexpectedly terminated.


  Commit: eaafe510f8b1b330ecfd1f2b0665aabd6ee74393
      https://github.com/dovecot/core/commit/eaafe510f8b1b330ecfd1f2b0665aabd6ee74393
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-11-13 (Tue, 13 Nov 2018)

  Changed paths:
    M src/lib-master/ipc-client.c

  Log Message:
  -----------
  lib-master: ipc-client: Don't call callback twice if IPC proxy sends invalid input

ipc_client_disconnect() called it once, and the second time was done with
the cmds[0] that was already removed from the array.


  Commit: d4ded251e6ae17ce547de9bb8fb4bdfcedcfcbbe
      https://github.com/dovecot/core/commit/d4ded251e6ae17ce547de9bb8fb4bdfcedcfcbbe
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-11-13 (Tue, 13 Nov 2018)

  Changed paths:
    M src/lib-master/ipc-client.c

  Log Message:
  -----------
  lib-master: ipc-client: Use linked list of commads instead of array

Needed for the following commit that returns the command pointer.


  Commit: 9a7449a3793f7f7ad4deac196d63ceaa26a3752c
      https://github.com/dovecot/core/commit/9a7449a3793f7f7ad4deac196d63ceaa26a3752c
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-11-13 (Tue, 13 Nov 2018)

  Changed paths:
    M src/lib-master/ipc-client.c

  Log Message:
  -----------
  lib-master: ipc-client: Split code to ipc_client_abort_commands()


  Commit: eaa02f0dfd616b0d3d02306aba46c86c9a22366c
      https://github.com/dovecot/core/commit/eaa02f0dfd616b0d3d02306aba46c86c9a22366c
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-11-13 (Tue, 13 Nov 2018)

  Changed paths:
    M src/lib-master/ipc-client.c

  Log Message:
  -----------
  lib-master: ipc-client: Never call callback directly from ipc_client_cmd()

This may simplify the calling code, especially after the following commit
that returns the command pointer.


  Commit: f5222c92b62aa4832478344fc0521d08156a5729
      https://github.com/dovecot/core/commit/f5222c92b62aa4832478344fc0521d08156a5729
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-11-13 (Tue, 13 Nov 2018)

  Changed paths:
    M src/lib-master/ipc-client.c

  Log Message:
  -----------
  lib-master: ipc-client: Cleanup - avoid extra return in the function

Simplifies the following commit.


  Commit: 2c37ca27451b3145ee91462c149015693fecbdad
      https://github.com/dovecot/core/commit/2c37ca27451b3145ee91462c149015693fecbdad
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-11-13 (Tue, 13 Nov 2018)

  Changed paths:
    M src/lib-master/ipc-client.c
    M src/lib-master/ipc-client.h

  Log Message:
  -----------
  lib-master: ipc-client: Support aborting commands


  Commit: 96efffe56468f4a3944a1fc2a783c50a00b9cf8f
      https://github.com/dovecot/core/commit/96efffe56468f4a3944a1fc2a783c50a00b9cf8f
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-11-13 (Tue, 13 Nov 2018)

  Changed paths:
    M src/director/director.c
    M src/director/director.h

  Log Message:
  -----------
  director: Fix crash when user kill times out before IPC finishes

Abort the IPC kick command when freeing kill context so the IPC callback
won't be called.


  Commit: f427f061cdc2691bd0221a00c0d879d09f0be9e3
      https://github.com/dovecot/core/commit/f427f061cdc2691bd0221a00c0d879d09f0be9e3
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-11-13 (Tue, 13 Nov 2018)

  Changed paths:
    M src/director/director.c

  Log Message:
  -----------
  director: Allow fully freeing user while waiting for IPC kick to finish

director_user_move_free() will now just free the IPC command, so this isn't
a problem anymore.


  Commit: c860364a2cb88b0cd93a117fe0b730b51609f29b
      https://github.com/dovecot/core/commit/c860364a2cb88b0cd93a117fe0b730b51609f29b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-11-13 (Tue, 13 Nov 2018)

  Changed paths:
    M src/lib-master/ipc-client.c

  Log Message:
  -----------
  lib-master: ipc-client: Don't free command too early

When multiple replies were received by IPC only the final reply should free
the command. This may have caused e.g. "doveadm proxy list" to crash.
Broken by 435f0545b200767c25a5daee17cd6b4998d03710


  Commit: cdd0fd7298f414270c570f93353c8144967fd971
      https://github.com/dovecot/core/commit/cdd0fd7298f414270c570f93353c8144967fd971
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-13 (Tue, 13 Nov 2018)

  Changed paths:
    M configure.ac
    M src/auth/mycrypt.c

  Log Message:
  -----------
  auth: mycrypt - include crypt.h

Fixes crypt usage on glibc-2.28

Reported by Reuben Farrelly
Patch provided by Thore Bödecker


  Commit: 2c48951011d6fff7a108dfe8a6aefa6347d887a2
      https://github.com/dovecot/core/commit/2c48951011d6fff7a108dfe8a6aefa6347d887a2
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-11-13 (Tue, 13 Nov 2018)

  Changed paths:
    M src/lib-http/test-http-client-errors.c

  Log Message:
  -----------
  lib-http: test-http-client-errors: Make "peer reuse failure" test reliable.

It was highly timing-sensitive, since it required a particular error status to
be returned. Sometimes, it would yield a different error based on a
slightly different order of events, making the test fail. Such failures aren't
relevant though, since this regression test is about triggering a segfault that
used to occur.


  Commit: 5671fef864a20bac7a3bc0ee56b7a11a81ab084d
      https://github.com/dovecot/core/commit/5671fef864a20bac7a3bc0ee56b7a11a81ab084d
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-11-13 (Tue, 13 Nov 2018)

  Changed paths:
    M src/lib-http/http-response.h

  Log Message:
  -----------
  lib-http: response: Add convenience functions for status evaluation.


  Commit: 7fe29d2d8f603a5ce45989274650a91b217eec05
      https://github.com/dovecot/core/commit/7fe29d2d8f603a5ce45989274650a91b217eec05
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-11-13 (Tue, 13 Nov 2018)

  Changed paths:
    M src/lib-http/test-http-client-errors.c

  Log Message:
  -----------
  lib-http: test-http-client-errors: Address another reliability issue in "peer reuse failure" test.


Compare: https://github.com/dovecot/core/compare/e151b99c1b55...7fe29d2d8f60
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.