[dovecot/core] 902155: lib-master: Add how long request took for "Interna...

[GitHub]

  Branch: refs/heads/master-2.2
  Home:   https://github.com/dovecot/core
  Commit: 9021554df687cc888b8ca1b5966358b126d4e464
      https://github.com/dovecot/core/commit/9021554df687cc888b8ca1b5966358b126d4e464
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/lib-master/master-login-auth.c

  Log Message:
  -----------
  lib-master: Add how long request took for "Internal auth failure" errors


  Commit: 81335c1f0c2827de225ee5e9833a33c52ac3b21f
      https://github.com/dovecot/core/commit/81335c1f0c2827de225ee5e9833a33c52ac3b21f
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/lib-master/master-auth.c

  Log Message:
  -----------
  lib-master: If connect() to backend UNIX socket is retried, log a warning

For example if imap-login process needs to retry before it successfully
connects to imap process's socket, a warning is logged. This warning is
important because it means that the imap-login process may have been
sleeping up to 0.5 seconds and causing all the other connections to hang
during it.

It would be better to make this retrying asynchronous, but before spending
time on doing that, lets see if this warning is ever even being logged.


  Commit: bb4eac0a8c481a93a99b92b93e32fb8ae472fcdb
      https://github.com/dovecot/core/commit/bb4eac0a8c481a93a99b92b93e32fb8ae472fcdb
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/lib-master/master-login.c
    M src/lib-master/master-login.h

  Log Message:
  -----------
  lib-master: Keep linked list of master_login_clients per connection

This allows improving logging on connection errors.


  Commit: 5746b2d515c0af60e95e70e5caefe22a030c3b4f
      https://github.com/dovecot/core/commit/5746b2d515c0af60e95e70e5caefe22a030c3b4f
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/lib-master/master-login.c
    M src/lib-master/master-login.h

  Log Message:
  -----------
  lib-master: Improve error logging when master_login_connection gets disconnected


  Commit: 2fda47e8f329deb75b906cf31b1341412e8e14cb
      https://github.com/dovecot/core/commit/2fda47e8f329deb75b906cf31b1341412e8e14cb
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/lib-master/master-login.c
    M src/lib-master/master-login.h

  Log Message:
  -----------
  lib-master: Improve error logging for post-login script failures


  Commit: 389a0ba2713f20195d1793ce4e48cb212577354d
      https://github.com/dovecot/core/commit/389a0ba2713f20195d1793ce4e48cb212577354d
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/lib-master/master-auth.c

  Log Message:
  -----------
  lib-master: Improve error logging for master_auth_connection failures


  Commit: 85ea0d30fe8ceafb8b6b0a531bbf3b1df94568e5
      https://github.com/dovecot/core/commit/85ea0d30fe8ceafb8b6b0a531bbf3b1df94568e5
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/lib-master/master-login-auth.c

  Log Message:
  -----------
  lib-master: Use more exact timestamp in master_login_auth_request failures


  Commit: 4999c15d5c8f9804c89a6c25a0323f5c0cb73322
      https://github.com/dovecot/core/commit/4999c15d5c8f9804c89a6c25a0323f5c0cb73322
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/lib-master/master-login-auth.c

  Log Message:
  -----------
  lib-master: Add request time also for internal failure error messages


  Commit: 062ad3c8d8adeaf35750cf82aca56e8fcef8a1d2
      https://github.com/dovecot/core/commit/062ad3c8d8adeaf35750cf82aca56e8fcef8a1d2
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/lib-master/master-login-auth.c

  Log Message:
  -----------
  lib-master: Add auth connect & handshake times to master_login_auth_request errors


  Commit: 7140204b12306cbee98a342aac7be90948d018a5
      https://github.com/dovecot/core/commit/7140204b12306cbee98a342aac7be90948d018a5
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/auth/auth-master-connection.c
    M src/auth/auth-master-connection.h
    M src/auth/auth-request-handler.c

  Log Message:
  -----------
  auth: Improve auth-master connections' error logging

Include connect and handshake times in the error message.


  Commit: c0b5d6e1bbdd239bef62d03d8e367e22aad88a53
      https://github.com/dovecot/core/commit/c0b5d6e1bbdd239bef62d03d8e367e22aad88a53
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/lib-master/master-login.c

  Log Message:
  -----------
  lib-master: postlogin: Don't unreference already closed login-connection

If the login-connection was already closed, this caused too many
unreferences.

Fixes:
Panic: file master-login.c: line 544 (master_login_conn_unref): assertion failed: (conn->clients == NULL)


Compare: https://github.com/dovecot/core/compare/a0d8fdc94710...c0b5d6e1bbdd
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.