[dovecot/core] ede3c3: lib-smtp: client: Fix assertion panic occurring wh...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: ede3c3be7fc01e51c62f67071b0c73bf0087b7ad
      https://github.com/dovecot/core/commit/ede3c3be7fc01e51c62f67071b0c73bf0087b7ad
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/lib-smtp/smtp-client-command.c
    M src/lib-smtp/smtp-client-private.h

  Log Message:
  -----------
  lib-smtp: client: Fix assertion panic occurring when DATA dot stream cannot be finished immediately.

If o_stream_finish() returns 0, o_stream_send_istream() would be called again
later which causes the panic. Instead, it should only call o_stream_finish() or
o_stream_flush() again to finish the last bit of the output.

Panic was:

Panic: file ostream.c: line 394 (o_stream_send_istream): assertion failed: (!_outstream->finished)



      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.