[dovecot/pigeonhole] 7aabfa: sieve-tools: Terminate with a fatal error when scr...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/pigeonhole
  Commit: 7aabfac436fc8bf87b7424a62bd5bb13593c4c77
      https://github.com/dovecot/pigeonhole/commit/7aabfac436fc8bf87b7424a62bd5bb13593c4c77
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-07-08 (Sat, 08 Jul 2017)

  Changed paths:
    M src/lib-sieve-tool/sieve-tool.c

  Log Message:
  -----------
  sieve-tools: Terminate with a fatal error when script cannot be compiled/opened.

Rather than continuing with binary == NULL, causing a segfault.


  Commit: d188419fefb0bff9a5edf9d94231098cf2ef0938
      https://github.com/dovecot/pigeonhole/commit/d188419fefb0bff9a5edf9d94231098cf2ef0938
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-07-08 (Sat, 08 Jul 2017)

  Changed paths:
    M src/sieve-tools/sieve-filter.c

  Log Message:
  -----------
  sieve-tools: sieve-filter: Forgot to clean up script binary at end of execution.

Normally, this would merely be an inconsequential memory leak.
However, when the script comes from an LDAP storage, the storage is not closed before master_service_deinit() -> io_loop_destroy().
The LDAP connection's stale io can cause problems while closing the main ioloop.


Compare: https://github.com/dovecot/pigeonhole/compare/c80aa7c25b0b...d188419fefb0