[dovecot/pigeonhole] 159ab3: managesieve-login: authenticate command: Make sure...

[GitHub]

  Branch: refs/heads/master-0.4
  Home:   https://github.com/dovecot/pigeonhole
  Commit: 159ab369d5c28b8d5c68a3178338b81d3aa6ec23
      https://github.com/dovecot/pigeonhole/commit/159ab369d5c28b8d5c68a3178338b81d3aa6ec23
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-07-10 (Mon, 10 Jul 2017)

  Changed paths:
    M src/managesieve-login/client-authenticate.c

  Log Message:
  -----------
  managesieve-login: authenticate command: Make sure client->auth_mech_name_parsed is reset properly upon command error.

This could cause problems for any subsequent AUTHENTICATE commmend.


  Commit: d6598cc62e6407eabef611f4a3f8e2028b7e8dd5
      https://github.com/dovecot/pigeonhole/commit/d6598cc62e6407eabef611f4a3f8e2028b7e8dd5
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-07-10 (Mon, 10 Jul 2017)

  Changed paths:
    M src/managesieve-login/client.c

  Log Message:
  -----------
  managesieve-login: managesieve_client_input_next_cmd(): Fix handling of command continuation.

Commands that continued after waiting for more input always failed.
This mainly applies to the AUTHENTICATE command, which mostly handles its own arguments.
This caused problems when a string literal was used as the initial response for the AUTHENTICATE command.

Caused by recent change:

Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date:   Wed Jun 14 12:39:02 2017 +0300

managesieve-login: managesieve_client_input_next_cmd() - minor code cleanup


  Commit: a7b315c72075c5bfded1f2db19cf6b528910a982
      https://github.com/dovecot/pigeonhole/commit/a7b315c72075c5bfded1f2db19cf6b528910a982
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-07-10 (Mon, 10 Jul 2017)

  Changed paths:
    M src/lib-sieve-tool/sieve-tool.c

  Log Message:
  -----------
  sieve-tools: Terminate with a fatal error when script cannot be compiled/opened.

Rather than continuing with binary == NULL, causing a segfault.


  Commit: 1a93191c87960a63891232eb75d4f9838c8adfb2
      https://github.com/dovecot/pigeonhole/commit/1a93191c87960a63891232eb75d4f9838c8adfb2
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-07-10 (Mon, 10 Jul 2017)

  Changed paths:
    M src/sieve-tools/sieve-filter.c

  Log Message:
  -----------
  sieve-tools: sieve-filter: Forgot to clean up script binary at end of execution.

Normally, this would merely be an inconsequential memory leak.
However, when the script comes from an LDAP storage, the storage is not closed before master_service_deinit() -> io_loop_destroy().
The LDAP connection's stale io can cause problems while closing the main ioloop.


Compare: https://github.com/dovecot/pigeonhole/compare/af36600d6b75...1a93191c8796