[dovecot/core] aca5aa: lib-imap-client: Use struct timeval for tracking l...

[GitHub]

  Branch: refs/heads/master-2.2
  Home:   https://github.com/dovecot/core
  Commit: aca5aa7845a5653f2294b6e770a09dccc2cf955b
      https://github.com/dovecot/core/commit/aca5aa7845a5653f2294b6e770a09dccc2cf955b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-10 (Mon, 10 Apr 2017)

  Changed paths:
    M src/lib-imap-client/imapc-connection.c

  Log Message:
  -----------
  lib-imap-client: Use struct timeval for tracking last_connect time.

This provides better accuracy when calculating how much time there's left
until reconnection.


  Commit: 0fa6c726a9acd0fe42a4d7f0c8f6ca3729d3982e
      https://github.com/dovecot/core/commit/0fa6c726a9acd0fe42a4d7f0c8f6ca3729d3982e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-10 (Mon, 10 Apr 2017)

  Changed paths:
    M src/lib-imap-client/imapc-client.c
    M src/lib-imap-client/imapc-client.h
    M src/lib-imap-client/imapc-connection.c
    M src/lib-storage/index/imapc/imapc-storage.c

  Log Message:
  -----------
  lib-imap-client: Change connect_retry_interval_secs to _msecs

This allows caller to provide better precision.


  Commit: 19554223c5f4b8c57a2f5069a93050878a2ee330
      https://github.com/dovecot/core/commit/19554223c5f4b8c57a2f5069a93050878a2ee330
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-10 (Mon, 10 Apr 2017)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-settings.c

  Log Message:
  -----------
  imapc: Change imapc_connection_retry_interval default to be 1 second.

10 secs at least is too high. Usually the connection problem is very
intermittent and even an immediate reconnection would succeed.


  Commit: 19762b4283fecc37eeea3577af80c5760b54e392
      https://github.com/dovecot/core/commit/19762b4283fecc37eeea3577af80c5760b54e392
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-10 (Mon, 10 Apr 2017)

  Changed paths:
    M src/lib-imap-client/imapc-client.c

  Log Message:
  -----------
  lib-imap-client: imapc_client_deinit() didn't set client=NULL


  Commit: b522906dc1071a5008c87bb702aa2d6d4ac6451a
      https://github.com/dovecot/core/commit/b522906dc1071a5008c87bb702aa2d6d4ac6451a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-10 (Mon, 10 Apr 2017)

  Changed paths:
    M src/lib-imap-client/imapc-client-private.h
    M src/lib-imap-client/imapc-client.c
    M src/lib-imap-client/imapc-client.h
    M src/lib-imap-client/imapc-connection.c
    M src/lib-imap-client/imapc-connection.h

  Log Message:
  -----------
  lib-imap-client: Call the public login callback exactly once.

Previously it was also called only once, as long as there were only a single
imap connection. (The current imapc code wouldn't create more than one
connection.) It was a bit confusing what the expectation was, so now the
callback is never called more than once.


  Commit: 59a0265df411ce1c27fc677b372b9ab9779b95da
      https://github.com/dovecot/core/commit/59a0265df411ce1c27fc677b372b9ab9779b95da
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-10 (Mon, 10 Apr 2017)

  Changed paths:
    M src/lib-imap-client/imapc-client-private.h
    M src/lib-imap-client/imapc-client.c
    M src/lib-imap-client/imapc-connection.c

  Log Message:
  -----------
  lib-imap-client: Make command tag counter externally accessible

This allows unit tests to reset it.


  Commit: 4b32dbb65fbe3d862963b23a18fbe32c69a657a5
      https://github.com/dovecot/core/commit/4b32dbb65fbe3d862963b23a18fbe32c69a657a5
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-10 (Mon, 10 Apr 2017)

  Changed paths:
    M src/lib-imap-client/imapc-client.h
    M src/lib-imap-client/imapc-connection.c

  Log Message:
  -----------
  lib-imap-client: Disconnection during LOGIN should still have state=disconnected

It's not an authentication failure, which would imply that the user or
password was wrong.


  Commit: ed10bddd8796eb0c49ca414d679188e58e52ec9f
      https://github.com/dovecot/core/commit/ed10bddd8796eb0c49ca414d679188e58e52ec9f
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-10 (Mon, 10 Apr 2017)

  Changed paths:
    M src/lib-imap-client/imapc-connection.c
    M src/lib-imap-client/imapc-connection.h

  Log Message:
  -----------
  lib-imap-client: Remove hardcoded IMAPC_CONNECT_RETRY_WAIT_MSECS

We have a setting for it now.


  Commit: dcd135e54a48b1466aba4f7546d0815e7f45c50c
      https://github.com/dovecot/core/commit/dcd135e54a48b1466aba4f7546d0815e7f45c50c
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-10 (Mon, 10 Apr 2017)

  Changed paths:
    M src/lib-imap-client/imapc-connection.c

  Log Message:
  -----------
  lib-imap-client: Include "ms" in reconnect warning message


  Commit: c47cdae23479531c4a89e798f60195984bfcc2eb
      https://github.com/dovecot/core/commit/c47cdae23479531c4a89e798f60195984bfcc2eb
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-10 (Mon, 10 Apr 2017)

  Changed paths:
    M src/lib-imap-client/Makefile.am
    M src/lib-imap-client/imapc-client.c
    M src/lib-imap-client/imapc-client.h
    A src/lib-imap-client/test-imapc-client.c

  Log Message:
  -----------
  lib-imap-client: Add unit test

Initially this tests some connection and reconnection problems.


Compare: https://github.com/dovecot/core/compare/d4fed32b5847...c47cdae23479