[dovecot/core] 8f47ed: lib-imap-client: Use struct timeval for tracking l...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 8f47ed142e1572151e38e70c3cb6b2fffc5ce6d0
      https://github.com/dovecot/core/commit/8f47ed142e1572151e38e70c3cb6b2fffc5ce6d0
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-10 (Mon, 10 Apr 2017)

  Changed paths:
    M src/lib-imap-client/imapc-connection.c

  Log Message:
  -----------
  lib-imap-client: Use struct timeval for tracking last_connect time.

This provides better accuracy when calculating how much time there's left
until reconnection.


  Commit: 4727aef38f51e62e27b4f2c1b77fb5438ad5e733
      https://github.com/dovecot/core/commit/4727aef38f51e62e27b4f2c1b77fb5438ad5e733
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-10 (Mon, 10 Apr 2017)

  Changed paths:
    M src/lib-imap-client/imapc-client.c
    M src/lib-imap-client/imapc-client.h
    M src/lib-imap-client/imapc-connection.c
    M src/lib-storage/index/imapc/imapc-storage.c

  Log Message:
  -----------
  lib-imap-client: Change connect_retry_interval_secs to _msecs

This allows caller to provide better precision.


  Commit: 063597b19ecca3a333f4abc17a704e15d5a6a832
      https://github.com/dovecot/core/commit/063597b19ecca3a333f4abc17a704e15d5a6a832
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-10 (Mon, 10 Apr 2017)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-settings.c

  Log Message:
  -----------
  imapc: Change imapc_connection_retry_interval default to be 1 second.

10 secs at least is too high. Usually the connection problem is very
intermittent and even an immediate reconnection would succeed.


  Commit: efd4de737ee4febffced006511f357959234a6ca
      https://github.com/dovecot/core/commit/efd4de737ee4febffced006511f357959234a6ca
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-10 (Mon, 10 Apr 2017)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-settings.c
    M src/lib-storage/index/imapc/imapc-storage.c

  Log Message:
  -----------
  imapc: Change imapc_connection_retry_interval setting to be in milliseconds.


  Commit: 7b29303efbb43e4e85715a228eb41c2a14300902
      https://github.com/dovecot/core/commit/7b29303efbb43e4e85715a228eb41c2a14300902
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-10 (Mon, 10 Apr 2017)

  Changed paths:
    M src/lib-imap-client/imapc-client.c

  Log Message:
  -----------
  lib-imap-client: imapc_client_deinit() didn't set client=NULL


  Commit: f3e5f802fac1c2047e46b44b856116cca1cbf5df
      https://github.com/dovecot/core/commit/f3e5f802fac1c2047e46b44b856116cca1cbf5df
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-10 (Mon, 10 Apr 2017)

  Changed paths:
    M src/lib-imap-client/imapc-client-private.h
    M src/lib-imap-client/imapc-client.c
    M src/lib-imap-client/imapc-client.h
    M src/lib-imap-client/imapc-connection.c
    M src/lib-imap-client/imapc-connection.h

  Log Message:
  -----------
  lib-imap-client: Call the public login callback exactly once.

Previously it was also called only once, as long as there were only a single
imap connection. (The current imapc code wouldn't create more than one
connection.) It was a bit confusing what the expectation was, so now the
callback is never called more than once.


  Commit: cda5d635049991ef56b5096e29c4da8dc3c51c96
      https://github.com/dovecot/core/commit/cda5d635049991ef56b5096e29c4da8dc3c51c96
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-10 (Mon, 10 Apr 2017)

  Changed paths:
    M src/lib-imap-client/imapc-client-private.h
    M src/lib-imap-client/imapc-client.c
    M src/lib-imap-client/imapc-connection.c

  Log Message:
  -----------
  lib-imap-client: Make command tag counter externally accessible

This allows unit tests to reset it.


  Commit: 09c2c5ad607de38a96c33c9064e635c4a26292ab
      https://github.com/dovecot/core/commit/09c2c5ad607de38a96c33c9064e635c4a26292ab
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-10 (Mon, 10 Apr 2017)

  Changed paths:
    M src/lib-imap-client/imapc-client.h
    M src/lib-imap-client/imapc-connection.c

  Log Message:
  -----------
  lib-imap-client: Disconnection during LOGIN should still have state=disconnected

It's not an authentication failure, which would imply that the user or
password was wrong.


  Commit: b884dafdd32a43c3c62bf9dbcc7a1a5df1409b0f
      https://github.com/dovecot/core/commit/b884dafdd32a43c3c62bf9dbcc7a1a5df1409b0f
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-10 (Mon, 10 Apr 2017)

  Changed paths:
    M src/lib-imap-client/imapc-connection.c
    M src/lib-imap-client/imapc-connection.h

  Log Message:
  -----------
  lib-imap-client: Remove hardcoded IMAPC_CONNECT_RETRY_WAIT_MSECS

We have a setting for it now.


  Commit: 23b8146dd6e07b7e34be0840e4ab76d0f0dd7018
      https://github.com/dovecot/core/commit/23b8146dd6e07b7e34be0840e4ab76d0f0dd7018
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-10 (Mon, 10 Apr 2017)

  Changed paths:
    M src/lib-imap-client/imapc-connection.c

  Log Message:
  -----------
  lib-imap-client: Fix reconnection

There was already code for reconnection. We just shouldn't have gone very
far in imapc_connection_connect() if we were still waiting for reconnection
delay to pass.


  Commit: 40b989ef6d7a399136ccf636c7be37843a5e35dc
      https://github.com/dovecot/core/commit/40b989ef6d7a399136ccf636c7be37843a5e35dc
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-10 (Mon, 10 Apr 2017)

  Changed paths:
    M src/lib-imap-client/imapc-connection.c

  Log Message:
  -----------
  lib-imap-client: Include "ms" in reconnect warning message


  Commit: bac4b1dc3aa56cda1c9d4fdd7e673b94e5c559a9
      https://github.com/dovecot/core/commit/bac4b1dc3aa56cda1c9d4fdd7e673b94e5c559a9
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-04-10 (Mon, 10 Apr 2017)

  Changed paths:
    M src/lib-imap-client/Makefile.am
    M src/lib-imap-client/imapc-client.c
    M src/lib-imap-client/imapc-client.h
    A src/lib-imap-client/test-imapc-client.c

  Log Message:
  -----------
  lib-imap-client: Add unit test

Initially this tests some connection and reconnection problems.


Compare: https://github.com/dovecot/core/compare/f27497406f88...bac4b1dc3aa5