[Dovecot] [PATCH, RFC] add APOP authentication mechanism

Timo Sirainen tss at iki.fi
Thu Jul 1 16:00:13 EEST 2004


On Thu, 2004-07-01 at 13:30, Andrey Panin wrote:
> this patch add APOP authentication mechanism to dovecot 1.0-test23.
> Please take a look.

Thanks, looks pretty good to me. I'll just change a few coding style
issues. Also:

+       if (strcmp(auth_request->protocol, "POP3")) {
+               if (verbose)
+                       i_info("apop(%s): wrong protocol %s", get_log_prefix(auth_request),
+                               auth_request->protocol);
+               mech_auth_finish(auth_request, NULL, 0, FALSE);
+               return TRUE;
+       }

I don't think there's really any point in checking this? Maybe someone
really wants to use APOP with another protocol :)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://dovecot.org/pipermail/dovecot/attachments/20040701/815db02a/attachment.pgp


More information about the dovecot mailing list