[Dovecot] Vpopmail support broken

Matt Brookings

22 Sep 2010 22 Sep '10

6:41 p.m.

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

My apologies if I'm posting for information which has already been supplied to the list. I searched and all I found was people talking about the change in 2.0.3, but no details on the commit other than "I was tired of people telling me it crashes".

We have not received any reports for the 5.4 or 5.5 branch of vpopmail causing crashes in Dovecot. That being said, if there is a problem, we would like to provide a fix.

Again, if details on the specifics of the problem have been supplied, I apologize. Can anyone please provide me some reproduction details for Dovecot 2.0.3's vpopmail plugin compiled against vpopmail 5.4.30+ or 5.5.0?

Removing the "vpopmail support broken" line from the configure script, compiling and running seemed to work short-term. I was able to authenticate against the vpopmail plugin. I tested with vpopmail 5.4.32 and 5.5.0 using the cdb authentication module.

Thanks!

/* Matt Brookings <matt@inter7.com> GnuPG Key FAE0672C Software developer Systems technician Inter7 Internet Technologies, Inc. (815)776-9465 */ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkyaI6MACgkQIwet2/rgZyz8ugCeOnyz5DfV9FwrHfEmIroeznPv kZYAn0TnbEULiuZqJANoZsfhOahhsA0H =LHP4 -----END PGP SIGNATURE-----

Show replies by date

Timo Sirainen

22 Sep 22 Sep

7:21 p.m.

On Wed, 2010-09-22 at 10:41 -0500, Matt Brookings wrote:

...

I guess the problem started when people started trying vpopmail 5.5:

http://markmail.org/message/ylt62t2yyqqfc7dg http://markmail.org/message/ykb7qujikzlsvvbe http://markmail.org/message/3cjscs7wgvbj65dw

I tried to fix 5.5 with this change:

http://hg.dovecot.org/dovecot-1.2/rev/597e18c0bc7e

But I heard that it's now crashing when doing that call. (I'm not sure which ones of those above problems are with this change and which ones aren't.) And apparently that also completely broke 5.4.

I'm not entirely sure about 5.4 problems. I think I remember someone saying that even when reverting the above change it didn't work.

...

I guess the problem is with MySQL.

aledr

7:31 p.m.

I'm compiling vpopmail for openSUSE with this1 patch for MySQL support on 5.5.0.

On Wed, Sep 22, 2010 at 1:21 PM, Timo Sirainen <tss@iki.fi> wrote:

...

-- [ ]'s Aledr - Alexandre "OpenSource Solutions for SmallBusiness Problems"

aledr

7:43 p.m.

I forgot to mention that it is with 1.2.x series and also needed "-DENABLE_AUTH_LOGGING" for vpopmail's CFLAGS. I'm running some servers smoothly for a few months (all using MySQL backends)...

On Wed, Sep 22, 2010 at 1:31 PM, aledr <matrixworkstation@gmail.com> wrote:

...

-- [ ]'s Aledr - Alexandre "OpenSource Solutions for SmallBusiness Problems"

Matt Brookings

7:38 p.m.

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

(Re-sending this. Didn't realize I was not replying to the list address)

On 09/22/2010 11:21 AM, Timo Sirainen wrote:

...

I tried to fix 5.5 with this change:

http://hg.dovecot.org/dovecot-1.2/rev/597e18c0bc7e

Vpopmail has always required vauth_open be called. Some people have neglected this call and so vpopmail's authentication module system was modified to expect this.

Part of the problem with this was that vpopmail was compiled with compiler optimizations which tended to randomize the initialization of the variables. Later versions of vpopmail have removed the optimization flag.

...

But I heard that it's now crashing when doing that call. (I'm not sure which ones of those above problems are with this change and which ones aren't.) And apparently that also completely broke 5.4.

It looks as if you added a call to 5.5's vauth_load_module function. There is no problem doing this in 5.5, but 5.4 does not have this function. 5.5 is meant to be backwards compatible with 5.4, and so, you do not need to call this function.

...

I'm not entirely sure about 5.4 problems. I think I remember someone saying that even when reverting the above change it didn't work.

I was able to authenticate against 5.4 cdb after removing the call to vauth_load_module, but I have not do any long-term testing.

...

...
Removing the "vpopmail support broken" line from the configure script, compiling and running seemed to work short-term. I was able to authenticate against the vpopmail plugin. I tested with vpopmail 5.4.32 and 5.5.0 using the cdb authentication module.

Please note that 5.5.0 is a development version, and it is the first version in the 5.5 branch which is re-implementing a lot of old core code.

...

I guess the problem is with MySQL.

Testing...

iEYEARECAAYFAkyaMRMACgkQIwet2/rgZyypogCaAsiYVFuyhYvazmACcH8KrLq3 lfgAn20NemKKAUhMdnHnj3PdRvvnRRfk =VuJE -----END PGP SIGNATURE-----

Timo Sirainen

7:48 p.m.

On Wed, 2010-09-22 at 11:38 -0500, Matt Brookings wrote:

...

Looks like I removed the above change a while after: http://hg.dovecot.org/dovecot-1.2/rev/7ea4e58aa356

because of: http://markmail.org/message/xvsu4z77m36suqsd

So I don't see how it could have been always required if (at least some versions) didn't compile with the function..

...

Yes, this breaks compiling with v5.4, but I remember someone saying that their v5.5 installation still crashes even with the vauth_load_module() call. (Or I think it is vauth_load_module() that crashed itself, but I couldn't verify by searching my old mails.)

Matt Brookings

8:02 p.m.

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

On 09/22/2010 11:48 AM, Timo Sirainen wrote:

...

In earlier versions there were several vauth_open_* functions, each maintained separately by each individual module that were later condensed into vauth_open across all modules.

vpopmail's development between 5.3 and the end of 5.4 were meant to bring everything together because parts of it didn't act like other parts of it, etc.

5.5's goals are also quite extensive, but it will remain backwards compatible with 5.4 calls.

...

I just completed testing of 5.4.31 MySQL and 5.5.0 MySQL. If vauth_open(0) is called, both versions authenticate.

Again, I need to stress that 5.5.0 is a development version. If something segfaults against a development version, the user should downgrade to the stable version, but my (short-term) testing shows the latest copy from Subversion on SourceForge authenticates.

vauth_open is the required call for all modules, across all current versions. I believe Dovecot is only doing read operations with vpopmail, so it should call vauth_open(0), which establishes a read-only connection to slave servers (if the authentication module supports this).

Can anyone else verify this? If it fails for you, please provide duplication instructions, along with your configure flags for vpopmail and its authentication module if using 5.5.

Thanks!

iEYEARECAAYFAkyaNr8ACgkQIwet2/rgZywcBwCgkCO+a48qpzo7xKIdZvE52tct OxUAniafYylj8dl6uiXBnsIwBmlkCRFh =qI5I -----END PGP SIGNATURE-----

Timo Sirainen

8:13 p.m.

On Wed, 2010-09-22 at 12:02 -0500, Matt Brookings wrote:

...

I just completed testing of 5.4.31 MySQL and 5.5.0 MySQL. If vauth_open(0) is called, both versions authenticate.

So the attached patch should make it work ok?

Matt Brookings

8:16 p.m.

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

On 09/22/2010 12:13 PM, Timo Sirainen wrote:

...

That's the change I made in 2.0.3. Hopefully someone else can double-check. aledr maybe? :)

iEYEARECAAYFAkyaOekACgkQIwet2/rgZyzsuwCfXz43s5MuQvwwT2mlziirMyBQ EboAn2jtoujykxMUhGmh4KwqpwulDftm =gXzx -----END PGP SIGNATURE-----

aledr

9:26 p.m.

I can test it at night (-0300 here) with a 2.0.3 install...

On Wed, Sep 22, 2010 at 2:16 PM, Matt Brookings <matt@inter7.com> wrote:

...

-- [ ]'s Aledr - Alexandre "OpenSource Solutions for SmallBusiness Problems"

Matt Brookings

10:54 p.m.

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

On 09/22/2010 01:26 PM, aledr wrote:

...

I can test it at night (-0300 here) with a 2.0.3 install...

Much appreciated.

iEYEARECAAYFAkyaXuEACgkQIwet2/rgZyyTjACdH3k6JILDPStJagUJdJMfN+4S xr4An2+PWgXfLuGLfvScrcmPseV7TT8L =dqcc -----END PGP SIGNATURE-----

aledr

23 Sep 23 Sep

12:28 a.m.

Update done to 2.0.3 and server still nice with last auth working...

P.S.: Running vpopmail on trunk.

Regards.

On Wed, Sep 22, 2010 at 4:54 PM, Matt Brookings <matt@inter7.com> wrote:

...

-- [ ]'s Aledr - Alexandre "OpenSource Solutions for SmallBusiness Problems"

Jason 'XenoPhage' Frisvold

4:15 a.m.

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

On Sep 22, 2010, at 1:13 PM, Timo Sirainen wrote:

...

So the attached patch should make it work ok?

Would this remove the requirement for vpopmail 5.5+ for dovecot 2.x? I'm eager to move to 2.x, but I'm reluctant to run a dev version of vpopmail..

Thanks,

Jason 'XenoPhage' Frisvold xenophage@godshell.com

"Any sufficiently advanced magic is indistinguishable from technology."

- Niven's Inverse of Clarke's Third Law

-----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.14 (Darwin)

iEYEARECAAYFAkyaqjwACgkQ8CjzPZyTUTTmUQCeI2o8nRQ0Ak2HDzfgQLKrcJC2 H8IAmwYyF1aIqebx6EorCJSTozAEn1Sc =WhmJ -----END PGP SIGNATURE-----

5351

Age (days ago)

5352

Last active (days ago)

List overview

12 comments

4 participants

participants (4)

aledr
Jason 'XenoPhage' Frisvold
Matt Brookings
Timo Sirainen