[Dovecot] Released 1.0.rc31

Timo Sirainen tss at iki.fi
Tue Apr 10 17:15:29 EEST 2007

On Mon, 2007-04-09 at 09:07 -0400, Justin McAleer wrote:

> Moving the dotlock creation after a successful call to 
> mail_storage_create_with_data makes everything happy, but I defer to
> you 
> whether it's safe to call that before locking. 

Hmm. I guess that'd work. I'm not touching v1.0 anymore, but done to CVS
HEAD: http://dovecot.org/list/dovecot-cvs/2007-April/008624.html

> Here's the diff:

Please use diff -u whenever sending diffs. The default diff format is
horrible to read.

Anyway I think it's not really correct, because this needs to be done
after locking (although it's pretty unlikely to happen):

	/* just in case if another process just had converted the mailbox,
	   reopen the source storage */
	if (mail_storage_create(source_ns, NULL, source_data, user,
				src_flags, lock_method) < 0) {
		/* No need for conversion anymore. */
		return 0;

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://dovecot.org/pipermail/dovecot/attachments/20070410/bb5958ac/attachment.pgp 

More information about the dovecot mailing list