[Dovecot] Re: [PATCH, RFC 8/13] OTP: add sql passdb support

[Timo Sirainen]

On Mon, 2006-06-26 at 16:58 +0400, Andrey Panin wrote:
> +	MEMBER(update_query) "UPDATE users SET password = '%c' WHERE userid = '%u'",
..
> +	buf = buffer_create_dynamic(unsafe_data_stack_pool, 128);
> +
> +	tmp.key = 'c';
> +	tmp.value = new_credentials;
> +	buffer_append(buf, &tmp, sizeof(tmp));
> +
> +	tab = auth_request_get_var_expand_table(request, passdb_sql_escape);
> +	do {
> +		 buffer_append(buf, tab++, sizeof(*tab));
> +	} while (tab->key != '\0');

I haven't looked at the patches too closely yet, but how about using the
existing %w instead of adding a new %c?

Otherwise looks good. Well, except PASSS could be changed to something
else :) SETCRED maybe.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://dovecot.org/pipermail/dovecot/attachments/20060626/87d58d1a/attachment.pgp