[dovecot/core | refs/heads/master] 590bdf56: lib-smtp: smtp-client-transaction - Add event field for the amount of data sent.

Thu Feb 21 03:00:10 EET 2019

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 590bdf56a5c33d8ce797f4c43172b1504de54185
      https://github.com/dovecot/core/commit/590bdf56a5c33d8ce797f4c43172b1504de54185
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-21 (Thu, 21 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-transaction.c

  Log Message:
  -----------
  lib-smtp: smtp-client-transaction - Add event field for the amount of data sent.

  Commit: b81fe08691dda0ca74b9224c2beb53279353196d
      https://github.com/dovecot/core/commit/b81fe08691dda0ca74b9224c2beb53279353196d
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-21 (Thu, 21 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-command.c
    M src/lib-smtp/smtp-client-command.h
    M src/lib-smtp/smtp-client-transaction.c

  Log Message:
  -----------
  lib-smtp: smtp-client - Perform the LF -> CRLF conversion for the message data in the transaction.

Before, it was performed in the DATA/BDAT command code, which makes it very
difficult to extract post-conversion size statistics.

  Commit: 03750acdc99f83ed69608bebc57fc105eeff1dbf
      https://github.com/dovecot/core/commit/03750acdc99f83ed69608bebc57fc105eeff1dbf
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-20 (Wed, 20 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-command.h

  Log Message:
  -----------
  lib-smtp: smtp-client-command.h - Reformat the comments for the standard commands.

  Commit: 314de9a79fcb0a11c34848e231d8973d4c216aaa
      https://github.com/dovecot/core/commit/314de9a79fcb0a11c34848e231d8973d4c216aaa
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-20 (Wed, 20 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-private.h
    M src/lib-smtp/smtp-client-transaction.c

  Log Message:
  -----------
  lib-smtp: smtp-client-transaction - Emit named recipient events.

  Commit: 39702fdc63dbf031511ae0226631afbb7538f3bf
      https://github.com/dovecot/core/commit/39702fdc63dbf031511ae0226631afbb7538f3bf
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-20 (Wed, 20 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-transaction.c

  Log Message:
  -----------
  lib-smtp: smtp-client-transaction - Emit named events.

  Commit: b51b1e6d07da9ff5be8b45915d8bf5abea099acd
      https://github.com/dovecot/core/commit/b51b1e6d07da9ff5be8b45915d8bf5abea099acd
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-transaction.c

  Log Message:
  -----------
  lib-smtp: smtp-client-transaction - Pass last reply to smtp_client_transaction_finish().

  Commit: 1765e5368e03a793775c922c96b5c18113ba781a
      https://github.com/dovecot/core/commit/1765e5368e03a793775c922c96b5c18113ba781a
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-private.h
    M src/lib-smtp/smtp-client-transaction.c

  Log Message:
  -----------
  lib-smtp: smtp-client-transaction - Record the first failure reply of the DATA command.

This is needed when the DATA command yields more than a single reply (LMTP).

  Commit: b42b23e0f239ae3aa0badf8f3fe8bc3059527ba7
      https://github.com/dovecot/core/commit/b42b23e0f239ae3aa0badf8f3fe8bc3059527ba7
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-private.h
    M src/lib-smtp/smtp-client-transaction.c

  Log Message:
  -----------
  lib-smtp: smtp-client-transaction - Record recipient statistics in the transaction.

  Commit: c32ee89cd4965628c160ec69a96208b79e8d2597
      https://github.com/dovecot/core/commit/c32ee89cd4965628c160ec69a96208b79e8d2597
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-transaction.c

  Log Message:
  -----------
  lib-smtp: smtp-client-transaction - Drop smtp_client_transaction_rcpt_drop_pending() as a separate function.

It is now merged into smtp_client_transaction_rcpt_approved() to make the code
less confusing.

  Commit: 297af1b7db2ee7c01fd5a26e84764131a46e0509
      https://github.com/dovecot/core/commit/297af1b7db2ee7c01fd5a26e84764131a46e0509
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-private.h
    M src/lib-smtp/smtp-client-transaction.c

  Log Message:
  -----------
  lib-smtp: smtp-client-transaction - Drop the rcpt->failed flag.

It is no longer needed.

  Commit: 011efc36d853b5706353147d6b8c68bfd49371e0
      https://github.com/dovecot/core/commit/011efc36d853b5706353147d6b8c68bfd49371e0
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-private.h
    M src/lib-smtp/smtp-client-transaction.c

  Log Message:
  -----------
  lib-smtp: smtp-client-transaction - Explicitly keep track of whether a recipient is already finished.

  Commit: e9622c3a4fc7f143825cc8c0e563b5f7a12ef8a3
      https://github.com/dovecot/core/commit/e9622c3a4fc7f143825cc8c0e563b5f7a12ef8a3
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-transaction.c

  Log Message:
  -----------
  lib-smtp: smtp-client-transaction - Free the rcpt object in smtp_client_transaction_rcpt_fail_reply().

  Commit: 04f6811d224aeb78a8d7d508c401b4ee30bb0cef
      https://github.com/dovecot/core/commit/04f6811d224aeb78a8d7d508c401b4ee30bb0cef
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-transaction.c

  Log Message:
  -----------
  lib-smtp: smtp-client-transaction - Handle recipient failure callback in a separate _rcpt function.

  Commit: bbf3b9822b2e48ed49e94fefa2587477b1bd60a6
      https://github.com/dovecot/core/commit/bbf3b9822b2e48ed49e94fefa2587477b1bd60a6
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-transaction.c

  Log Message:
  -----------
  lib-smtp: smtp-client-transaction - Handle recipient DATA callback in a separate _rcpt function.

  Commit: 14634a8c1071a84ebbc60f5ac4b921bbb99786ae
      https://github.com/dovecot/core/commit/14634a8c1071a84ebbc60f5ac4b921bbb99786ae
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-transaction.c

  Log Message:
  -----------
  lib-smtp: smtp-client-transaction - Handle RCPT reply in a separate _rcpt function.

  Commit: 1bdf8585ec8b83006772d59a72e3283366c688e7
      https://github.com/dovecot/core/commit/1bdf8585ec8b83006772d59a72e3283366c688e7
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-transaction.c

  Log Message:
  -----------
  lib-smtp: smtp-client-transaction - Free the mail object in smtp_client_transaction_mail_fail_reply().

  Commit: 5876926c1cbf44d7ca5d8b7acee6abe11f32b54c
      https://github.com/dovecot/core/commit/5876926c1cbf44d7ca5d8b7acee6abe11f32b54c
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-transaction.c

  Log Message:
  -----------
  lib-smtp: smtp-client-transaction - Handle MAIL failure callback in a separate _mail function.

  Commit: 4cee6021b28d6b4e4bd147379d4b41f3af6792a2
      https://github.com/dovecot/core/commit/4cee6021b28d6b4e4bd147379d4b41f3af6792a2
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-transaction.c

  Log Message:
  -----------
  lib-smtp: smtp-client-transaction - Handle MAIL reply in a separate _mail function.

  Commit: 5169b6546034756214779ec4c287278b3e4fd631
      https://github.com/dovecot/core/commit/5169b6546034756214779ec4c287278b3e4fd631
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-params.c
    M src/lib-smtp/smtp-params.h

  Log Message:
  -----------
  lib-smtp: smtp-params - Add support for adding RCPT parameters to an event.

  Commit: ca361960e653099f4a9eba1b2f90781bdf60eef9
      https://github.com/dovecot/core/commit/ca361960e653099f4a9eba1b2f90781bdf60eef9
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-params.c
    M src/lib-smtp/smtp-params.h

  Log Message:
  -----------
  lib-smtp: smtp-params - Add support for adding MAIL parameters to an event.

  Commit: 475c2396cc73c3e72b4fad8bb2e7491455762fc8
      https://github.com/dovecot/core/commit/475c2396cc73c3e72b4fad8bb2e7491455762fc8
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-command.c
    M src/lib-smtp/smtp-client-private.h

  Log Message:
  -----------
  lib-smtp: smtp-client-command - Emit named events.

  Commit: 1a4670936382e1b4d742bf259845c1a81173cc6b
      https://github.com/dovecot/core/commit/1a4670936382e1b4d742bf259845c1a81173cc6b
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-command.c

  Log Message:
  -----------
  lib-smtp: smtp-client-command - Create local variable for "was_sent" command status.

The condition is amended with (state < SMTP_CLIENT_COMMAND_STATE_FINISHED),
because that part is now checked after the intiialization of this variable
(causing the function to exit). It is important that the content of this
variable makes sense immediately (for future changes), rather than only after
the if statement that checks the added condition.

  Commit: 1c2e805d622d6a99a4651f40bd267d439e51fd23
      https://github.com/dovecot/core/commit/1c2e805d622d6a99a4651f40bd267d439e51fd23
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-command.c

  Log Message:
  -----------
  lib-smtp: smtp-client-command - Rename "waslocked" to "was_locked" in smtp_client_command_abort().

  Commit: add9d1342f09b7e4274bdd004d2130375b506b1c
      https://github.com/dovecot/core/commit/add9d1342f09b7e4274bdd004d2130375b506b1c
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-reply.c
    M src/lib-smtp/smtp-reply.h

  Log Message:
  -----------
  lib-smtp: smtp-reply - Add smtp_reply_add_to_event().

This sets standard reply fields in the provided pass-through event.

  Commit: 29adc6358e99889296c797c287957ad4d59332e6
      https://github.com/dovecot/core/commit/29adc6358e99889296c797c287957ad4d59332e6
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-connection.c

  Log Message:
  -----------
  lib-smtp: smtp-client-connection - Add peer fields to the connection events.

  Commit: f2f8b0417c7317a2c0331f94fa1694e03893f770
      https://github.com/dovecot/core/commit/f2f8b0417c7317a2c0331f94fa1694e03893f770
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-command.c
    M src/lib-smtp/smtp-client-connection.c
    M src/lib-smtp/smtp-client-transaction.c

  Log Message:
  -----------
  lib-smtp: smtp-client - Replace smtp_*_debug() with e_debug().

  Commit: c04778be5dc6e2e6f4727a5a43c88f707e52488c
      https://github.com/dovecot/core/commit/c04778be5dc6e2e6f4727a5a43c88f707e52488c
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-connection.c

  Log Message:
  -----------
  lib-smtp: smtp-client - Replace smtp_*_warning() with e_warning().

  Commit: e603e55da40c0d21994432f6d756af979573afab
      https://github.com/dovecot/core/commit/e603e55da40c0d21994432f6d756af979573afab
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-command.c
    M src/lib-smtp/smtp-client-connection.c

  Log Message:
  -----------
  lib-smtp: smtp-client - Replace smtp_*_error() with e_error().

  Commit: 935391aea9fad373cb77abf2b26f0c775ae2608f
      https://github.com/dovecot/core/commit/935391aea9fad373cb77abf2b26f0c775ae2608f
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-connection.c

  Log Message:
  -----------
  lib-smtp: smtp-client - Replace i_error() with e_error().

  Commit: ba7a90ed683c47fd1511d7392c3c0d4cfcfe1ff5
      https://github.com/dovecot/core/commit/ba7a90ed683c47fd1511d7392c3c0d4cfcfe1ff5
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-command.c
    M src/lib-smtp/smtp-client-connection.c
    M src/lib-smtp/smtp-client-transaction.c

  Log Message:
  -----------
  lib-smtp: smtp-client - Remove redundant debug logging checks.

  Commit: a4d06d557e39860af71675097fca0a641cab73c7
      https://github.com/dovecot/core/commit/a4d06d557e39860af71675097fca0a641cab73c7
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-command.c
    M src/lib-smtp/smtp-client-connection.c
    M src/lib-smtp/smtp-client-private.h
    M src/lib-smtp/smtp-client-transaction.c
    M src/lib-smtp/smtp-client-transaction.h
    M src/lib-smtp/smtp-client.c
    M src/lib-smtp/smtp-client.h

  Log Message:
  -----------
  lib-smtp: smtp-client - Add support for event API.

  Commit: 208a90a55d188a580524b7ddcf080147ec7e5348
      https://github.com/dovecot/core/commit/208a90a55d188a580524b7ddcf080147ec7e5348
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-command.c

  Log Message:
  -----------
  lib-smtp: smtp-client-command - Split command name extraction from label construction.

  Commit: 9831d77f164e4ce1e0fbacef73929d141f25fc49
      https://github.com/dovecot/core/commit/9831d77f164e4ce1e0fbacef73929d141f25fc49
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-19 (Tue, 19 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-reply.c
    M src/lib-smtp/smtp-reply.h

  Log Message:
  -----------
  lib-smtp: smtp-reply - Add smtp_reply_get_message().

Returns only the message of the reply without statuses as a single line.

  Patch: https://github.com/dovecot/core/compare/4adda9a677d2...590bdf56a5c3.patch