[dovecot/core | refs/heads/master-2.3] 511f513f: lib-smtp: client: Move connection to TRANSACTION state immediately when a transaction is started.

[noreply at dovecot.org]

  Branch: refs/heads/master-2.3
  Home:   https://github.com/dovecot/core
  Commit: 511f513f6e314f8d2cc9642856d489703605fd66
      https://github.com/dovecot/core/commit/511f513f6e314f8d2cc9642856d489703605fd66
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-18 (Mon, 18 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-connection.c

  Log Message:
  -----------
  lib-smtp: client: Move connection to TRANSACTION state immediately when a transaction is started.

Before, it waited until the actual start handler was called from timeout, but
that causes a race condition with mtp_client_connection_abort_transaction(),
which in turn causes an assert panic.

Panic was:

Panic: file smtp-client-connection.c: line 2153 (smtp_client_connection_abort_transaction): assertion failed: (conn->state != SMTP_CLIENT_CONNECTION_STATE_READY)

  Commit: cd7ea3c820231e9b36b7f405a95a3becf96c723b
      https://github.com/dovecot/core/commit/cd7ea3c820231e9b36b7f405a95a3becf96c723b
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-18 (Mon, 18 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-connection.c

  Log Message:
  -----------
  lib-smtp: client: Properly reset connection state upon reconnect.

  Commit: 615d91af7a54fe9e77852e59d051474b7a9c5685
      https://github.com/dovecot/core/commit/615d91af7a54fe9e77852e59d051474b7a9c5685
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-02-18 (Mon, 18 Feb 2019)

  Changed paths:
    M src/lib-smtp/smtp-client-connection.c

  Log Message:
  -----------
  lib-smtp: client: connection: Prevent timeout leak for transaction start.

Perform timeout management in a single place. Also, always start the next
transaction only through a timeout.

  Patch: https://github.com/dovecot/core/compare/808f0731ce94...511f513f6e31.patch