[dovecot/core] 85336e: submission: backends: Set the started flag before ...

Mon Oct 29 22:00:08 EET 2018

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 85336e7e9b500bd15d3593e9a464e4d490db282a
      https://github.com/dovecot/core/commit/85336e7e9b500bd15d3593e9a464e4d490db282a
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/submission/submission-backend.c

  Log Message:
  -----------
  submission: backends: Set the started flag before calling the backend start vfunc.

This prevents recursive mishaps.

  Commit: d37c69505acf7f24d956fb655ffd9a0a2f163ded
      https://github.com/dovecot/core/commit/d37c69505acf7f24d956fb655ffd9a0a2f163ded
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/submission/submission-backend.c

  Log Message:
  -----------
  submission: relay backend: Fix non-transaction commands to work when submission_backend_capabilities is configured.

When submission_backend_capabilities is configured, the backend is not started
until the first transaction is started. But for commands that should work
outside the transaction, the backend should also be started, which was not the
case before this fix.

  Commit: c673f4ff718998764e9048e76f9bcfdb43954e8a
      https://github.com/dovecot/core/commit/c673f4ff718998764e9048e76f9bcfdb43954e8a
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/submission-login/client-authenticate.c

  Log Message:
  -----------
  submission-login: Add the VRFY capability to the EHLO reply.

The post-login service does it too.

  Commit: 26daf8726932f8019ce160fc4bf914c92db537c6
      https://github.com/dovecot/core/commit/26daf8726932f8019ce160fc4bf914c92db537c6
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/submission-login/client-authenticate.c
    M src/submission-login/client.c
    M src/submission-login/client.h
    M src/submission-login/submission-login-settings.c
    M src/submission-login/submission-login-settings.h

  Log Message:
  -----------
  submission-login: Use the submission_backend_capabilities setting to compose the EHLO reply when configured.

This way, the EHLO response prior to AUTH will better match the EHLO response after AUTH.

  Commit: 24896b110eef7d2bd247acb53e20ccf7cfbe1abd
      https://github.com/dovecot/core/commit/24896b110eef7d2bd247acb53e20ccf7cfbe1abd
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/submission-login/client-authenticate.c
    M src/submission/submission-client.c
    M src/submission/submission-commands.c

  Log Message:
  -----------
  submission,submission-login: Omit listing VRFY capability if the backend provides no explicit support.

  Commit: 275fcbf07ef1d51f080ad2a2c088f7c04e18d7b4
      https://github.com/dovecot/core/commit/275fcbf07ef1d51f080ad2a2c088f7c04e18d7b4
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-vrfy.c
    M src/lib-smtp/smtp-server.h

  Log Message:
  -----------
  lib-smtp: server: VRFY command: Implement smtp_server_cmd_reply_default() for sending default reply.

  Commit: 1ea5d9aac118b64d54de64333e45513338194cf7
      https://github.com/dovecot/core/commit/1ea5d9aac118b64d54de64333e45513338194cf7
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/submission/submission-backend-relay.c

  Log Message:
  -----------
  submission: relay backend: VRFY command: Avoid forwarding 500 and 502 replies back to client.

These are in fact non-standard for VRFY and indicate that VRFY support is
disabled, which is not allowed by the specification. Instead, we now substitute
the default 252 response.

  Commit: daca99f554f1caa8c4b2b84f80e3296696e1917a
      https://github.com/dovecot/core/commit/daca99f554f1caa8c4b2b84f80e3296696e1917a
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/submission-login/client.c
    M src/submission/submission-client.c

  Log Message:
  -----------
  submission,submission-login: Implicitly enable CHUNKING when submission_backend_capabilities setting includes BINARYMIME.

BINARYMIME requires CHUNKING support and we should not expect administrators to
always be aware of that fact.

  Commit: 6a7a98339e836ba7bded6ce6e68388ff512a9f38
      https://github.com/dovecot/core/commit/6a7a98339e836ba7bded6ce6e68388ff512a9f38
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M doc/example-config/conf.d/20-submission.conf

  Log Message:
  -----------
  doc: example-config: Document the new submission_backend_capabilities setting.

  Commit: dc820f23d878ab3c6896dd7fcdb78fe1e86d6d7c
      https://github.com/dovecot/core/commit/dc820f23d878ab3c6896dd7fcdb78fe1e86d6d7c
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/submission/submission-backend.c

  Log Message:
  -----------
  submission: backend: Properly reset the trans_started flag upon trans_free().

  Commit: 5872f2dd3c92e65e097640e030503d48ef51b760
      https://github.com/dovecot/core/commit/5872f2dd3c92e65e097640e030503d48ef51b760
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/submission/submission-backend-relay.c

  Log Message:
  -----------
  submission: relay backend: Always reset the trans_started flag upon trans_free().

  Commit: 383924fdcda91ddde7a9b59f69e4d4ed502d4abd
      https://github.com/dovecot/core/commit/383924fdcda91ddde7a9b59f69e4d4ed502d4abd
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-mail.c
    M src/lib-smtp/smtp-server.h

  Log Message:
  -----------
  lib-smtp: server: MAIL command: Implement smtp_server_cmd_mail_reply_success() for sending default success reply.

  Commit: 16a1735415a9de3e1c4b976a3d8fea2c1f08e16f
      https://github.com/dovecot/core/commit/16a1735415a9de3e1c4b976a3d8fea2c1f08e16f
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-rcpt.c
    M src/lib-smtp/smtp-server.h

  Log Message:
  -----------
  lib-smtp: server: RCPT command: Implement smtp_server_cmd_rcpt_reply_success() for sending default success reply.

  Commit: 9eb0245f8ab27916ec7efcd41d03f40e7726c164
      https://github.com/dovecot/core/commit/9eb0245f8ab27916ec7efcd41d03f40e7726c164
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-rset.c
    M src/lib-smtp/smtp-server.h

  Log Message:
  -----------
  lib-smtp: server: RSET command: Implement smtp_server_cmd_rset_reply_success() for sending default success reply.

  Commit: ca137b15dd59e5278541d7b0cf0c5afc074b2e78
      https://github.com/dovecot/core/commit/ca137b15dd59e5278541d7b0cf0c5afc074b2e78
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-noop.c
    M src/lib-smtp/smtp-server.h

  Log Message:
  -----------
  lib-smtp: server: NOOP command: Implement smtp_server_cmd_noop_reply_success() for sending default success reply.

  Commit: 58017c0b46837d42c174006b4a42030d0578d356
      https://github.com/dovecot/core/commit/58017c0b46837d42c174006b4a42030d0578d356
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/lmtp/lmtp-local.c

  Log Message:
  -----------
  lmtp: local: Use the new smtp_server_cmd_rcpt_reply_success() function.

  Commit: 33125ccbdddf4d0f42999771326929c12881dd6c
      https://github.com/dovecot/core/commit/33125ccbdddf4d0f42999771326929c12881dd6c
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/submission/submission-backend-relay.c

  Log Message:
  -----------
  submission: Use the new smtp_server_cmd_noop_reply_success() function.

  Commit: 841a7736afcd35050463637a49245edce76b2594
      https://github.com/dovecot/core/commit/841a7736afcd35050463637a49245edce76b2594
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/submission/submission-backend.h
    M src/submission/submission-client.h

  Log Message:
  -----------
  submission: Clarify the behavior of command handlers and the requirements for overriding them.

  Commit: 8d4a0e06086b69ad4e1f58388418751fa83949ff
      https://github.com/dovecot/core/commit/8d4a0e06086b69ad4e1f58388418751fa83949ff
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/lib-smtp/smtp-client-command.c
    M src/lib-smtp/smtp-client-connection.c
    M src/lib-smtp/smtp-client-private.h

  Log Message:
  -----------
  lib-smtp: client: connection: Consolidate capability data into a struct.

Allows clearing it reliably.

  Commit: 55c07f50160edfab20abf33e8499ce472aa3c1e8
      https://github.com/dovecot/core/commit/55c07f50160edfab20abf33e8499ce472aa3c1e8
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/lib-smtp/smtp-client-connection.c
    M src/lib-smtp/smtp-client-connection.h
    M src/lib-smtp/smtp-client-private.h
    M src/lib-smtp/smtp-client.c
    M src/lib-smtp/smtp-client.h
    M src/lib-smtp/smtp-common.h

  Log Message:
  -----------
  lib-smtp: client: Add support for recording extra (non-standard) capabilities from server.

  Commit: 56b9f1ba787c331ea53d34456b8c473c4b6e549d
      https://github.com/dovecot/core/commit/56b9f1ba787c331ea53d34456b8c473c4b6e549d
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/submission/submission-backend-relay.c
    M src/submission/submission-backend-relay.h
    M src/submission/submission-client.c
    M src/submission/submission-client.h

  Log Message:
  -----------
  submission: relay backend: Provide access to the client connection and transaction for plugins.

  Commit: 9896a12d8d153343bfbff6783390c7104d7d93f4
      https://github.com/dovecot/core/commit/9896a12d8d153343bfbff6783390c7104d7d93f4
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/submission/submission-backend-relay.c
    M src/submission/submission-backend-relay.h

  Log Message:
  -----------
  submission: relay backend: Allow recording extra (non-standard) capabilities.

  Commit: 0e2f17dbd5ecc93559f457058ff5f3aeb6cf4cdb
      https://github.com/dovecot/core/commit/0e2f17dbd5ecc93559f457058ff5f3aeb6cf4cdb
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/lib-smtp/smtp-params.h

  Log Message:
  -----------
  lib-smtp: params: Explicitly allow smtp_params_*_add_extra() value parameter to be NULL.

  Commit: 19b619782af9736f0ac60cef57a196ed29503015
      https://github.com/dovecot/core/commit/19b619782af9736f0ac60cef57a196ed29503015
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/submission/submission-backend.c
    M src/submission/submission-backend.h

  Log Message:
  -----------
  submission: Add backend vfunc called when the backend is ready.

For a relay backend, this means that the connection is fully connected and
handshaked. For any backend it means the capabilities are known (and passed as a
parameter to the ready function).

  Commit: dd2814d7532d0fa63b8b81f6e044c27bfecf7ebd
      https://github.com/dovecot/core/commit/dd2814d7532d0fa63b8b81f6e044c27bfecf7ebd
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/submission/submission-backend.c
    M src/submission/submission-backend.h

  Log Message:
  -----------
  submission: Add backend flag indicating whether the backend is ready.

This flag is set just before the ready() vfunc is called.

  Commit: 7017982a5d8835591e7fe641493e511ab8403220
      https://github.com/dovecot/core/commit/7017982a5d8835591e7fe641493e511ab8403220
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/submission/submission-backend-relay.c
    M src/submission/submission-backend.c
    M src/submission/submission-backend.h

  Log Message:
  -----------
  submission: Add support for modifying the transaction path and parameters in the trans_start backend vfunc.

To keep the changes limited to a particular backend, the server transaction
cannot be modified. Also, creating a mock server transaction and passing it on
is not a good idea, since it is not a simple container struct.

  Commit: 83fd3b1c9e807889c8e1482a3f23fadea4296c99
      https://github.com/dovecot/core/commit/83fd3b1c9e807889c8e1482a3f23fadea4296c99
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/submission/submission-backend-relay.c
    M src/submission/submission-backend.c
    M src/submission/submission-backend.h

  Log Message:
  -----------
  submission: Allocate each backend on its own pool.

This allows allocating per-backend module data.

  Commit: a41510dd8e34a400af5fd21f030d0f6ea168af00
      https://github.com/dovecot/core/commit/a41510dd8e34a400af5fd21f030d0f6ea168af00
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/submission/submission-backend.c
    M src/submission/submission-backend.h

  Log Message:
  -----------
  submission: Add support for module contexts to backend.

  Commit: ad9247768a2a6df6490a024bb3a0f79ca4618804
      https://github.com/dovecot/core/commit/ad9247768a2a6df6490a024bb3a0f79ca4618804
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/lib-smtp/smtp-client-private.h
    M src/lib-smtp/smtp-client-transaction.c
    M src/lib-smtp/smtp-client-transaction.h
    M src/lib-smtp/smtp-submit.c
    M src/lib-smtp/test-smtp-client-errors.c
    M src/lib-smtp/test-smtp-payload.c
    M src/lmtp/lmtp-proxy.c
    M src/submission/submission-backend-relay.c

  Log Message:
  -----------
  lib-smtp: client: Allow enabling the LMTP per-RCPT DATA reply behavior for ESMTP transactions.

This is non-standard.

  Commit: 3bbf1d4a2ccaf40f99d67cc697087c7d80fa7b8f
      https://github.com/dovecot/core/commit/3bbf1d4a2ccaf40f99d67cc697087c7d80fa7b8f
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M src/submission/submission-backend-relay.c
    M src/submission/submission-backend-relay.h

  Log Message:
  -----------
  submission: relay backend: Allow creating the client transaction with specific flags.

  Commit: dbf5c611358902192b2c25381738400d70b0ad09
      https://github.com/dovecot/core/commit/dbf5c611358902192b2c25381738400d70b0ad09
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-10-29 (Mon, 29 Oct 2018)

  Changed paths:
    M dovecot-config.in.in
    M m4/dovecot.m4

  Log Message:
  -----------
  submission: Make include directory available to external plugins.

Compare: https://github.com/dovecot/core/compare/c1ea6e17901d...dbf5c6113589
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.