[dovecot/core] ae44ba: doveadm: Make sure to stop running commands requir...

[GitHub]

  Branch: refs/heads/release-2.3.3
  Home:   https://github.com/dovecot/core
  Commit: ae44bab086d77193dcdf9dbc1634cf160e5e9557
      https://github.com/dovecot/core/commit/ae44bab086d77193dcdf9dbc1634cf160e5e9557
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-09-24 (Mon, 24 Sep 2018)

  Changed paths:
    M src/director/doveadm-connection.c
    M src/director/doveadm-connection.h
    M src/director/main.c

  Log Message:
  -----------
  doveadm: Make sure to stop running commands requiring synced ring when ring is no longer synced

A command could desync the ring, and no more commands should be run
afterwards.

This also fixes a bug where a command that desyncs the ring is supposed to
wait for the ring being synced before returning OK, but returns it
immediately instead.


  Commit: 2fbbccc0a31f3063eeda2b4f59449cf6eec2d0b0
      https://github.com/dovecot/core/commit/2fbbccc0a31f3063eeda2b4f59449cf6eec2d0b0
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-09-24 (Mon, 24 Sep 2018)

  Changed paths:
    M src/director/doveadm-connection.c

  Log Message:
  -----------
  director: Add assert to make sure doveadm connection's IO isn't added multiple times


  Commit: 0c22bd104f4ed0f56bf7604e6428abdd09f4c5b7
      https://github.com/dovecot/core/commit/0c22bd104f4ed0f56bf7604e6428abdd09f4c5b7
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-09-24 (Mon, 24 Sep 2018)

  Changed paths:
    M src/director/doveadm-connection.c

  Log Message:
  -----------
  director: Fix assert-crash when doveadm disconnects immediately after sending command

Any command that requires a ring sync should cause the doveadm connection to
wait until the ring is synced. However, if the disconnection happened early
enough the connection is deinitialized before the ring sync is finished.

Fixes:
Panic: file doveadm-connection.c: line 1097 (doveadm_connection_deinit): assertion failed: (conn->to_ring_sync_abort == NULL)


  Commit: d25951928ccd2da6bc97dc1c5f12fa674395db9f
      https://github.com/dovecot/core/commit/d25951928ccd2da6bc97dc1c5f12fa674395db9f
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-09-25 (Tue, 25 Sep 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-data.c

  Log Message:
  -----------
  lib-smtp: server: Restructure reference counting of BDAT/BURL chain stream.

It is now dereferenced directly, rather than via a local variable; thereby
making sure it is reset to NULL.


  Commit: 2636474cc927612c5beca226abe8b67798bdffef
      https://github.com/dovecot/core/commit/2636474cc927612c5beca226abe8b67798bdffef
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-09-25 (Tue, 25 Sep 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-connection.c

  Log Message:
  -----------
  lib-smtp: server: connection: Rely on i_stream_destroy(NULL) being a no-op.


  Commit: 999c74680dbb413277b466c1cccf247bf688e168
      https://github.com/dovecot/core/commit/999c74680dbb413277b466c1cccf247bf688e168
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-09-25 (Tue, 25 Sep 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-data.c
    M src/lib-smtp/smtp-server-connection.c

  Log Message:
  -----------
  lib-smtp: server: Fix memory leak occurring when an error occurs early for BDAT/BURL.


  Commit: 3413ea1182616a33831fa8d4015dd54f90344d44
      https://github.com/dovecot/core/commit/3413ea1182616a33831fa8d4015dd54f90344d44
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-09-25 (Tue, 25 Sep 2018)

  Changed paths:
    M src/lib-http/test-http-client-errors.c
    M src/lib-smtp/smtp-client-connection.c
    M src/lib-smtp/smtp-client-transaction.c
    M src/lib-smtp/smtp-reply-parser.c
    M src/lib-smtp/smtp-server-command.c
    M src/lib-smtp/smtp-server-connection.c
    M src/lib-smtp/smtp-server-transaction.c

  Log Message:
  -----------
  lib-smtp: Increase memory pool initial sizes

This reduces malloc traffic


  Commit: b96be88f9adea894a5584b6d2345455d804182ae
      https://github.com/dovecot/core/commit/b96be88f9adea894a5584b6d2345455d804182ae
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-09-25 (Tue, 25 Sep 2018)

  Changed paths:
    M src/submission/main.c

  Log Message:
  -----------
  submission: Reorder initialization code

login_set socket paths get invalidated when
master_service_init_finish is called, so we need
to run the code that uses them before this.


  Commit: dcead646b5f3e1b66fb463c2ea9469f9fc608b4c
      https://github.com/dovecot/core/commit/dcead646b5f3e1b66fb463c2ea9469f9fc608b4c
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M NEWS
    M configure.ac

  Log Message:
  -----------
  Released v2.3.3.


Compare: https://github.com/dovecot/core/compare/14e4920d8ced...dcead646b5f3
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.