[dovecot/pigeonhole] 8efeb6: lib-sieve: Adjust to changes in Dovecot regarding ...

[GitHub]

  Branch: refs/heads/master-0.5
  Home:   https://github.com/dovecot/pigeonhole
  Commit: 8efeb6a1a99a58a7bda2933e5e56e8779bb7aa8d
      https://github.com/dovecot/pigeonhole/commit/8efeb6a1a99a58a7bda2933e5e56e8779bb7aa8d
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sieve/sieve.c

  Log Message:
  -----------
  lib-sieve: Adjust to changes in Dovecot regarding the postmaster_address setting.


  Commit: 803055b11091fb650e36cbbd7012ea4e7978c50d
      https://github.com/dovecot/pigeonhole/commit/803055b11091fb650e36cbbd7012ea4e7978c50d
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/plugins/imap-filter-sieve/imap-filter-sieve.c

  Log Message:
  -----------
  plugins: imap-filter-sieve: Ignore secondary scripts that failed to compile.

The IMAP FILTER=SIEVE capability does not execute more than a single script yet,
but once it does, it should not assert fail on secondary scripts that failed to
compile.


  Commit: 436c45ac7c7a4892a1b0c81d0a80af6f3ef64cb0
      https://github.com/dovecot/pigeonhole/commit/436c45ac7c7a4892a1b0c81d0a80af6f3ef64cb0
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/plugins/imap-filter-sieve/cmd-filter-sieve.c

  Log Message:
  -----------
  plugins: imap-filter-sieve: Fix assertion panic occurring after script compile error.

Compile errors occurring for Sieve scripts uploaded in multiple TCP frames were
not handled correctly.


  Commit: 740cbc78d175e87677a6907e894c128a6ce7befb
      https://github.com/dovecot/pigeonhole/commit/740cbc78d175e87677a6907e894c128a6ce7befb
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/plugins/imap-filter-sieve/imap-filter-sieve.c

  Log Message:
  -----------
  plugins: imap-filter-sieve: Fix segfault occurring in recently added debug message.

The debug message pertains to skipping secondary scripts that failed to
compile. This debug message will not actually be triggered in the current
implementation, but this will become problematic in the future.

Problem found by Coverity.


  Commit: 762e55edca4fe557e541090db974a445da7f9fa2
      https://github.com/dovecot/pigeonhole/commit/762e55edca4fe557e541090db974a445da7f9fa2
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/plugins/imap-filter-sieve/imap-filter-sieve.c

  Log Message:
  -----------
  plugins: imap-filter-sieve: Add assertion on attempting to execute at least one script.

Coverity complains about last_script possibly being empty in
imap_sieve_filter_run_scripts(), which is actually not possible, since the
function would not be called if there is no script to execute. Added assertion
to make that clear.


Compare: https://github.com/dovecot/pigeonhole/compare/14aa08459a21...762e55edca4f
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.