[dovecot/core] c4efa8: master: Start service processes only after adding ...

Wed Nov 14 12:00:14 EET 2018

  Branch: refs/heads/master-2.3
  Home:   https://github.com/dovecot/core
  Commit: c4efa892fa80ac81866193d7c2ea761ff21f5e02
      https://github.com/dovecot/core/commit/c4efa892fa80ac81866193d7c2ea761ff21f5e02
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/master/service-monitor.c

  Log Message:
  -----------
  master: Start service processes only after adding all service listeners

Otherwise the processes could try to connect to services that aren't being
listened on, causing errors. Especially stats-writer socket needs to be
available early on.

  Commit: c3953cb2c9a5c6bf92807a6c50bf7f6c1010cbf0
      https://github.com/dovecot/core/commit/c3953cb2c9a5c6bf92807a6c50bf7f6c1010cbf0
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/anvil/main.c
    M src/config/doveconf.c
    M src/config/main.c
    M src/dns/dns-client.c
    M src/doveadm/main.c
    M src/imap/main.c
    M src/indexer/indexer-worker.c
    M src/lib-master/master-service-settings.c
    M src/lib-master/master-service.c
    M src/lib-master/master-service.h
    M src/lmtp/main.c
    M src/log/main.c
    M src/master/main.c
    M src/old-stats/main.c
    M src/pop3/main.c
    M src/stats/main.c
    M src/util/rawlog.c
    M src/util/script-login.c
    M src/util/script.c
    M src/util/tcpwrap.c

  Log Message:
  -----------
  global: Replace MASTER_SERVICE_FLAG_SEND_STATS with _DONT_SEND_STATS

Most services want to send statistics, so it's better to reverse the flag
behavior. Mark the few services that don't want stats with
MASTER_SERVICE_FLAG_DONT_SEND_STATS.

  Commit: 5305707ac6c96088430cca165df0c33d1b5bcc45
      https://github.com/dovecot/core/commit/5305707ac6c96088430cca165df0c33d1b5bcc45
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/stats/main.c

  Log Message:
  -----------
  stats: Wait for clients to disconnect at shutdown

  Commit: 3b74c0f1717bfa055b3683a749edfef3766f5da8
      https://github.com/dovecot/core/commit/3b74c0f1717bfa055b3683a749edfef3766f5da8
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/util/tcpwrap.c

  Log Message:
  -----------
  util: Fix compile with tcpwrap

  Commit: 198bb843d94de1278ed1851b2c95ee07df841965
      https://github.com/dovecot/core/commit/198bb843d94de1278ed1851b2c95ee07df841965
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/auth/db-sql.c
    M src/auth/db-sql.h
    M src/auth/passdb-sql.c
    M src/auth/userdb-sql.c

  Log Message:
  -----------
  auth: Add db_ prefix to sql in db-sql

Prevents clash with lib-sql

  Commit: b5b574346ea03b0a3fd1bf3fbe61c5e62e8c81b4
      https://github.com/dovecot/core/commit/b5b574346ea03b0a3fd1bf3fbe61c5e62e8c81b4
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/driver-sqlite.c

  Log Message:
  -----------
  driver-sqlite: Whitespace fix

  Commit: 21f2c88f14d2e04bbdade39369913b5260ecb3dc
      https://github.com/dovecot/core/commit/21f2c88f14d2e04bbdade39369913b5260ecb3dc
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/sql-api-private.h
    M src/lib-sql/sql-api.c
    M src/lib-sql/sql-api.h

  Log Message:
  -----------
  lib-sql: Add init_full vfunction

  Commit: 4b7ffac08dbf9e0e45b8627139dfd7e701f0dc27
      https://github.com/dovecot/core/commit/4b7ffac08dbf9e0e45b8627139dfd7e701f0dc27
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/driver-sqlpool.c

  Log Message:
  -----------
  driver-sqlpool: Use init_full when available

  Commit: 74434f07be248d9d0c04c60b79cf986af99c6c45
      https://github.com/dovecot/core/commit/74434f07be248d9d0c04c60b79cf986af99c6c45
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/driver-sqlpool.c
    M src/lib-sql/sql-api-private.h

  Log Message:
  -----------
  driver-sqlpool: Add driver_sqlpool_init_full

Needed by SQL API change

  Commit: 13dc4321d66d94ac383fd9c80ecf71b47b555282
      https://github.com/dovecot/core/commit/13dc4321d66d94ac383fd9c80ecf71b47b555282
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/driver-mysql.c

  Log Message:
  -----------
  driver-mysql: Return error in connection string parser

  Commit: a44ee862cf719de7ef5b3441e9f717c9cea79034
      https://github.com/dovecot/core/commit/a44ee862cf719de7ef5b3441e9f717c9cea79034
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/driver-mysql.c

  Log Message:
  -----------
  driver-mysql: Allocate mysql connection ourselves

This allows reusing the same mysql object on reconnect,
and simplifies cleanup in case initialization fails.

  Commit: c59b7e50b3bf8bc7f7e4b8136bbb3b10855bba22
      https://github.com/dovecot/core/commit/c59b7e50b3bf8bc7f7e4b8136bbb3b10855bba22
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/driver-mysql.c

  Log Message:
  -----------
  driver-mysql: Add init_full

  Commit: 71ad2898737347ec4a6bb33917e613aa542cc3b6
      https://github.com/dovecot/core/commit/71ad2898737347ec4a6bb33917e613aa542cc3b6
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/driver-sqlite.c

  Log Message:
  -----------
  driver-sqlite: Add init_full

  Commit: 7760d1db422e7faf09e112b0936bb395de6a7f5c
      https://github.com/dovecot/core/commit/7760d1db422e7faf09e112b0936bb395de6a7f5c
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/driver-pgsql.c

  Log Message:
  -----------
  driver-pgsql: Add driver_pgsql_free

  Commit: 1f75cca53862a2be63160fc8e9cf6214909a5996
      https://github.com/dovecot/core/commit/1f75cca53862a2be63160fc8e9cf6214909a5996
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/driver-pgsql.c

  Log Message:
  -----------
  driver-pgsql: Add init_full

  Commit: 056f0a091e0f13d4f82d42ec426783bfc844ecb9
      https://github.com/dovecot/core/commit/056f0a091e0f13d4f82d42ec426783bfc844ecb9
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/driver-cassandra.c

  Log Message:
  -----------
  driver-cassandra: Add driver_cassandra_free

  Commit: 4910d6a7bece87348ac8621261ec36013aa911ad
      https://github.com/dovecot/core/commit/4910d6a7bece87348ac8621261ec36013aa911ad
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/driver-cassandra.c

  Log Message:
  -----------
  driver-cassandra: Return error from connection string parser

  Commit: 2b19af27d98720bc009e0d1fcfc4f8a15ff439cb
      https://github.com/dovecot/core/commit/2b19af27d98720bc009e0d1fcfc4f8a15ff439cb
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/driver-cassandra.c

  Log Message:
  -----------
  driver-cassandra: Add init_full

  Commit: 95b6a4ee2819279fc8306c44fb783ce5ee2aa631
      https://github.com/dovecot/core/commit/95b6a4ee2819279fc8306c44fb783ce5ee2aa631
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/sql-db-cache.c
    M src/lib-sql/sql-db-cache.h

  Log Message:
  -----------
  lib-sql: Add sql_db_cache_new2 that uses the new sql_init_full initializer

  Commit: d459545bdb93e08ad816586b0cd9c79093445f43
      https://github.com/dovecot/core/commit/d459545bdb93e08ad816586b0cd9c79093445f43
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-dict-backend/dict-sql.c

  Log Message:
  -----------
  dict-sql: Use sql_db_cache_new2

  Commit: 0dc7ed074898effc13da9648e88ed57d3dbbe263
      https://github.com/dovecot/core/commit/0dc7ed074898effc13da9648e88ed57d3dbbe263
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-dict-backend/dict-sql.c
    M src/lib-sql/sql-db-cache.c
    M src/lib-sql/sql-db-cache.h

  Log Message:
  -----------
  global: Replace sql_db_cache_new with sql_db_cache_new2

  Commit: 19b80941c4972707758c6361896bd4c95e5aef97
      https://github.com/dovecot/core/commit/19b80941c4972707758c6361896bd4c95e5aef97
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/auth/db-sql.c

  Log Message:
  -----------
  auth: Use sql_init_full

  Commit: 5c98b165a59df94becafd1fb6181440bbe697a4b
      https://github.com/dovecot/core/commit/5c98b165a59df94becafd1fb6181440bbe697a4b
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/sql-api-private.h
    M src/lib-sql/sql-api.c
    M src/lib-sql/sql-api.h

  Log Message:
  -----------
  lib-sql: Add events

  Commit: 8ce12f90c7e29330dcea24532519f2bdee7e0cc0
      https://github.com/dovecot/core/commit/8ce12f90c7e29330dcea24532519f2bdee7e0cc0
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/driver-sqlpool.c

  Log Message:
  -----------
  driver-sqlpool: Add events

  Commit: 3b28c5934e50136873192e3c19e0189e0f1d73bb
      https://github.com/dovecot/core/commit/3b28c5934e50136873192e3c19e0189e0f1d73bb
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/driver-mysql.c

  Log Message:
  -----------
  driver-mysql: Add events

  Commit: 7adb29763b9f322e8eb48d948a9a124559310fd6
      https://github.com/dovecot/core/commit/7adb29763b9f322e8eb48d948a9a124559310fd6
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/driver-sqlite.c

  Log Message:
  -----------
  driver-sqlite: Add events

  Commit: 1d4045613a9db97559666a2ae4ab4880f3883cdb
      https://github.com/dovecot/core/commit/1d4045613a9db97559666a2ae4ab4880f3883cdb
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/driver-pgsql.c

  Log Message:
  -----------
  driver-pgsql: Add events

  Commit: 5d6e10b8ec2a0087999e23fd2f78f4d1dc559d2c
      https://github.com/dovecot/core/commit/5d6e10b8ec2a0087999e23fd2f78f4d1dc559d2c
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/driver-cassandra.c

  Log Message:
  -----------
  driver-cassandra: Add events

  Commit: e3e47b70a8fff937a74b8f033afe299a128ba7f6
      https://github.com/dovecot/core/commit/e3e47b70a8fff937a74b8f033afe299a128ba7f6
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/driver-sqlite.c

  Log Message:
  -----------
  driver-sqlite: Document why rollback is called when commit fails

  Commit: 97fefd4e272c52a06d7087e28399ef4c74d8c395
      https://github.com/dovecot/core/commit/97fefd4e272c52a06d7087e28399ef4c74d8c395
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/driver-sqlpool.c

  Log Message:
  -----------
  driver-sqlpool: Only strdup error on error

Satisfies static analyzers

  Commit: 944e03666a9db619cdbcbf8dcf06a22b5adde4c7
      https://github.com/dovecot/core/commit/944e03666a9db619cdbcbf8dcf06a22b5adde4c7
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/driver-sqlpool.c
    M src/lib-sql/sql-api.c

  Log Message:
  -----------
  lib-sql: Do not create event for old drivers

They can't use it anyways

  Commit: b8d3831a1c28d635656644f6d7124b87a4f68030
      https://github.com/dovecot/core/commit/b8d3831a1c28d635656644f6d7124b87a4f68030
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/driver-cassandra.c

  Log Message:
  -----------
  driver-cassandra: Add error to sql_query_finished event on error

  Commit: b093c4bb898c9b3a02de6f5324a32ec08a4ae25b
      https://github.com/dovecot/core/commit/b093c4bb898c9b3a02de6f5324a32ec08a4ae25b
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/driver-pgsql.c

  Log Message:
  -----------
  driver-pgsql: Add error to sql_query_finished if it fails

  Commit: bab965cea48904b883515be64dcea5054d8e0dc5
      https://github.com/dovecot/core/commit/bab965cea48904b883515be64dcea5054d8e0dc5
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/driver-sqlite.c

  Log Message:
  -----------
  driver-sqlite: Add error to sql_query_finished event on error

  Commit: b1941c4d2168a5003063680d14dccb3609b25d22
      https://github.com/dovecot/core/commit/b1941c4d2168a5003063680d14dccb3609b25d22
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/driver-sqlite.c

  Log Message:
  -----------
  driver-sqlite: Don't give false out of memory errors

Only log error from sqlite3_errmsg() when connected to the db, since
otherwise dovecot logs false "out of memory" errors.

  Commit: 071c4b1e1df00483cb5d27c82b17f74a4a20516c
      https://github.com/dovecot/core/commit/071c4b1e1df00483cb5d27c82b17f74a4a20516c
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/driver-cassandra.c
    M src/lib-sql/driver-sqlite.c
    M src/lib-sql/driver-sqlpool.c

  Log Message:
  -----------
  lib-sql: Fix wrong sql_query_finished_event() success parameter use

  Commit: 81e676523c1bf514971a1781fd96f5e9f2dd6375
      https://github.com/dovecot/core/commit/81e676523c1bf514971a1781fd96f5e9f2dd6375
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/driver-sqlite.c

  Log Message:
  -----------
  driver-sqlite: Assign db in driver_sqlite_exec()

This fixes a crash.

  Commit: c71040bfe28c11cda8e1ca27b02816aaa4a641a9
      https://github.com/dovecot/core/commit/c71040bfe28c11cda8e1ca27b02816aaa4a641a9
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M src/lib-sql/driver-sqlite.c

  Log Message:
  -----------
  driver-sqlite: Fix crash and event leak in driver_sqlite_query_s()

Compare: https://github.com/dovecot/core/compare/9b32699fee4a...c71040bfe28c
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.