[dovecot/core] 0eee74: lib-smtp: Consistently use signed integer for refe...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 0eee7483da4cf7608d41f23a1f9e08a3f694eb2e
      https://github.com/dovecot/core/commit/0eee7483da4cf7608d41f23a1f9e08a3f694eb2e
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-11-01 (Thu, 01 Nov 2018)

  Changed paths:
    M src/lib-smtp/smtp-client-private.h
    M src/lib-smtp/smtp-server-private.h

  Log Message:
  -----------
  lib-smtp: Consistently use signed integer for reference counters.


  Commit: 4283d14562c4ac22930ff34638ed22fbacfa82ef
      https://github.com/dovecot/core/commit/4283d14562c4ac22930ff34638ed22fbacfa82ef
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-11-01 (Thu, 01 Nov 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-command.c
    M src/lib-smtp/smtp-server-private.h

  Log Message:
  -----------
  lib-smtp: server: command: Prevent reference counting from within destroy hook.


  Commit: 24a22bd8daa4d5666f50b686adc9db51c58cb643
      https://github.com/dovecot/core/commit/24a22bd8daa4d5666f50b686adc9db51c58cb643
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-11-01 (Thu, 01 Nov 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-command.c
    M src/lib-smtp/smtp-server-private.h

  Log Message:
  -----------
  lib-smtp: server: command: Hold a reference to the command while calling a non-destroy hook.

Prevents memory problems when the hook inadvertently gets the command destroyed.


  Commit: 1d99b045a689306a035ab9a29ed47c96e9ad2e2b
      https://github.com/dovecot/core/commit/1d99b045a689306a035ab9a29ed47c96e9ad2e2b
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-11-01 (Thu, 01 Nov 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-command.c

  Log Message:
  -----------
  lib-smtp: server: command: Move core of smtp_server_command_submit_reply() into a separate function.

Makes the next changes easier.


  Commit: a882b189ad6b5fc8749cfa802e260b7c612de165
      https://github.com/dovecot/core/commit/a882b189ad6b5fc8749cfa802e260b7c612de165
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-11-01 (Thu, 01 Nov 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-command.c

  Log Message:
  -----------
  lib-smtp: server: command: Hold connection reference while calling replied hook.


  Commit: eeca44f5b71b2a5649a3f8805478de3a1b1c08f2
      https://github.com/dovecot/core/commit/eeca44f5b71b2a5649a3f8805478de3a1b1c08f2
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-11-01 (Thu, 01 Nov 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-command.c
    M src/lib-smtp/smtp-server-connection.c
    M src/lib-smtp/smtp-server-private.h

  Log Message:
  -----------
  lib-smtp: server: Make sure command object is not used after it is destroyed in hook.


  Commit: 144b6381fc640d37e84aa60630b707ddbba00790
      https://github.com/dovecot/core/commit/144b6381fc640d37e84aa60630b707ddbba00790
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-11-01 (Thu, 01 Nov 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-private.h
    M src/lib-smtp/smtp-server-recipient.c

  Log Message:
  -----------
  lib-smtp: server: recipient: Add reference counting.

Unlike the server command, this is not strictly necessary for the recipient
object, but we add this anyway to prevent future problems when the recipient
implementation becomes more complex.


  Commit: 529eb8a5f118d54250055000afb237c6bd2afd75
      https://github.com/dovecot/core/commit/529eb8a5f118d54250055000afb237c6bd2afd75
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-11-01 (Thu, 01 Nov 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-private.h
    M src/lib-smtp/smtp-server-recipient.c

  Log Message:
  -----------
  lib-smtp: server: recipient: Prevent reference counting from within destroy hook.


  Commit: 7197689fd947bb731b8027ce8cd9d5c981870ee3
      https://github.com/dovecot/core/commit/7197689fd947bb731b8027ce8cd9d5c981870ee3
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-11-01 (Thu, 01 Nov 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-rcpt.c
    M src/lib-smtp/smtp-server-private.h
    M src/lib-smtp/smtp-server-recipient.c

  Log Message:
  -----------
  lib-smtp: server: recipient: Hold a reference to the recipient while calling a non-destroy hook.

Prevents memory problems when the hook inadvertently gets the recipient
destroyed. Unlike the server command, this is not strictly necessary for the
recipient object, but we add this anyway to prevent future problems when the
recipient implementation becomes more complex (e.g. with additional hooks).


Compare: https://github.com/dovecot/core/compare/f996eb545cc3...7197689fd947
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.