[dovecot/core] aea7fd: lib-smtp: server: Provide full proxy data to the c...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: aea7fd5073518a493f54b51f8f43fcdfeef1bdf5
      https://github.com/dovecot/core/commit/aea7fd5073518a493f54b51f8f43fcdfeef1bdf5
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-05-27 (Sun, 27 May 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-connection.c

  Log Message:
  -----------
  lib-smtp: server: Provide full proxy data to the conn_proxy_data_updated() callback.

Before, it would only provide the fields that were updated, meaning that some
fields would remain unset, which caused problems for LMTP when more than one
XCLIENT command was sent or the ADDR field was not specified.


  Commit: 3912d6be16b765ac6972583114faf6ddb223e8d0
      https://github.com/dovecot/core/commit/3912d6be16b765ac6972583114faf6ddb223e8d0
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-05-27 (Sun, 27 May 2018)

  Changed paths:
    M src/lib-smtp/smtp-client-connection.c
    M src/lib-smtp/smtp-client-connection.h

  Log Message:
  -----------
  lib-smtp: client: Do not start authentication before initial XCLIENT gets reply.


  Commit: 84ed07bd39a9a7ec34fdfa8fb45513cf483e5979
      https://github.com/dovecot/core/commit/84ed07bd39a9a7ec34fdfa8fb45513cf483e5979
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-05-27 (Sun, 27 May 2018)

  Changed paths:
    M src/lib-smtp/smtp-client-connection.c
    M src/lib-smtp/smtp-client-private.h

  Log Message:
  -----------
  lib-smtp: client: Avoid sending an XCLIENT command longer than 512 bytes.

Send several separate XCLIENT commands instead. This way, it complies with the
base SMTP line length limit and with Postfix' original specification for the
XCLIENT command.

With the XCLIENT fields that Dovecot currently uses, this is very unlikely to
happen. Still, this needs to be fixed to make things reliable.


Compare: https://github.com/dovecot/core/compare/45b709d5f82d...84ed07bd39a9
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.