[dovecot/core] f3e3f1: lib-fs: fs_file_deinit(NULL) should be a no-op

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: f3e3f1f86a8a6c1d02b5e87907110747978c62fc
      https://github.com/dovecot/core/commit/f3e3f1f86a8a6c1d02b5e87907110747978c62fc
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-05-26 (Sat, 26 May 2018)

  Changed paths:
    M src/lib-fs/fs-api.c

  Log Message:
  -----------
  lib-fs: fs_file_deinit(NULL) should be a no-op


  Commit: 7c37bf6d4eef5d4473594015ff389657886c13e5
      https://github.com/dovecot/core/commit/7c37bf6d4eef5d4473594015ff389657886c13e5
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-05-26 (Sat, 26 May 2018)

  Changed paths:
    M src/doveadm/doveadm-fs.c
    M src/lib-fs/fs-metawrap.c
    M src/lib-fs/fs-sis-queue.c
    M src/plugins/fs-compress/fs-compress.c
    M src/plugins/mail-crypt/fs-crypt-common.c

  Log Message:
  -----------
  global: start relying on fs_file_deinit(NULL) being a no-op

Cleanup performed with the following semantic patch:

	@@
	expression E;
	@@

	- if (E != NULL) {
	- 	fs_file_deinit(&E);
	- }
	+ fs_file_deinit(&E);


  Commit: b2de303857ceac443e1e972eac1a05efcdf482f0
      https://github.com/dovecot/core/commit/b2de303857ceac443e1e972eac1a05efcdf482f0
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-05-26 (Sat, 26 May 2018)

  Changed paths:
    M src/lib-fs/fs-api.c

  Log Message:
  -----------
  lib-fs: fs_file_close(NULL) should be a no-op


  Commit: d8c10024f2c34c7ba0707a7072f1c24d23908673
      https://github.com/dovecot/core/commit/d8c10024f2c34c7ba0707a7072f1c24d23908673
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-05-26 (Sat, 26 May 2018)

  Changed paths:
    M src/lib-fs/fs-metawrap.c
    M src/plugins/fs-compress/fs-compress.c
    M src/plugins/mail-crypt/fs-crypt-common.c

  Log Message:
  -----------
  global: start relying on fs_file_close(NULL) being a no-op

Cleanup performed with the following semantic patch:

	@@
	expression E;
	@@

	- if (E != NULL) {
	- 	fs_file_close(E);
	- }
	+ fs_file_close(E);


  Commit: cbf0354f940d7e49e51ddc1faec451295a51a715
      https://github.com/dovecot/core/commit/cbf0354f940d7e49e51ddc1faec451295a51a715
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-05-26 (Sat, 26 May 2018)

  Changed paths:
    M src/lib-fs/fs-api.c

  Log Message:
  -----------
  lib-fs: fs_unref(NULL) should be a no-op


  Commit: fc9a7d9a657f95be1e231c18e843f093c404cb83
      https://github.com/dovecot/core/commit/fc9a7d9a657f95be1e231c18e843f093c404cb83
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-05-26 (Sat, 26 May 2018)

  Changed paths:
    M src/lib-fs/fs-metawrap.c
    M src/lib-fs/fs-randomfail.c
    M src/lib-fs/fs-sis-queue.c
    M src/lib-fs/fs-sis.c
    M src/lib-storage/index/dbox-common/dbox-storage.c
    M src/plugins/fs-compress/fs-compress.c
    M src/plugins/mail-crypt/fs-crypt-common.c

  Log Message:
  -----------
  global: start relying on fs_deinit(NULL) and fs_unref(NULL) being no-ops

Cleanup performed with the following semantic patch:

	@@
	expression E;
	@@

	- if (E != NULL) {
	- 	fs_unref(&E);
	- }
	+ fs_unref(&E);

	@@
	expression E;
	@@

	- if (E != NULL) {
	- 	fs_deinit(&E);
	- }
	+ fs_deinit(&E);


  Commit: 0d5ef33b8a2bdf30d2cd443690ee65a70def99be
      https://github.com/dovecot/core/commit/0d5ef33b8a2bdf30d2cd443690ee65a70def99be
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-05-26 (Sat, 26 May 2018)

  Changed paths:
    M src/lib-fs/fs-api.c

  Log Message:
  -----------
  lib-fs: fs_iter_deinit(NULL) should be a no-op


  Commit: 0a4cf111cbfebf01ddd5363d306248a8fc100046
      https://github.com/dovecot/core/commit/0a4cf111cbfebf01ddd5363d306248a8fc100046
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-05-26 (Sat, 26 May 2018)

  Changed paths:
    M src/lib-dict-extra/dict-fs.c

  Log Message:
  -----------
  global: start relying on fs_iter_deinit(NULL) being a no-op


  Commit: 0e16bc79b1732778493b7f6e76241bf6bddb9453
      https://github.com/dovecot/core/commit/0e16bc79b1732778493b7f6e76241bf6bddb9453
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-05-26 (Sat, 26 May 2018)

  Changed paths:
    M src/lib-fs/fs-api.c

  Log Message:
  -----------
  lib-fs: fs_unlock(NULL) should be a no-op


Compare: https://github.com/dovecot/core/compare/c2357a9b5e4b...0e16bc79b173
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.