[dovecot/core] 793205: mdbox: Assume that empty uid maps found during syn...

Wed May 23 16:10:25 EEST 2018

  Branch: refs/heads/release-2.2.36
  Home:   https://github.com/dovecot/core
  Commit: 79320594086f9ccf4d5fc13889e067a9bc8ac42e
      https://github.com/dovecot/core/commit/79320594086f9ccf4d5fc13889e067a9bc8ac42e
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-05-04 (Fri, 04 May 2018)

  Changed paths:
    M src/lib-storage/index/dbox-multi/mdbox-sync.c

  Log Message:
  -----------
  mdbox: Assume that empty uid maps found during sync are harmless

Instead of failing the sync and causing index rebuild, just skip over
the empty uid maps.  Chances are that they these records came from
various plugins that create fake mails.

  Commit: 5b181b231b28ad9af8d63febf1e86aa38efb004b
      https://github.com/dovecot/core/commit/5b181b231b28ad9af8d63febf1e86aa38efb004b
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2018-05-11 (Fri, 11 May 2018)

  Changed paths:
    M src/lib-index/mail-index-map-hdr.c
    M src/lib-index/mail-index-map.c
    M src/lib-index/mail-transaction-log-file.c
    M src/lib/byteorder.h
    M src/lib/sha1.c
    M src/lib/test-byteorder.c

  Log Message:
  -----------
  global: Use #ifdef instead of #if with WORDS_BIGENDIAN

This is to not rely on undefined WORDS_BIGENDIAN being evaluated as 0.

  Commit: 1db4071ac5aed7d21af2f34886a28becf8339294
      https://github.com/dovecot/core/commit/1db4071ac5aed7d21af2f34886a28becf8339294
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2018-05-11 (Fri, 11 May 2018)

  Changed paths:
    M src/lib-index/mail-transaction-log-file.c
    M src/lib/byteorder.h
    M src/lib/sha1.c

  Log Message:
  -----------
  lib,lib-index: Use #ifdef with WORDS_BIGENDIAN

Some were missing from the last change.

  Commit: 0db6eb8dc1648a786ad4ec53e8baaa7d2e32a865
      https://github.com/dovecot/core/commit/0db6eb8dc1648a786ad4ec53e8baaa7d2e32a865
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2018-05-11 (Fri, 11 May 2018)

  Changed paths:
    M src/lib/net.c

  Log Message:
  -----------
  lib: Don't use NEEDS_LOCAL_CREDS undefined

  Commit: 506d5962ba249b0b313cfa324ede660b80fb5a78
      https://github.com/dovecot/core/commit/506d5962ba249b0b313cfa324ede660b80fb5a78
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2018-05-11 (Fri, 11 May 2018)

  Changed paths:
    M src/lib-storage/mail.c

  Log Message:
  -----------
  lib-storage: Replace DBOX_GUID_BIN_LEN with GUID_128_SIZE

DBOX_GUID_BIN_LEN define was removed in 0c909e, replace the use with
GUID_128_SIZE.

  Commit: 7d597ea89faa4dd7f73966c40069055769a5d396
      https://github.com/dovecot/core/commit/7d597ea89faa4dd7f73966c40069055769a5d396
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-11 (Fri, 11 May 2018)

  Changed paths:
    M src/lib-fs/fs-posix.c

  Log Message:
  -----------
  fs-posix: mkdir missing directory if it's changed by FS_METADATA_WRITE_FNAME

The temp file is created to the initial directory. If the directory is
changed by FS_METADATA_WRITE_FNAME, the new destination directory didn't
necessarily exist. If the link() or rename() fails with ENOENT, try to
mkdir the missing directories.

  Commit: 8e181a1c6083a86205c3e62cb4d82c4f5d11d703
      https://github.com/dovecot/core/commit/8e181a1c6083a86205c3e62cb4d82c4f5d11d703
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-11 (Fri, 11 May 2018)

  Changed paths:
    M src/plugins/fts/fts-storage.c

  Log Message:
  -----------
  fts: Make sure indexing virtual mailbox doesn't recurse and index mail multiple times

  Commit: b73cd07312e8d53387ddca7cb256147c68b4e25e
      https://github.com/dovecot/core/commit/b73cd07312e8d53387ddca7cb256147c68b4e25e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-11 (Fri, 11 May 2018)

  Changed paths:
    M src/plugins/fts/fts-storage.c

  Log Message:
  -----------
  fts: Indexing virtual mailbox didn't always index the last mails

  Commit: 6e467d14979bf6c8079f36b262199c0545167b58
      https://github.com/dovecot/core/commit/6e467d14979bf6c8079f36b262199c0545167b58
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-11 (Fri, 11 May 2018)

  Changed paths:
    M src/plugins/fts/fts-storage.c

  Log Message:
  -----------
  fts: When indexing virtual mailbox, index each real mailbox entirely

Index all the unindexed messages in them at once, instead of jumping between
real mailboxes and indexing them in small pieces.

  Commit: 7e5c16031a01573aff4a6ce50f4a3ab0f7d92671
      https://github.com/dovecot/core/commit/7e5c16031a01573aff4a6ce50f4a3ab0f7d92671
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/lib-fs/fs-posix.c

  Log Message:
  -----------
  fs-posix: Strip trailing "/" from filenames

This is mainly because "doveadm fs delete -R" adds it to indicate to the
fs-driver that the whole directory is wanted to be deleted. This change
fixes fs-posix to work with NFS, where otherwise unlink("symlink-to-dir/")
fails with ENOTDIR. Without NFS the same call succeeds.

  Commit: d1010a6a85a76b560a1e56ba59cbea2be812fd85
      https://github.com/dovecot/core/commit/d1010a6a85a76b560a1e56ba59cbea2be812fd85
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/lib-sql/sql-api.h

  Log Message:
  -----------
  lib-sql: Add comments about NULL values.

  Commit: c423e741d5cecb991225c00099e1b54447d6adf2
      https://github.com/dovecot/core/commit/c423e741d5cecb991225c00099e1b54447d6adf2
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/lib-dict/dict-sql.c

  Log Message:
  -----------
  dict-sql: dict doesn't support NULL values, so convert SQL NULLs to ""

  Commit: dcb836051512dc427fd5f7cec4f455d70b9571a0
      https://github.com/dovecot/core/commit/dcb836051512dc427fd5f7cec4f455d70b9571a0
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/lib-sql/driver-cassandra.c

  Log Message:
  -----------
  cassandra: Cleanup - Move code to query_error_want_fallback()

This allows extending it more easily.

  Commit: 7098608ecaf43a8259ee74b3328a7f3eb15b6162
      https://github.com/dovecot/core/commit/7098608ecaf43a8259ee74b3328a7f3eb15b6162
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/lib-sql/driver-cassandra.c

  Log Message:
  -----------
  cassandra: Use fallback_consistency on more types of errors

This could allow for example read_consistency=local-quorum with
read_fallback_consistency=quorum, so most of the time the reads are
from local datacenter, but in case it has problems you can switch to
other datacenters.

  Commit: fcb7d7470993558db90b6a6c0d3699d023e7a887
      https://github.com/dovecot/core/commit/fcb7d7470993558db90b6a6c0d3699d023e7a887
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/lib-sql/driver-cassandra.c

  Log Message:
  -----------
  cassandra: Fix consistency=quorum to work

Previously it could have been used by setting "consistency=", but this was
an accident.

  Commit: e6ebaf71416fd0cdc72509d0972fe30424eeb6f9
      https://github.com/dovecot/core/commit/e6ebaf71416fd0cdc72509d0972fe30424eeb6f9
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/lib/compat.h

  Log Message:
  -----------
  lib/compat.h: Undefine WORDS_BIGENDIAN when it's defined as 0

  Commit: a9e78999d2a86f1e9f014fa9ce2ec61a79b47ce1
      https://github.com/dovecot/core/commit/a9e78999d2a86f1e9f014fa9ce2ec61a79b47ce1
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/lib-master/master-login-auth.c

  Log Message:
  -----------
  lib-master: Add how long request took for "Internal auth failure" errors

  Commit: 4b14c61ad2e47deccd853ff9d9897682b41d9857
      https://github.com/dovecot/core/commit/4b14c61ad2e47deccd853ff9d9897682b41d9857
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/lib-master/master-auth.c

  Log Message:
  -----------
  lib-master: If connect() to backend UNIX socket is retried, log a warning

For example if imap-login process needs to retry before it successfully
connects to imap process's socket, a warning is logged. This warning is
important because it means that the imap-login process may have been
sleeping up to 0.5 seconds and causing all the other connections to hang
during it.

It would be better to make this retrying asynchronous, but before spending
time on doing that, lets see if this warning is ever even being logged.

  Commit: c3221c0f9f19afcba4a9322fc2733fbf48003236
      https://github.com/dovecot/core/commit/c3221c0f9f19afcba4a9322fc2733fbf48003236
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/lib-master/master-login.c
    M src/lib-master/master-login.h

  Log Message:
  -----------
  lib-master: Keep linked list of master_login_clients per connection

This allows improving logging on connection errors.

  Commit: 1697c0e7b917a12fe5c05c376b47b260b3d097f3
      https://github.com/dovecot/core/commit/1697c0e7b917a12fe5c05c376b47b260b3d097f3
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/lib-master/master-login.c
    M src/lib-master/master-login.h

  Log Message:
  -----------
  lib-master: Improve error logging when master_login_connection gets disconnected

  Commit: 6b733368c07ffdbc9f936c95d170c219e2792276
      https://github.com/dovecot/core/commit/6b733368c07ffdbc9f936c95d170c219e2792276
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/lib-master/master-login.c
    M src/lib-master/master-login.h

  Log Message:
  -----------
  lib-master: Improve error logging for post-login script failures

  Commit: 55584e64008336c36b0cbf6bc4b16957c356f9e8
      https://github.com/dovecot/core/commit/55584e64008336c36b0cbf6bc4b16957c356f9e8
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/lib-master/master-auth.c

  Log Message:
  -----------
  lib-master: Improve error logging for master_auth_connection failures

  Commit: 134df7900da52255e61e0e4d7288fa9e02e6f97a
      https://github.com/dovecot/core/commit/134df7900da52255e61e0e4d7288fa9e02e6f97a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/lib-master/master-login-auth.c

  Log Message:
  -----------
  lib-master: Use more exact timestamp in master_login_auth_request failures

  Commit: c2ff5a3d745dc106ca3032654caabc69ebed0499
      https://github.com/dovecot/core/commit/c2ff5a3d745dc106ca3032654caabc69ebed0499
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/lib-master/master-login-auth.c

  Log Message:
  -----------
  lib-master: Add request time also for internal failure error messages

  Commit: 78e847e733dacb4d8e350c3ffdd025c47e3c0a18
      https://github.com/dovecot/core/commit/78e847e733dacb4d8e350c3ffdd025c47e3c0a18
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/lib-master/master-login-auth.c

  Log Message:
  -----------
  lib-master: Add auth connect & handshake times to master_login_auth_request errors

  Commit: 6e078d85ab53f9c961ca343f4312f6578e7551a2
      https://github.com/dovecot/core/commit/6e078d85ab53f9c961ca343f4312f6578e7551a2
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/auth/auth-master-connection.c
    M src/auth/auth-master-connection.h
    M src/auth/auth-request-handler.c

  Log Message:
  -----------
  auth: Improve auth-master connections' error logging

Include connect and handshake times in the error message.

  Commit: 30f693b48dd980f9d79a63e3a75f84f0130a093a
      https://github.com/dovecot/core/commit/30f693b48dd980f9d79a63e3a75f84f0130a093a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-18 (Fri, 18 May 2018)

  Changed paths:
    M src/lib-master/master-login.c

  Log Message:
  -----------
  lib-master: postlogin: Don't unreference already closed login-connection

If the login-connection was already closed, this caused too many
unreferences.

Fixes:
Panic: file master-login.c: line 544 (master_login_conn_unref): assertion failed: (conn->clients == NULL)

  Commit: 048ef238f810d85bfa8da000778681d4a64c5d2f
      https://github.com/dovecot/core/commit/048ef238f810d85bfa8da000778681d4a64c5d2f
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-21 (Mon, 21 May 2018)

  Changed paths:
    M src/lib-fs/fs-posix.c

  Log Message:
  -----------
  fs-posix: Fix fs_iter_next() to return any kinds of files.

Only regular files and symlinks were returned. It should return everything
else as well (fifos, sockets, devices).

  Commit: 9e2d02a39d1d349619e60b8bffde8da85acd8d80
      https://github.com/dovecot/core/commit/9e2d02a39d1d349619e60b8bffde8da85acd8d80
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-21 (Mon, 21 May 2018)

  Changed paths:
    M src/lib-imap/imap-envelope.c

  Log Message:
  -----------
  lib-imap: imap_envelope_parse() - remove unnecessary data stack frame

imap_envelope_parse_args() isn't using data stack at all, so this
unnecessarily complicates the code. It also prevents using datastack-pool
as the pool parameter.

  Commit: ef263f7b0d9276a03257e5d11d9792b277f56d4b
      https://github.com/dovecot/core/commit/ef263f7b0d9276a03257e5d11d9792b277f56d4b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-23 (Wed, 23 May 2018)

  Changed paths:
    M doc/man/doveadm-mailbox.1.in

  Log Message:
  -----------
  man: doveadm-mailbox.1.in - Fix doveadm-search-query(7) section

  Commit: 1f10bfa6335f42a254d3a5652b053ad652f6cc14
      https://github.com/dovecot/core/commit/1f10bfa6335f42a254d3a5652b053ad652f6cc14
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-05-23 (Wed, 23 May 2018)

  Changed paths:
    M NEWS
    M configure.ac

  Log Message:
  -----------
  Released v2.2.36.

Compare: https://github.com/dovecot/core/compare/27366c1b4258...1f10bfa6335f
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.