[dovecot/core] 908920: doveadm: fix who/kick out of order response

GitHub noreply at github.com
Tue May 15 16:00:18 EEST 2018


  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 908920aeefdef7b50a3ec7b0099c16eed71d5ef2
      https://github.com/dovecot/core/commit/908920aeefdef7b50a3ec7b0099c16eed71d5ef2
  Author: Bjørnar Ness <bjornar.ness at gmail.com>
  Date:   2018-05-15 (Tue, 15 May 2018)

  Changed paths:
    M src/doveadm/doveadm-kick.c
    M src/doveadm/doveadm-who.c

  Log Message:
  -----------
  doveadm: fix who/kick out of order response

doveadm-who and kick did not properly flush protocol output
after doveadm_print(), this caused out-of-order response to
clients, example:

C: <tab><tab>who<crlf>
S: +<crlf>
S: username<tab>[...]<missing_crlf>

correct response should have been
S: <username><tab>[...]<crlf>
S: +<crlf>

fixed by adding doveadm_print_flush() calls.



      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the dovecot-cvs mailing list