[dovecot/pigeonhole] c851cc: lib-sieve: util: edit-mail: Fix assert panic occur...

Mon May 14 20:25:01 EEST 2018

  Branch: refs/heads/release-0.5.2
  Home:   https://github.com/dovecot/pigeonhole
  Commit: c851cce6a42c876b264ffb67ba5a96fa47f1ad17
      https://github.com/dovecot/pigeonhole/commit/c851cce6a42c876b264ffb67ba5a96fa47f1ad17
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-05-14 (Mon, 14 May 2018)

  Changed paths:
    M src/lib-sieve/util/edit-mail.c
    M src/lib-sieve/util/test-edit-mail.c

  Log Message:
  -----------
  lib-sieve: util: edit-mail: Fix assert panic occurring when streaming large headers.

The problem mainly arose because the stream buffer position was used to
determine how much was written, while the stream buffer position is potentially
decreased by i_stream_try_alloc().

Panic was:

Panic: file istream.c: line 197 (i_stream_read): assertion failed: ((size_t)ret+old_size == _stream->pos - _stream->skip)

  Commit: e3cc1b4e60679c0186d7db631c277fdcda82a35d
      https://github.com/dovecot/pigeonhole/commit/e3cc1b4e60679c0186d7db631c277fdcda82a35d
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-05-14 (Mon, 14 May 2018)

  Changed paths:
    M src/lib-sieve/util/test-edit-mail.c

  Log Message:
  -----------
  lib-sieve: util: test-edit-mail: Fix unused variable warning reported by GCC.

  Commit: ec72f4dcbf227d45bd09e5c7bd32a3b0668a6993
      https://github.com/dovecot/pigeonhole/commit/ec72f4dcbf227d45bd09e5c7bd32a3b0668a6993
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-05-14 (Mon, 14 May 2018)

  Changed paths:
    M src/lib-sieve/util/test-edit-mail.c

  Log Message:
  -----------
  lib-sieve: util: test-edit-mail: Determine test directory at the beginning of all tests.

It is the initial working directory and that may change during testing, so it is
not a good idea to determine this per test.

  Commit: ddf3c788c042397b3bfcc1646e23fd4d381941b5
      https://github.com/dovecot/pigeonhole/commit/ddf3c788c042397b3bfcc1646e23fd4d381941b5
  Author: Phil Carmody <phil at dovecot.fi>
  Date:   2018-05-14 (Mon, 14 May 2018)

  Changed paths:
    M src/lib-sieve/sieve-message.c
    M src/lib-sieve/storage/file/sieve-file-script.c
    M src/lib-sieve/storage/file/sieve-file-storage.c

  Log Message:
  -----------
  global: expand default temporary pool sizes

The tests blow through these limits all of the time, which
makes the logs very noisy. These three cases are about 4/5ths
of the test logs. Presumably they're the ones that are also
most often needing expansion in real world use too.

Signed-off-by: Phil Carmody <phil at dovecot.fi>

  Commit: b3d9515ef35b7208b2f77dd82e0dc92ffaf51596
      https://github.com/dovecot/pigeonhole/commit/b3d9515ef35b7208b2f77dd82e0dc92ffaf51596
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-05-14 (Mon, 14 May 2018)

  Changed paths:
    M src/lib-sieve/plugins/notify/cmd-notify.c
    M src/lib-sieve/plugins/vacation/cmd-vacation.c

  Log Message:
  -----------
  lib-sieve: Always check the result returned from smtp_address_init_from_msg().

  Commit: 63248cc6e7c6c1fdeb9d29c6ab7eb82df1c0c431
      https://github.com/dovecot/pigeonhole/commit/63248cc6e7c6c1fdeb9d29c6ab7eb82df1c0c431
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-05-14 (Mon, 14 May 2018)

  Changed paths:
    M src/lib-sieve/sieve-script.c
    M src/lib-sieve/sieve-script.h

  Log Message:
  -----------
  lib-sieve: Allow sieve_script_binary_save() error_r parameter to be NULL.

  Commit: 8aee0f613e42dc66387876da49c61b6317c1c98b
      https://github.com/dovecot/pigeonhole/commit/8aee0f613e42dc66387876da49c61b6317c1c98b
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-05-14 (Mon, 14 May 2018)

  Changed paths:
    M configure.ac
    M src/lib-sieve/Makefile.am
    M src/lib-sieve/sieve-script-private.h
    M src/lib-sieve/sieve-script.h
    M src/lib-sieve/sieve-storage-private.h
    M src/lib-sieve/storage/Makefile.am
    A src/lib-sieve/storage/data/Makefile.am
    A src/lib-sieve/storage/data/sieve-data-script.c
    A src/lib-sieve/storage/data/sieve-data-storage.c
    A src/lib-sieve/storage/data/sieve-data-storage.h

  Log Message:
  -----------
  lib-sieve: Add support for compiling Sieve scripts from an input stream.

  Commit: bc6764b12c9621bfc8392876462ad00491c4ae2b
      https://github.com/dovecot/pigeonhole/commit/bc6764b12c9621bfc8392876462ad00491c4ae2b
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-05-14 (Mon, 14 May 2018)

  Changed paths:
    M src/lib-sieve/ext-reject.c
    M src/lib-sieve/plugins/vacation/cmd-vacation.c
    M src/lib-sieve/sieve-types.h

  Log Message:
  -----------
  lib-sieve: Add SIEVE_EXECUTE_FLAG_SKIP_RESPONSES execute flag.

This causes the reject and vacation response actions to be skipped without
error.

  Commit: db3be195ae4abd39204a9afe7577878b31ba266e
      https://github.com/dovecot/pigeonhole/commit/db3be195ae4abd39204a9afe7577878b31ba266e
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-05-14 (Mon, 14 May 2018)

  Changed paths:
    M src/plugins/imapsieve/imap-sieve.c

  Log Message:
  -----------
  plugins: imapsieve: Make sure responses are never sent.

Use the new SIEVE_EXECUTE_FLAG_SKIP_RESPONSES flag to prevent any unforseen
mishaps.

  Commit: 664a73f05349544e0aa11726f98f887ccc25056c
      https://github.com/dovecot/pigeonhole/commit/664a73f05349544e0aa11726f98f887ccc25056c
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-05-14 (Mon, 14 May 2018)

  Changed paths:
    M INSTALL
    M TODO
    M configure.ac
    A doc/plugins/imap_filter_sieve.txt
    A doc/rfc/draft-bosch-imap-filter-sieve-00.txt
    M src/plugins/Makefile.am
    A src/plugins/imap-filter-sieve/Makefile.am
    A src/plugins/imap-filter-sieve/cmd-filter-sieve.c
    A src/plugins/imap-filter-sieve/cmd-filter.c
    A src/plugins/imap-filter-sieve/imap-filter-sieve-plugin.c
    A src/plugins/imap-filter-sieve/imap-filter-sieve-plugin.h
    A src/plugins/imap-filter-sieve/imap-filter-sieve.c
    A src/plugins/imap-filter-sieve/imap-filter-sieve.h
    A src/plugins/imap-filter-sieve/imap-filter.c
    A src/plugins/imap-filter-sieve/imap-filter.h

  Log Message:
  -----------
  plugins: Implement the vendor-defined IMAP FILTER=SIEVE capability.

It adds the ability to manually invoke Sieve filtering in IMAP.

  Commit: 4324fe8023b9422f52274c4c96d0ce5afab71e4b
      https://github.com/dovecot/pigeonhole/commit/4324fe8023b9422f52274c4c96d0ce5afab71e4b
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-05-14 (Mon, 14 May 2018)

  Changed paths:
    M src/lib-sieve/sieve-address.c

  Log Message:
  -----------
  lib-sieve: Try to skip individual invalid addresses while iterating an address list.

Before, the whole address list (header value) was returned as an invalid
address, ignoring any valid addresses it may still have contained.

  Commit: 35f4b1307fe35488d07336b3410aa0e14af8190b
      https://github.com/dovecot/pigeonhole/commit/35f4b1307fe35488d07336b3410aa0e14af8190b
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-05-14 (Mon, 14 May 2018)

  Changed paths:
    M src/lib-sieve/sieve-address.c

  Log Message:
  -----------
  lib-sieve: Check iterated addresses in address list for validity as an SMTP address.

  Commit: 8565e71ffe7554b8d82df1d1d7c2fb59a9ca2e13
      https://github.com/dovecot/pigeonhole/commit/8565e71ffe7554b8d82df1d1d7c2fb59a9ca2e13
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-05-14 (Mon, 14 May 2018)

  Changed paths:
    M src/lib-sieve/sieve-address.c

  Log Message:
  -----------
  lib-sieve: Add more trace debugging output for address list iteration.

  Commit: 4ac4cfa85c6c7323475efa2aca277aa2482cdf71
      https://github.com/dovecot/pigeonhole/commit/4ac4cfa85c6c7323475efa2aca277aa2482cdf71
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-05-14 (Mon, 14 May 2018)

  Changed paths:
    M tests/test-address.svtest

  Log Message:
  -----------
  tests: address test: Add tests for invalid addresses with UTF-8 in the localpart.

  Commit: 08dcc5609d05ebc971996301c9718004b74db97c
      https://github.com/dovecot/pigeonhole/commit/08dcc5609d05ebc971996301c9718004b74db97c
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-05-14 (Mon, 14 May 2018)

  Changed paths:
    M NEWS

  Log Message:
  -----------
  Added v0.5.1 to NEWS.

Compare: https://github.com/dovecot/pigeonhole/compare/c851cce6a42c^...08dcc5609d05
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.