[dovecot/core] 02f562: imapc: Move expunging from index to imapc_mailbox_...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 02f5623e947f26187737b8681d6ea18db441fd07
      https://github.com/dovecot/core/commit/02f5623e947f26187737b8681d6ea18db441fd07
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-06-18 (Mon, 18 Jun 2018)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-mailbox.c

  Log Message:
  -----------
  imapc: Move expunging from index to imapc_mailbox_index_expunge()


  Commit: 264107ab3aa4d20d2d34e78be4153c8462f4fd12
      https://github.com/dovecot/core/commit/264107ab3aa4d20d2d34e78be4153c8462f4fd12
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-06-18 (Mon, 18 Jun 2018)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-mailbox.c

  Log Message:
  -----------
  imapc: Fix assert-crash when reconnecting expunges newly added messages

The initial FETCH 1:* during reconnection may notice some messages that are
missing and tries to expunge them. But those messages could still be in
delayed_sync_trans, and currently lib-index doesn't support expunging anything
but the latest mail from a transaction.

Fixes:
Panic: file mail-index-transaction-update.c: line 337 (mail_index_expunge_last_append): assertion failed: (seq == t->last_new_seq)


  Commit: 800ed1eeabfb6477872485df7ad21a90fd9af70a
      https://github.com/dovecot/core/commit/800ed1eeabfb6477872485df7ad21a90fd9af70a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-06-18 (Mon, 18 Jun 2018)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-storage.c

  Log Message:
  -----------
  imapc: Fix assert-crash when reconnecting during initial FETCH finds expunges

The initial FETCH is automatically retried on failure, but the FETCH state
wasn't reset during the reconnection.

Fixes:
Panic: file imapc-sync.c: line 328 (imapc_initial_sync_check): assertion failed: (mail_index_is_expunged(view, lseq) || seq_range_exists(&ctx->mbox->delayed_expunged_uids, luid))


  Commit: 4273c57b658e8e6ead88ae545765b51c90fbe24e
      https://github.com/dovecot/core/commit/4273c57b658e8e6ead88ae545765b51c90fbe24e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-06-18 (Mon, 18 Jun 2018)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-storage.c
    M src/lib-storage/index/imapc/imapc-sync.c

  Log Message:
  -----------
  imapc: Fix potential assert-crash when reconnecting during syncing

Fixes:
Panic: file imapc-sync.c: line 328 (imapc_initial_sync_check): assertion failed: (mail_index_is_expunged(view, lseq) || seq_range_exists(&ctx->mbox->delayed_expunged_uids, luid))


  Commit: 15ff00ae38382118c8a2d35e8ca6509af85a8987
      https://github.com/dovecot/core/commit/15ff00ae38382118c8a2d35e8ca6509af85a8987
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-06-18 (Mon, 18 Jun 2018)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-sync.c

  Log Message:
  -----------
  imapc: Fix assert-crash if syncing adds delayed expunges, but fails afterwards

Fixes:
Panic: file imapc-sync.c: line 328 (imapc_initial_sync_check): assertion failed: (mail_index_is_expunged(view, lseq) || seq_range_exists(&ctx->mbox->delayed_expunged_uids, luid))


Compare: https://github.com/dovecot/core/compare/bddb144f0209...15ff00ae3838
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.