[dovecot/core] 42e321: doveadm: Fix compiler warning

GitHub noreply at github.com
Mon Jun 18 21:22:57 EEST 2018


  Branch: refs/heads/release-2.3.2
  Home:   https://github.com/dovecot/core
  Commit: 42e32102a6dac0a6fdca7845fc084f7aadae36a2
      https://github.com/dovecot/core/commit/42e32102a6dac0a6fdca7845fc084f7aadae36a2
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-06-11 (Mon, 11 Jun 2018)

  Changed paths:
    M src/doveadm/client-connection-tcp.c

  Log Message:
  -----------
  doveadm: Fix compiler warning


  Commit: 107b32376960cec77e801612b0f51bfc0fb23181
      https://github.com/dovecot/core/commit/107b32376960cec77e801612b0f51bfc0fb23181
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-06-11 (Mon, 11 Jun 2018)

  Changed paths:
    M src/plugins/fts/fts-storage.c

  Log Message:
  -----------
  fts: Make sure indexing virtual mailbox doesn't recurse and index mail multiple times


  Commit: e209e104a93ef14409f27e7a65c078c36351986b
      https://github.com/dovecot/core/commit/e209e104a93ef14409f27e7a65c078c36351986b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-06-11 (Mon, 11 Jun 2018)

  Changed paths:
    M src/plugins/fts/fts-storage.c

  Log Message:
  -----------
  fts: Indexing virtual mailbox didn't always index the last mails


  Commit: 5af358949ebb8c2f8f5a75668d6c53d9a127ff1e
      https://github.com/dovecot/core/commit/5af358949ebb8c2f8f5a75668d6c53d9a127ff1e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-06-11 (Mon, 11 Jun 2018)

  Changed paths:
    M src/plugins/fts/fts-storage.c

  Log Message:
  -----------
  fts: When indexing virtual mailbox, index each real mailbox entirely

Index all the unindexed messages in them at once, instead of jumping between
real mailboxes and indexing them in small pieces.


  Commit: b87c677799a849c3af4e0f6a4bc85432a3f3557f
      https://github.com/dovecot/core/commit/b87c677799a849c3af4e0f6a4bc85432a3f3557f
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-06-12 (Tue, 12 Jun 2018)

  Changed paths:
    M src/lda/main.c

  Log Message:
  -----------
  lda: Add -r parameter to usage help message.


  Commit: b9969c4d2e0424e2f0f98b3492fadb9fed32fa0f
      https://github.com/dovecot/core/commit/b9969c4d2e0424e2f0f98b3492fadb9fed32fa0f
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-06-12 (Tue, 12 Jun 2018)

  Changed paths:
    M src/lda/main.c

  Log Message:
  -----------
  lda: Fix error message for invalid -r parameter to mention `-r' rather than `-a'.


  Commit: b06a22f1d91202ba3f8295caf528cab0e2a61c0a
      https://github.com/dovecot/core/commit/b06a22f1d91202ba3f8295caf528cab0e2a61c0a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-06-12 (Tue, 12 Jun 2018)

  Changed paths:
    M src/lib-fs/fs-posix.c
    M src/lib-program-client/program-client.c

  Log Message:
  -----------
  global: Fix str_begins() usage

I messed up their cherry-pick merging.


  Commit: 18fbc4a90148d13a16f98682989d1a19d9d3ad9d
      https://github.com/dovecot/core/commit/18fbc4a90148d13a16f98682989d1a19d9d3ad9d
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-06-13 (Wed, 13 Jun 2018)

  Changed paths:
    M src/lib-ssl-iostream/iostream-openssl-context.c

  Log Message:
  -----------
  lib-ssl-iostream: Fix boolean misuse in SSL_CTX_set_ecdh_auto usage

f8aaa6e63a56085f61f128838ad7a3aa080d9d5b introduced warnings on gcc


  Commit: d1972d1d625d3487bb1d0b928490515a154d8cd7
      https://github.com/dovecot/core/commit/d1972d1d625d3487bb1d0b928490515a154d8cd7
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-06-13 (Wed, 13 Jun 2018)

  Changed paths:
    M src/lib-lua/dlua-script.c

  Log Message:
  -----------
  lib-lua: Remove script from linked list on destroy

Otherwise it might cause a crash


  Commit: bf307d4c28638ef77a73ad8ebe35a3bbed8bd9e9
      https://github.com/dovecot/core/commit/bf307d4c28638ef77a73ad8ebe35a3bbed8bd9e9
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-06-13 (Wed, 13 Jun 2018)

  Changed paths:
    M src/imap/imap-client.c

  Log Message:
  -----------
  imap: Finish client ostream at disconnect

With IMAP COMPRESS this sends the EOF marker, indicating cleanly closed
connection.


  Commit: 30f854e6eab6c0e7e6b70f19432ea268c2eb9400
      https://github.com/dovecot/core/commit/30f854e6eab6c0e7e6b70f19432ea268c2eb9400
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-06-13 (Wed, 13 Jun 2018)

  Changed paths:
    M src/lib-http/http-client-request.c

  Log Message:
  -----------
  lib-http: http_client_request_abort(NULL) should be a no-op


  Commit: de3f7051bd66e1bf9f2971f422903ba7a53a0f34
      https://github.com/dovecot/core/commit/de3f7051bd66e1bf9f2971f422903ba7a53a0f34
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-06-13 (Wed, 13 Jun 2018)

  Changed paths:
    M src/auth/auth-policy.c
    M src/lib-http/http-client-connection.c
    M src/lib-oauth2/oauth2.c
    M src/plugins/fts-solr/solr-connection.c
    M src/plugins/fts/fts-parser-tika.c

  Log Message:
  -----------
  global: start relying on http_client_request_abort(NULL) being a no-op

Cleanup performed with the following semantic patch:

	@@
	expression E;
	@@

	- if (E != NULL) {
	- 	http_client_request_abort(&E);
	- }
	+ http_client_request_abort(&E);


  Commit: 14829716f17c9473b00e7736742e4c7e6c7c70e5
      https://github.com/dovecot/core/commit/14829716f17c9473b00e7736742e4c7e6c7c70e5
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-06-13 (Wed, 13 Jun 2018)

  Changed paths:
    M src/lib-fs/fs-api.c

  Log Message:
  -----------
  lib-fs: fs_file_deinit(NULL) should be a no-op


  Commit: f7fac54b52d5972bd8fbc5be6090c7e2385c512d
      https://github.com/dovecot/core/commit/f7fac54b52d5972bd8fbc5be6090c7e2385c512d
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-06-13 (Wed, 13 Jun 2018)

  Changed paths:
    M src/doveadm/doveadm-fs.c
    M src/lib-fs/fs-metawrap.c
    M src/lib-fs/fs-sis-queue.c
    M src/plugins/fs-compress/fs-compress.c
    M src/plugins/mail-crypt/fs-crypt-common.c

  Log Message:
  -----------
  global: start relying on fs_file_deinit(NULL) being a no-op

Cleanup performed with the following semantic patch:

	@@
	expression E;
	@@

	- if (E != NULL) {
	- 	fs_file_deinit(&E);
	- }
	+ fs_file_deinit(&E);


  Commit: 13afec5792156c37e582c14d389e6059822abdef
      https://github.com/dovecot/core/commit/13afec5792156c37e582c14d389e6059822abdef
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-06-13 (Wed, 13 Jun 2018)

  Changed paths:
    M src/lib-fs/fs-api.c

  Log Message:
  -----------
  lib-fs: fs_file_close(NULL) should be a no-op


  Commit: 1714aa0a0558a42dfec317bbaadcc1537db1d713
      https://github.com/dovecot/core/commit/1714aa0a0558a42dfec317bbaadcc1537db1d713
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-06-13 (Wed, 13 Jun 2018)

  Changed paths:
    M src/lib-fs/fs-metawrap.c
    M src/plugins/fs-compress/fs-compress.c
    M src/plugins/mail-crypt/fs-crypt-common.c

  Log Message:
  -----------
  global: start relying on fs_file_close(NULL) being a no-op

Cleanup performed with the following semantic patch:

	@@
	expression E;
	@@

	- if (E != NULL) {
	- 	fs_file_close(E);
	- }
	+ fs_file_close(E);


  Commit: 3eb5fc7ad06c0e1a8758796aed8aa374ff42e3fe
      https://github.com/dovecot/core/commit/3eb5fc7ad06c0e1a8758796aed8aa374ff42e3fe
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-06-13 (Wed, 13 Jun 2018)

  Changed paths:
    M src/lib-fs/fs-api.c

  Log Message:
  -----------
  lib-fs: fs_unref(NULL) should be a no-op


  Commit: 4cabfcd0623d41aa3597f8e736a81985c934a3db
      https://github.com/dovecot/core/commit/4cabfcd0623d41aa3597f8e736a81985c934a3db
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-06-13 (Wed, 13 Jun 2018)

  Changed paths:
    M src/lib-fs/fs-metawrap.c
    M src/lib-fs/fs-randomfail.c
    M src/lib-fs/fs-sis-queue.c
    M src/lib-fs/fs-sis.c
    M src/lib-storage/index/dbox-common/dbox-storage.c
    M src/plugins/fs-compress/fs-compress.c
    M src/plugins/mail-crypt/fs-crypt-common.c

  Log Message:
  -----------
  global: start relying on fs_deinit(NULL) and fs_unref(NULL) being no-ops

Cleanup performed with the following semantic patch:

	@@
	expression E;
	@@

	- if (E != NULL) {
	- 	fs_unref(&E);
	- }
	+ fs_unref(&E);

	@@
	expression E;
	@@

	- if (E != NULL) {
	- 	fs_deinit(&E);
	- }
	+ fs_deinit(&E);


  Commit: 8f7561879605a1797200cf8100702b54998c9fb0
      https://github.com/dovecot/core/commit/8f7561879605a1797200cf8100702b54998c9fb0
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-06-13 (Wed, 13 Jun 2018)

  Changed paths:
    M src/lib-fs/fs-api.c

  Log Message:
  -----------
  lib-fs: fs_iter_deinit(NULL) should be a no-op


  Commit: 919db520fbc39ff403e235e9d4cc9ea5e29497cf
      https://github.com/dovecot/core/commit/919db520fbc39ff403e235e9d4cc9ea5e29497cf
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-06-13 (Wed, 13 Jun 2018)

  Changed paths:
    M src/lib-dict-extra/dict-fs.c

  Log Message:
  -----------
  global: start relying on fs_iter_deinit(NULL) being a no-op


  Commit: 4db613a47522e9e3bd9b2e8fe3712c44000c1aeb
      https://github.com/dovecot/core/commit/4db613a47522e9e3bd9b2e8fe3712c44000c1aeb
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-06-13 (Wed, 13 Jun 2018)

  Changed paths:
    M src/lib-fs/fs-api.c

  Log Message:
  -----------
  lib-fs: fs_unlock(NULL) should be a no-op


  Commit: 28983eb41c81f8e63d95ae679983491b8ecfe673
      https://github.com/dovecot/core/commit/28983eb41c81f8e63d95ae679983491b8ecfe673
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-06-13 (Wed, 13 Jun 2018)

  Changed paths:
    M src/lib/iostream-pump.c
    M src/lib/iostream-pump.h

  Log Message:
  -----------
  lib: iostream-pump: Make iostream_pump_unref() implementation match other similar code.

This also means that iostream_pump_unref(NULL) is now a no-op.


  Commit: 3f310ab604b22eef854a24f5513e9e5fa897fc46
      https://github.com/dovecot/core/commit/3f310ab604b22eef854a24f5513e9e5fa897fc46
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-06-13 (Wed, 13 Jun 2018)

  Changed paths:
    M src/lib-imap/imap-match.c

  Log Message:
  -----------
  lib-imap: imap_match_deinit(NULL) should be a no-op


  Commit: 6f364a136e296d0c3950fa977b6dc61a18a42f3a
      https://github.com/dovecot/core/commit/6f364a136e296d0c3950fa977b6dc61a18a42f3a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-06-13 (Wed, 13 Jun 2018)

  Changed paths:
    M src/lib-fs/fs-posix.c

  Log Message:
  -----------
  fs-posix: mkdir missing directory if it's changed by FS_METADATA_WRITE_FNAME

The temp file is created to the initial directory. If the directory is
changed by FS_METADATA_WRITE_FNAME, the new destination directory didn't
necessarily exist. If the link() or rename() fails with ENOENT, try to
mkdir the missing directories.


  Commit: ad5447e35bc9028f595fe067599bc632065e2601
      https://github.com/dovecot/core/commit/ad5447e35bc9028f595fe067599bc632065e2601
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-06-18 (Mon, 18 Jun 2018)

  Changed paths:
    M src/lib/failures.c

  Log Message:
  -----------
  lib: Revert earlier "log write is blocking" handling change

1) It was buggy, because it set O_NONBLOCK rather than removing it.

2) fd flags are shared across all the processes using the fd. We can't
reliably implement the process title update, because some processes are
blocking on the log write() before they change the process title.

Reverts 861d40b9aebabccae7d48e49a18cbc631ab1fefe


  Commit: daaf815130366bdea71bad9f7902bb4b89ac4380
      https://github.com/dovecot/core/commit/daaf815130366bdea71bad9f7902bb4b89ac4380
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-06-18 (Mon, 18 Jun 2018)

  Changed paths:
    M src/lib/failures.c

  Log Message:
  -----------
  lib: If log write returns EAGAIN, use poll() instead of ioloop for waiting

As explained in 861d40b9aebabccae7d48e49a18cbc631ab1fefe commit message,
ioloop can call various callbacks and it can also recurse back to error
logging. Using poll() directly is safer.


  Commit: 8ffa9f26955f63c5f1152d579c5613a8c95760b5
      https://github.com/dovecot/core/commit/8ffa9f26955f63c5f1152d579c5613a8c95760b5
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-06-18 (Mon, 18 Jun 2018)

  Changed paths:
    M src/lib/failures.c

  Log Message:
  -----------
  lib: When log writing keeps returning EAGAIN, change process title only once

Otherwise each call will use up data stack memory.


  Commit: 6bae544158c163235a5a87055279ec4809499c5d
      https://github.com/dovecot/core/commit/6bae544158c163235a5a87055279ec4809499c5d
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-06-18 (Mon, 18 Jun 2018)

  Changed paths:
    M NEWS
    M configure.ac

  Log Message:
  -----------
  Released v2.3.2.rc1


Compare: https://github.com/dovecot/core/compare/42e32102a6da^...6bae544158c1
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the dovecot-cvs mailing list