[dovecot/core] 75ae0b: imapc: Don't trust mail stream to have correct CRL...

GitHub noreply at github.com
Mon Jun 18 20:30:06 EEST 2018


  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 75ae0b779853b7654430d119720548b132399f3d
      https://github.com/dovecot/core/commit/75ae0b779853b7654430d119720548b132399f3d
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-06-18 (Mon, 18 Jun 2018)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-mail-fetch.c

  Log Message:
  -----------
  imapc: Don't trust mail stream to have correct CRLFs

It's not that expensive to just recalculate them. If they're not correct in
the stream, it can result in e.g. truncated emails due to wrong virtual_size
being used in body_size calculation. The wrong CRLFs can especially happen
if plugins modify the stream in istream_opened() hook.


  Commit: cf32e732dec8be08c1cf0a0d05f56f74300a7d90
      https://github.com/dovecot/core/commit/cf32e732dec8be08c1cf0a0d05f56f74300a7d90
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-06-18 (Mon, 18 Jun 2018)

  Changed paths:
    M src/lib-imap-client/imapc-client.c

  Log Message:
  -----------
  lib-imap-client: Remove assert from imapc_client_mailbox_reconnect

It's possible for the assert to trigger if there are multiple reconnections.
imapc_connection_can_reconnect() checks a bit later whether the reconnection
can still be done.


Compare: https://github.com/dovecot/core/compare/d1d8792e51c1...cf32e732dec8
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the dovecot-cvs mailing list