[dovecot/core] 231865: lib-storage: Fix memory leak when mail_storage_ser...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 231865af423b4fa4da209a0721de57840c9b91de
      https://github.com/dovecot/core/commit/231865af423b4fa4da209a0721de57840c9b91de
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-06-12 (Tue, 12 Jun 2018)

  Changed paths:
    M src/lib-storage/mail-storage-service.c

  Log Message:
  -----------
  lib-storage: Fix memory leak when mail_storage_service_next() is called multiple times

dsync uses it twice for the same mail_storage_service_user.


  Commit: 3739f5e5e4099c553efb6d41c4106af4a0031c89
      https://github.com/dovecot/core/commit/3739f5e5e4099c553efb6d41c4106af4a0031c89
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-06-12 (Tue, 12 Jun 2018)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-list.c
    M src/lib-storage/index/imapc/imapc-storage.c
    M src/lib-storage/index/imapc/imapc-storage.h
    M src/plugins/quota/quota-imapc.c

  Log Message:
  -----------
  imapc: Fix leaking memory when sending imapc commands after authentication failure


  Commit: ba9fcbfb81f679ab0be7b98b650453bb9969d422
      https://github.com/dovecot/core/commit/ba9fcbfb81f679ab0be7b98b650453bb9969d422
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-06-12 (Tue, 12 Jun 2018)

  Changed paths:
    M src/lib-smtp/smtp-command-parser.c

  Log Message:
  -----------
  lib-smtp: server: Fix memory leak when handling BDAT command


  Commit: 2453834bce8ac340695f990d7bff617404c28af2
      https://github.com/dovecot/core/commit/2453834bce8ac340695f990d7bff617404c28af2
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-06-12 (Tue, 12 Jun 2018)

  Changed paths:
    M src/plugins/mail-crypt/doveadm-mail-crypt.c

  Log Message:
  -----------
  mail-crypt: Fix memory leak in "doveadm mailbox cryptokey generate"


  Commit: 00da7b5ba0396038a478734dc004845be7335e2b
      https://github.com/dovecot/core/commit/00da7b5ba0396038a478734dc004845be7335e2b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-06-12 (Tue, 12 Jun 2018)

  Changed paths:
    M src/lib-dcrypt/istream-decrypt.c
    M src/lib-dcrypt/istream-decrypt.h
    M src/plugins/mail-crypt/fs-crypt-common.c
    M src/plugins/mail-crypt/mail-crypt-plugin.c

  Log Message:
  -----------
  lib-dcrypt, mail-crypt: Fix leaking memory when using non-global keys

The users' private keys had one reference too much. Because of key cache,
most likely the keys were leaked only once at deinit.

Changed the i_stream_create_decrypt_callback() API so that it allows the
callback to create the key itself without having to store it anywhere.

In this case the key was already added to cache, which increased its
refcount. So an alternative fix would have been to simply unreferenced the
key before returning it. It's a bit ugly though to rely on such caches,
since without the cache the code would be buggy.


  Commit: 1ae409137722552014b7e54f5cb7791bc0dbc0ed
      https://github.com/dovecot/core/commit/1ae409137722552014b7e54f5cb7791bc0dbc0ed
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-06-12 (Tue, 12 Jun 2018)

  Changed paths:
    M src/plugins/mail-crypt/mail-crypt-acl-plugin.c

  Log Message:
  -----------
  mail-crypt-acl: Fix memory leak when updating ACLs


  Commit: 6a36777dc8cae2f4014baaf1b996d09649df8b66
      https://github.com/dovecot/core/commit/6a36777dc8cae2f4014baaf1b996d09649df8b66
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-06-12 (Tue, 12 Jun 2018)

  Changed paths:
    M src/plugins/virtual/virtual-config.c

  Log Message:
  -----------
  virtual: Fix memory leak when selecting mailboxes with '-' or /metadata


  Commit: 35d8a10d6f9f6997d22536f875c568a0a4af8d27
      https://github.com/dovecot/core/commit/35d8a10d6f9f6997d22536f875c568a0a4af8d27
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-06-12 (Tue, 12 Jun 2018)

  Changed paths:
    M src/lib/lib-event.c

  Log Message:
  -----------
  lib: Free global_event_stack array at deinit


  Commit: 619b3fbcd77aaf5addce8a1ab36866b0d8e35c79
      https://github.com/dovecot/core/commit/619b3fbcd77aaf5addce8a1ab36866b0d8e35c79
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-06-12 (Tue, 12 Jun 2018)

  Changed paths:
    M src/lib/lib.c
    M src/lib/restrict-access.c
    M src/lib/restrict-access.h

  Log Message:
  -----------
  lib: restrict-access: Free chroot_dir at deinit


  Commit: 2142656f0382cc4461a621eef9f29508072accd7
      https://github.com/dovecot/core/commit/2142656f0382cc4461a621eef9f29508072accd7
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-06-13 (Wed, 13 Jun 2018)

  Changed paths:
    M src/lib-master/master-service-private.h
    M src/lib-master/master-service.c

  Log Message:
  -----------
  lib-master: Allow calling master_service_deinit() without _init_finish()


Compare: https://github.com/dovecot/core/compare/a3651d181c55...2142656f0382
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.