[dovecot/core] e3dc64: lib-smtp: client: Fix assertion panic occurring wh...

[GitHub]

  Branch: refs/heads/master-2.3
  Home:   https://github.com/dovecot/core
  Commit: e3dc64746f3d1d9634f6597bb3330930fa6aa357
      https://github.com/dovecot/core/commit/e3dc64746f3d1d9634f6597bb3330930fa6aa357
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-06-04 (Mon, 04 Jun 2018)

  Changed paths:
    M src/lib-smtp/smtp-client-command.c
    M src/lib-smtp/smtp-client-private.h

  Log Message:
  -----------
  lib-smtp: client: Fix assertion panic occurring when DATA dot stream cannot be finished immediately.

If o_stream_finish() returns 0, o_stream_send_istream() would be called again
later which causes the panic. Instead, it should only call o_stream_finish() or
o_stream_flush() again to finish the last bit of the output.

Panic was:

Panic: file ostream.c: line 394 (o_stream_send_istream): assertion failed: (!_outstream->finished)


  Commit: 59eb906636c0209f5a3eef7900e33a43a8ad4bd3
      https://github.com/dovecot/core/commit/59eb906636c0209f5a3eef7900e33a43a8ad4bd3
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-06-04 (Mon, 04 Jun 2018)

  Changed paths:
    M src/lib-storage/index/maildir/maildir-save.c

  Log Message:
  -----------
  lib-storage: maildir - Use array code for keywords when saving mail

This is safer alternative and makes following change easier.


  Commit: c1dc4928730451bce8ea70935c915709b3882442
      https://github.com/dovecot/core/commit/c1dc4928730451bce8ea70935c915709b3882442
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-06-04 (Mon, 04 Jun 2018)

  Changed paths:
    M src/lib-storage/index/maildir/maildir-save.c

  Log Message:
  -----------
  lib-storage: maildir - Use index keywords only when saving mail

This fixes mail attachment keywords to work with maildir too.


  Commit: 755a4fe7cc390287a023f079570ab6037c406bec
      https://github.com/dovecot/core/commit/755a4fe7cc390287a023f079570ab6037c406bec
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-06-04 (Mon, 04 Jun 2018)

  Changed paths:
    M src/lib-storage/index/maildir/maildir-save.c

  Log Message:
  -----------
  lib-storage: maildir - Remove unnecessary variable


Compare: https://github.com/dovecot/core/compare/07660d37a514...755a4fe7cc39
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.