[dovecot/core] 237217: acl: Fix return value of acl_attribute_get_acl

GitHub noreply at github.com
Mon Jul 30 11:00:12 EEST 2018


  Branch: refs/heads/master-2.3
  Home:   https://github.com/dovecot/core
  Commit: 237217ef1a5eecb90921939d6be61d53df558660
      https://github.com/dovecot/core/commit/237217ef1a5eecb90921939d6be61d53df558660
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-07-30 (Mon, 30 Jul 2018)

  Changed paths:
    M src/plugins/acl/acl-attributes.c

  Log Message:
  -----------
  acl: Fix return value of acl_attribute_get_acl

If matching acl entry is not found, it must return 0
and not 1 because it did not find anything.

Fixes dsync: Panic: file mailbox-attribute.c: line 362 (mailbox_attribute_get_stream): assertion failed: (value_r->value != NULL || value_r->value_stream != NULL)

Broken in 37c72fa0cd3f1d74d79b64afb3fb6da5ffd4fe3a

Found by @dl8bh



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the dovecot-cvs mailing list