[dovecot/core] 23a46b: imap: support for FETCH SNIPPET

Fri Feb 2 15:30:28 EET 2018

  Branch: refs/heads/master-2.3
  Home:   https://github.com/dovecot/core
  Commit: 23a46b915d2f362bb469e3045539bcecf3e19111
      https://github.com/dovecot/core/commit/23a46b915d2f362bb469e3045539bcecf3e19111
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-01-30 (Tue, 30 Jan 2018)

  Changed paths:
    M configure.ac
    M src/imap/imap-fetch-body.c
    M src/imap/imap-fetch.c
    M src/imap/imap-fetch.h

  Log Message:
  -----------
  imap: support for FETCH SNIPPET

  Commit: 505bb8dd3be0dfd9da733491f97eb9c6bd79d3b5
      https://github.com/dovecot/core/commit/505bb8dd3be0dfd9da733491f97eb9c6bd79d3b5
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-01-31 (Wed, 31 Jan 2018)

  Changed paths:
    M src/lib-program-client/program-client.c

  Log Message:
  -----------
  lib-program-client: Remove useless stream eof check.

It also looks to be problematic.

  Commit: 4dc9b016b1961c9645fd33b0b72792f38ce9159a
      https://github.com/dovecot/core/commit/4dc9b016b1961c9645fd33b0b72792f38ce9159a
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-01-31 (Wed, 31 Jan 2018)

  Changed paths:
    M src/lib-program-client/program-client.c

  Log Message:
  -----------
  lib-program-client: Remove check for -2 returned from i_stream_read_more().

The stream must have space for at least 1 byte.

  Commit: 2bfc6ba718c334ffc0dd1768d6a011aea1ece9cb
      https://github.com/dovecot/core/commit/2bfc6ba718c334ffc0dd1768d6a011aea1ece9cb
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-01-31 (Wed, 31 Jan 2018)

  Changed paths:
    M src/lib-program-client/program-client-remote.c
    M src/lib-program-client/program-client.c

  Log Message:
  -----------
  lib-program-client: Use reliable means of checking for input stream EOF.

  Commit: 2c572e4806009c5dfa5743f74594ef242e8c20c7
      https://github.com/dovecot/core/commit/2c572e4806009c5dfa5743f74594ef242e8c20c7
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-01-31 (Wed, 31 Jan 2018)

  Changed paths:
    M src/lib-program-client/program-client.c

  Log Message:
  -----------
  lib-program-client: Restructure reading input from program to simplify handling of dot input stream.

  Commit: c37e0424b2cfe4f0b1819060743be2995dda88f4
      https://github.com/dovecot/core/commit/c37e0424b2cfe4f0b1819060743be2995dda88f4
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-01-31 (Wed, 31 Jan 2018)

  Changed paths:
    M src/lib-program-client/program-client.c

  Log Message:
  -----------
  lib-program-client: Simplify cleanup of dot input stream in program_client_program_input().

  Commit: dd15704483b9ba729b65e8ff33b9ad96b07b4a17
      https://github.com/dovecot/core/commit/dd15704483b9ba729b65e8ff33b9ad96b07b4a17
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-01-31 (Wed, 31 Jan 2018)

  Changed paths:
    M src/lib-program-client/program-client-remote.c

  Log Message:
  -----------
  lib-program-client: remote: Don't change exit_code in program_client_remote_disconnect() when program_input is already NULL.

When the program_input is NULL, the stream is finished, meaning that the
exit_code is set based on the return code. There can be a program_input for
remote streams, even when the program produces no output.

  Commit: fcc204af55590facd69d130c449cccecb44eb66c
      https://github.com/dovecot/core/commit/fcc204af55590facd69d130c449cccecb44eb66c
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-01-31 (Wed, 31 Jan 2018)

  Changed paths:
    M src/lib-program-client/program-client.c

  Log Message:
  -----------
  lib-program-client: Flush/finish the output stream after o_stream_send_istream().

There may still be data in the output stream buffer. Failing to flush this
leads to truncated output. For the output towards the program o_stream_finish()
is used, since there may be an ostream_dot in between (or something else for
future features).

  Commit: b6f7d7833c585b457f018af20677c90c4445acd6
      https://github.com/dovecot/core/commit/b6f7d7833c585b457f018af20677c90c4445acd6
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-01-31 (Wed, 31 Jan 2018)

  Changed paths:
    M src/lib-program-client/program-client.c

  Log Message:
  -----------
  lib-program-client: Add comments to program_input/program_output functions.

  Commit: 009cc18b7f0df6301dc9817116bda90c65c15fee
      https://github.com/dovecot/core/commit/009cc18b7f0df6301dc9817116bda90c65c15fee
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-01-31 (Wed, 31 Jan 2018)

  Changed paths:
    M src/lib-program-client/program-client.h

  Log Message:
  -----------
  lib-program-client: Document the purpose of the use_dotstream setting.

  Commit: c8f94f5cc1ecaaf35a791ce42a84bf3832dd7908
      https://github.com/dovecot/core/commit/c8f94f5cc1ecaaf35a791ce42a84bf3832dd7908
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-01-31 (Wed, 31 Jan 2018)

  Changed paths:
    M src/lib-program-client/test-program-client-local.c

  Log Message:
  -----------
  lib-program-client: local: Add test for big data I/O.

  Commit: cdeb715d71645e5cae6394e8076e30846de29f27
      https://github.com/dovecot/core/commit/cdeb715d71645e5cae6394e8076e30846de29f27
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-01-31 (Wed, 31 Jan 2018)

  Changed paths:
    M src/lib-program-client/program-client-local.c
    M src/lib-program-client/program-client-private.h
    M src/lib-program-client/program-client-remote.c
    M src/lib-program-client/program-client.c

  Log Message:
  -----------
  lib-program-client: Make an explicit enum for the exit code.

Before, the meaning of the code was confusing, since the actual program returns
a different set of values.

  Commit: 1ab2e30e9c878d81b52c18809229e51e3f8bae55
      https://github.com/dovecot/core/commit/1ab2e30e9c878d81b52c18809229e51e3f8bae55
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-01-31 (Wed, 31 Jan 2018)

  Changed paths:
    M src/submission/submission-client.c

  Log Message:
  -----------
  submission: Initialize proxy connection before starting the SMTP server connection.

The smtp_server_connection_login() function gets pre-login connection data from login service, which can contain commands.
The execution of commands expects the proxy connection object to be initialized.

  Commit: 7a1eb3d2458471a4841adce0168d1de293830779
      https://github.com/dovecot/core/commit/7a1eb3d2458471a4841adce0168d1de293830779
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-01-31 (Wed, 31 Jan 2018)

  Changed paths:
    M src/submission-login/client-authenticate.c

  Log Message:
  -----------
  submission-login: Fix pipelining of commands beyond AUTH.

The master_data_prefix was initialized wrong; it omitted the expected '\0' byte after the helo field.

  Commit: d99860b400daceea797c25112eba06eba1508894
      https://github.com/dovecot/core/commit/d99860b400daceea797c25112eba06eba1508894
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-01-31 (Wed, 31 Jan 2018)

  Changed paths:
    M src/submission/submission-client.h

  Log Message:
  -----------
  submission: Dropped unused field from struct client.

  Commit: 3d71010cf4ad407d130163fe72b84913f1ab8f3f
      https://github.com/dovecot/core/commit/3d71010cf4ad407d130163fe72b84913f1ab8f3f
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-01-31 (Wed, 31 Jan 2018)

  Changed paths:
    M src/submission/cmd-quit.c
    M src/submission/submission-client.c
    M src/submission/submission-client.h
    M src/submission/submission-common.h

  Log Message:
  -----------
  submission: Restructure handling of QUIT command.

- Avoid explicitly proxying QUIT command when the proxy connection is not ready: in that case the SMTP client connection will just send QUIT if appropriate, without waiting for reply.
- Add timeout for proxied QUIT command, so that there are no problems when the relay server hangs after QUIT (addresses FIXME).

  Commit: 16a10546b4b43967915972baa17d0543dbe692d1
      https://github.com/dovecot/core/commit/16a10546b4b43967915972baa17d0543dbe692d1
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-01-31 (Wed, 31 Jan 2018)

  Changed paths:
    M src/submission-login/client.c

  Log Message:
  -----------
  submission-login: Fixed handling of ssl=required for trusted connections.

Normally, SSL is not required for trusted connections (e.g. localhost), but submission-login did not follow this standard.

  Commit: 082a99e392155cccbc937e9f177908cbf931b083
      https://github.com/dovecot/core/commit/082a99e392155cccbc937e9f177908cbf931b083
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-01-31 (Wed, 31 Jan 2018)

  Changed paths:
    M dovecot-config.in.in

  Log Message:
  -----------
  dovecot-config: Update lib-stats directory to lib-old-stats

  Commit: 79ed2b3cb5f743cb6f330c7c63d4fe4246197704
      https://github.com/dovecot/core/commit/79ed2b3cb5f743cb6f330c7c63d4fe4246197704
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-01-31 (Wed, 31 Jan 2018)

  Changed paths:
    M src/lib-smtp/smtp-client-connection.c

  Log Message:
  -----------
  lib-smtp: client: Fix timeout leak sometimes occurring at unexpected remote disconnect.

While disconnected, newly submitted commands are queued, yet scheduled for
immediate failure. The timeout used for that was not cleaned up.

  Commit: ce0a94fd329051c288e8cdcc0228a869c5d2fc23
      https://github.com/dovecot/core/commit/ce0a94fd329051c288e8cdcc0228a869c5d2fc23
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-01 (Thu, 01 Feb 2018)

  Changed paths:
    M src/lib-mail/message-part-data.c
    M src/lib-mail/message-part-data.h

  Log Message:
  -----------
  lib-mail: Add message_part_has_attachment

  Commit: 08a89a646020fca3dfc81937c076543bbc3394f6
      https://github.com/dovecot/core/commit/08a89a646020fca3dfc81937c076543bbc3394f6
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-01 (Thu, 01 Feb 2018)

  Changed paths:
    M src/lib-storage/mail-storage-settings.c
    M src/lib-storage/mail-storage-settings.h

  Log Message:
  -----------
  lib-storage: Add attachment detection settings

  Commit: 39f339f79598296f7b31c5abde4d952e2c1262be
      https://github.com/dovecot/core/commit/39f339f79598296f7b31c5abde4d952e2c1262be
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-01 (Thu, 01 Feb 2018)

  Changed paths:
    M src/lib-storage/mail-storage-private.h
    M src/lib-storage/mail-storage.c
    M src/lib-storage/mail-storage.h
    M src/lib-storage/mail.c

  Log Message:
  -----------
  lib-storage: Set keyword based on attachment presence when saving

If attachment is detected, use $HasAttachment, if not
use $HasNoAttachment

  Commit: 6dfadcd0629d558942f0ef9cbb28f108e8f0c723
      https://github.com/dovecot/core/commit/6dfadcd0629d558942f0ef9cbb28f108e8f0c723
  Author: Sergey Kitov <sergey.kitov at open-xchange.com>
  Date:   2018-02-01 (Thu, 01 Feb 2018)

  Changed paths:
    M src/lib-imap-client/imapc-connection.c

  Log Message:
  -----------
  lib-imap-client: continue imapc operation on parsing errors.

  Commit: 028fa177519a980a6aa746df7cc42226859d2c0f
      https://github.com/dovecot/core/commit/028fa177519a980a6aa746df7cc42226859d2c0f
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-02-01 (Thu, 01 Feb 2018)

  Changed paths:
    M src/submission/cmd-data.c

  Log Message:
  -----------
  submission: BURL command: Return more appropriate 554 5.7.14 error when BURL/URLAUTH is not configured.

Defined in RFC5248, Section 2.4.

  Commit: 163ad616e531e87bcf865c89c9d451fe7957f335
      https://github.com/dovecot/core/commit/163ad616e531e87bcf865c89c9d451fe7957f335
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-02-01 (Thu, 01 Feb 2018)

  Changed paths:
    M src/submission-login/client-authenticate.c

  Log Message:
  -----------
  submission-login: Fail CLIENT_AUTH_RESULT_MECH_SSL_REQUIRED authentication result with 523 5.7.10 error.

Defined in RFC5248, Section 2.4.

  Commit: 5b2169951b214e713179a6484a72a41af789d388
      https://github.com/dovecot/core/commit/5b2169951b214e713179a6484a72a41af789d388
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-02-01 (Thu, 01 Feb 2018)

  Changed paths:
    M src/lib-imap-urlauth/imap-urlauth.c

  Log Message:
  -----------
  lib-imap-urlauth: Fix segfault occurring when userid part is missing for "user+" or "submit+" URLAUTH access.

  Commit: 83b1300b96e753206f9226e3738a7ad9f5428a75
      https://github.com/dovecot/core/commit/83b1300b96e753206f9226e3738a7ad9f5428a75
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-02-01 (Thu, 01 Feb 2018)

  Changed paths:
    M src/lib-mail/mail-html2text.c
    M src/lib-mail/test-mail-html2text.c

  Log Message:
  -----------
  lib-mail: mail-html2text - Validate UCS4 codepoint

Fixes: Panic: file unichar.c: line 160 (uni_ucs4_to_utf8_c): assertion failed: (uni_is_valid_ucs4(chr))

Compare: https://github.com/dovecot/core/compare/bc78d9e57e7c...83b1300b96e7