[dovecot/pigeonhole] 607a95: lib-sieve: editheader extension: Protect the X-Sie...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/pigeonhole
  Commit: 607a95e8b4019600c20010a12b03e02d0c94aad8
      https://github.com/dovecot/pigeonhole/commit/607a95e8b4019600c20010a12b03e02d0c94aad8
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-12-11 (Tue, 11 Dec 2018)

  Changed paths:
    M src/lib-sieve/plugins/editheader/ext-editheader-common.c

  Log Message:
  -----------
  lib-sieve: editheader extension: Protect the X-Sieve-Redirected-From header against modification.

This prevents users from messing with redirect loop detection.


  Commit: b8f5acd7715d4fa95050dca6b353e59496336b9c
      https://github.com/dovecot/pigeonhole/commit/b8f5acd7715d4fa95050dca6b353e59496336b9c
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-12-11 (Tue, 11 Dec 2018)

  Changed paths:
    M src/lib-sieve/cmd-redirect.c

  Log Message:
  -----------
  lib-sieve: redirect action: Update coding style of act_redirect_send().


  Commit: 8a8f9c1e75f865f9eaa95501c6246c5ac39e6ddc
      https://github.com/dovecot/pigeonhole/commit/8a8f9c1e75f865f9eaa95501c6246c5ac39e6ddc
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-12-11 (Tue, 11 Dec 2018)

  Changed paths:
    M src/lib-sieve/cmd-redirect.c

  Log Message:
  -----------
  lib-sieve: redirect action: Update coding style of act_redirect_commit().


  Commit: 51d87ff8d342765b4d960c54b52fd794784b2338
      https://github.com/dovecot/pigeonhole/commit/51d87ff8d342765b4d960c54b52fd794784b2338
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-12-11 (Tue, 11 Dec 2018)

  Changed paths:
    M src/lib-sieve/cmd-redirect.c

  Log Message:
  -----------
  lib-sieve: redirect action: Report errors on original message in act_redirect_commit().

It was errorneously using the (potentially) modified mail struct for error
reporting.


  Commit: 4cf91044014358d668b1f595220572209991d176
      https://github.com/dovecot/pigeonhole/commit/4cf91044014358d668b1f595220572209991d176
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-12-11 (Tue, 11 Dec 2018)

  Changed paths:
    M src/lib-sieve/cmd-redirect.c

  Log Message:
  -----------
  lib-sieve: redirect action: Give log messages emitted during execution a uniform prefix.


  Commit: f0639f1880e9f9842ad8d2c9cd9e65ae5f75c358
      https://github.com/dovecot/pigeonhole/commit/f0639f1880e9f9842ad8d2c9cd9e65ae5f75c358
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-12-11 (Tue, 11 Dec 2018)

  Changed paths:
    M src/lib-sieve/cmd-redirect.c

  Log Message:
  -----------
  lib-sieve: redirect action: Move composition of duplicate database ID to separate function.


  Commit: c42bbea83c094135ace615b21152ac11c9ab7779
      https://github.com/dovecot/pigeonhole/commit/c42bbea83c094135ace615b21152ac11c9ab7779
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-12-11 (Tue, 11 Dec 2018)

  Changed paths:
    M src/lib-sieve/cmd-redirect.c

  Log Message:
  -----------
  lib-sieve: redirect action: Put msgdata->mail in local variable in act_redirect_get_duplicate_id().

Serves as an abbreviation.


  Commit: 78f5952ca43579854264f1a87e29268242db6dcc
      https://github.com/dovecot/pigeonhole/commit/78f5952ca43579854264f1a87e29268242db6dcc
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-12-11 (Tue, 11 Dec 2018)

  Changed paths:
    M src/lib-sieve/cmd-redirect.c
    M tests/execute/smtp.svtest

  Log Message:
  -----------
  lib-sieve: redirect action: Implement additional protection against mail loops.

Also check the X-Sieve-Redirected-From header for our own e-mail addresses. This
header is added by the redirect action itself and in a mail loop it would see
that same header with that same content. This is less reliable than the other
mail loop detection (sender may set such a header), so, unlike the existing loop
detection based on the duplicate db, the implicit keep is not canceled when the
new loop detection is triggered.


Compare: https://github.com/dovecot/pigeonhole/compare/7b86282019ff...78f5952ca435
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.