[dovecot/core] 694586: lib: unlink_directory_r() is refactored.

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 69458644d03fbb37ffdcbd6d7e1d09b230e2ee72
      https://github.com/dovecot/core/commit/69458644d03fbb37ffdcbd6d7e1d09b230e2ee72
  Author: Sergey Kitov <sergey.kitov at open-xchange.com>
  Date:   2017-09-27 (Wed, 27 Sep 2017)

  Changed paths:
    M src/lib/unlink-directory.c

  Log Message:
  -----------
  lib: unlink_directory_r() is refactored.

unlinking doesn't stop at unlink() errors, first error is written to
error_r, consequent errors are logged via i_error errno set to first
happened error. unlink_directory_r() is expecting *error_r to be set
to NULL. errno is set to 0 before each call to readdir().


  Commit: 39715db8bd526c7080f226a8ec94ca1833951b62
      https://github.com/dovecot/core/commit/39715db8bd526c7080f226a8ec94ca1833951b62
  Author: Sergey Kitov <sergey.kitov at open-xchange.com>
  Date:   2017-09-27 (Wed, 27 Sep 2017)

  Changed paths:
    M src/lib/unlink-directory.c
    M src/lib/unlink-directory.h

  Log Message:
  -----------
  lib: unlink_directory() return value is changed to 1 in case of no error.


  Commit: 1d9053f57383a2382c70f76b0790a7bf192aa891
      https://github.com/dovecot/core/commit/1d9053f57383a2382c70f76b0790a7bf192aa891
  Author: Sergey Kitov <sergey.kitov at open-xchange.com>
  Date:   2017-09-27 (Wed, 27 Sep 2017)

  Changed paths:
    M src/lib-fs/test-fs-posix.c
    M src/lib-smtp/test-smtp-submit.c
    M src/lib-storage/list/mailbox-list-delete.c
    M src/lib-storage/list/mailbox-list-index-backend.c
    M src/plugins/fts-lucene/lucene-wrapper.cc

  Log Message:
  -----------
  global: remove unnecessary ENOENT checks from unlink_directory() calls


Compare: https://github.com/dovecot/core/compare/9eec3f335b9c...1d9053f57383