[dovecot/core] 95ec0f: lib: i_close_fd(-1) should be a no-op
GitHub
noreply at github.com
Wed Sep 20 14:30:11 EEST 2017
Branch: refs/heads/master
Home: https://github.com/dovecot/core
Commit: 95ec0fd4789bd249b106e282a32a08f4d1827f63
https://github.com/dovecot/core/commit/95ec0fd4789bd249b106e282a32a08f4d1827f63
Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
Date: 2017-09-20 (Wed, 20 Sep 2017)
Changed paths:
M src/lib/macros.h
Log Message:
-----------
lib: i_close_fd(-1) should be a no-op
Commit: 7b032348d7bbb93ff96188289d3dfc1899b9abb3
https://github.com/dovecot/core/commit/7b032348d7bbb93ff96188289d3dfc1899b9abb3
Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
Date: 2017-09-20 (Wed, 20 Sep 2017)
Changed paths:
M src/doveadm/doveadm-dsync.c
M src/imap-hibernate/imap-client.c
M src/imap-hibernate/imap-hibernate-client.c
M src/imap/imap-client-hibernate.c
M src/lib-dict/dict-file.c
M src/lib-http/test-http-client-errors.c
M src/lib-http/test-http-payload.c
M src/lib-imap-client/test-imapc-client.c
M src/lib-mail/istream-attachment-extractor.c
M src/lib/iostream-temp.c
M src/lib/istream-unix.c
M src/lib/net.c
M src/lib/ostream-unix.c
M src/master/service-listen.c
M src/master/service-monitor.c
M src/plugins/fts-lucene/fts-backend-lucene.c
M src/plugins/fts/fts-expunge-log.c
M src/plugins/quota/quota-maildir.c
M src/plugins/stats/mail-stats-fill.c
M src/stats/stats-carbon.c
Log Message:
-----------
global: start relying on i_close_fd(-1) being a no-op
Cleanup performed with the following semantic patch:
@@
expression E;
@@
- if (E != -1)
- i_close_fd(&E);
+ i_close_fd(&E);
Commit: df1c1ff470f0e15911953638de0a5e10015ef5a2
https://github.com/dovecot/core/commit/df1c1ff470f0e15911953638de0a5e10015ef5a2
Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
Date: 2017-09-20 (Wed, 20 Sep 2017)
Changed paths:
M src/lib/ioloop.c
Log Message:
-----------
lib: io_remove(NULL) and io_remove_closed(NULL) should be no-ops
Commit: 5f1d689131a75c39f064cbd4202373e7edf78f18
https://github.com/dovecot/core/commit/5f1d689131a75c39f064cbd4202373e7edf78f18
Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
Date: 2017-09-20 (Wed, 20 Sep 2017)
Changed paths:
M src/anvil/main.c
M src/auth/auth-client-connection.c
M src/auth/auth-master-connection.c
M src/auth/auth-postfix-connection.c
M src/auth/auth-worker-client.c
M src/auth/auth-worker-server.c
M src/auth/db-checkpassword.c
M src/auth/db-ldap.c
M src/dict/dict-connection.c
M src/director/director-connection.c
M src/director/director-test.c
M src/doveadm/client-connection.c
M src/doveadm/doveadm-dsync.c
M src/doveadm/dsync/dsync-ibc-stream.c
M src/doveadm/server-connection.c
M src/imap-hibernate/imap-client.c
M src/imap-urlauth/imap-urlauth-client.c
M src/imap-urlauth/imap-urlauth-worker.c
M src/imap/cmd-append.c
M src/imap/cmd-idle.c
M src/imap/imap-client.c
M src/ipc/client.c
M src/lib-auth/auth-server-connection.c
M src/lib-dns/dns-lookup.c
M src/lib-http/http-client-connection.c
M src/lib-http/http-client-request.c
M src/lib-http/http-server-connection.c
M src/lib-http/http-server-response.c
M src/lib-http/test-http-payload.c
M src/lib-http/test-http-server-errors.c
M src/lib-imap-client/imapc-connection.c
M src/lib-master/master-auth.c
M src/lib-master/master-login-auth.c
M src/lib-master/master-login.c
M src/lib-master/master-service-haproxy.c
M src/lib-master/master-service.c
M src/lib-program-client/program-client.c
M src/lib-program-client/test-program-client-net.c
M src/lib-program-client/test-program-client-unix.c
M src/lib-smtp/lmtp-client.c
M src/lib-sql/driver-cassandra.c
M src/lib-storage/index/pop3c/pop3c-client.c
M src/lib-storage/list/mailbox-list-index-notify.c
M src/lib-storage/mailbox-watch.c
M src/lib/connection.c
M src/lib/ioloop-notify-inotify.c
M src/lib/ioloop-notify-kqueue.c
M src/lib/iostream-pump.c
M src/lib/ostream-file.c
M src/lmtp/client.c
M src/log/log-connection.c
M src/login-common/client-common-auth.c
M src/login-common/client-common.c
M src/login-common/login-proxy.c
M src/login-common/main.c
M src/login-common/ssl-proxy-openssl.c
M src/master/service-monitor.c
M src/master/service-process-notify.c
M src/plugins/fts/fts-parser-tika.c
M src/pop3/pop3-client.c
M src/stats/client.c
M src/stats/stats-carbon.c
M src/util/rawlog.c
Log Message:
-----------
global: start relying on io_remove{,_closed}(NULL) being a no-op
Cleanup performed with the following semantic patch:
@@
expression E;
@@
- if (E != NULL) {
- io_remove(&E);
- }
+ io_remove(&E);
@@
expression E;
@@
- if (E != NULL) {
- io_remove_closed(&E);
- }
+ io_remove_closed(&E);
Commit: c4d38ef68c615df366208e087fdca99f14b5a3cd
https://github.com/dovecot/core/commit/c4d38ef68c615df366208e087fdca99f14b5a3cd
Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
Date: 2017-09-20 (Wed, 20 Sep 2017)
Changed paths:
M src/lib/ioloop.c
Log Message:
-----------
lib: timeout_remove(NULL) should be a no-op
Commit: 0d1b8b6bec79746c5d89d57dd8c1688946bd9237
https://github.com/dovecot/core/commit/0d1b8b6bec79746c5d89d57dd8c1688946bd9237
Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
Date: 2017-09-20 (Wed, 20 Sep 2017)
Changed paths:
M src/anvil/penalty.c
M src/auth/auth-request-handler.c
M src/auth/auth-request.c
M src/auth/auth-worker-client.c
M src/auth/auth-worker-server.c
M src/auth/db-ldap.c
M src/dict/dict-connection.c
M src/dict/main.c
M src/director/director-connection.c
M src/director/director-test.c
M src/director/director.c
M src/director/main.c
M src/doveadm/server-connection.c
M src/imap-hibernate/imap-client.c
M src/imap-login/imap-login-client.c
M src/imap-urlauth/imap-urlauth-client.c
M src/imap-urlauth/imap-urlauth-login.c
M src/imap-urlauth/imap-urlauth-worker.c
M src/imap/cmd-idle.c
M src/imap/imap-client.c
M src/imap/imap-notify.c
M src/imap/imap-search.c
M src/indexer/indexer.c
M src/lib-auth/auth-master.c
M src/lib-auth/auth-server-connection.c
M src/lib-dict/dict-client.c
M src/lib-dns/dns-lookup.c
M src/lib-http/http-client-connection.c
M src/lib-http/http-client-host.c
M src/lib-http/http-client-peer.c
M src/lib-http/http-client-queue.c
M src/lib-http/http-client.c
M src/lib-http/http-server-connection.c
M src/lib-http/test-http-client-errors.c
M src/lib-http/test-http-server-errors.c
M src/lib-imap-client/imapc-client.c
M src/lib-imap-client/imapc-connection.c
M src/lib-imap-urlauth/imap-urlauth-connection.c
M src/lib-ldap/ldap-connection.c
M src/lib-master/anvil-client.c
M src/lib-master/ipc-server.c
M src/lib-master/master-auth.c
M src/lib-master/master-login-auth.c
M src/lib-master/master-service-haproxy.c
M src/lib-master/master-service.c
M src/lib-oauth2/oauth2.c
M src/lib-program-client/program-client-local.c
M src/lib-program-client/program-client-remote.c
M src/lib-program-client/program-client.c
M src/lib-smtp/lmtp-client.c
M src/lib-sql/driver-cassandra.c
M src/lib-sql/driver-pgsql.c
M src/lib-sql/driver-sqlpool.c
M src/lib-sql/sql-api.c
M src/lib-storage/index/dbox-multi/mdbox-storage.c
M src/lib-storage/index/imapc/imapc-mail-fetch.c
M src/lib-storage/index/imapc/imapc-storage.c
M src/lib-storage/index/mbox/mbox-storage.c
M src/lib-storage/index/pop3c/pop3c-client.c
M src/lib-storage/list/mailbox-list-index-notify.c
M src/lib-storage/list/mailbox-list-index.c
M src/lib-storage/mailbox-watch.c
M src/lib-test/test-ostream.c
M src/lib/connection.c
M src/lib/istream-timeout.c
M src/lib/log-throttle.c
M src/lib/test-iostream-pump.c
M src/lmtp/client.c
M src/lmtp/commands.c
M src/lmtp/lmtp-proxy.c
M src/login-common/access-lookup.c
M src/login-common/client-common-auth.c
M src/login-common/client-common.c
M src/login-common/login-proxy-state.c
M src/login-common/login-proxy.c
M src/login-common/main.c
M src/master/main.c
M src/master/service-monitor.c
M src/master/service-process.c
M src/master/service.c
M src/plugins/last-login/last-login-plugin.c
M src/plugins/mail-crypt/mail-crypt-plugin.c
M src/plugins/quota-clone/quota-clone-plugin.c
M src/plugins/stats/stats-plugin.c
M src/plugins/zlib/zlib-plugin.c
M src/pop3/pop3-client.c
M src/replication/aggregator/replicator-connection.c
M src/replication/replicator/dsync-client.c
M src/replication/replicator/replicator-brain.c
M src/stats/client.c
M src/stats/mail-session.c
M src/stats/stats-carbon.c
M src/util/rawlog.c
Log Message:
-----------
global: start relying on timeout_remove(NULL) being a no-op
Cleanup performed with the following semantic patch:
@@
expression E;
@@
- if (E != NULL) {
- timeout_remove(&E);
- }
+ timeout_remove(&E);
Commit: d6684856fb99e51bc22a6346e08b2d81c996f963
https://github.com/dovecot/core/commit/d6684856fb99e51bc22a6346e08b2d81c996f963
Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
Date: 2017-09-20 (Wed, 20 Sep 2017)
Changed paths:
M src/lib/istream.c
M src/lib/ostream.c
Log Message:
-----------
lib: [io]_stream_destroy(NULL) should be a no-op
Commit: be5773cb4d6edae8a5d9f300c3c7375cdd33826e
https://github.com/dovecot/core/commit/be5773cb4d6edae8a5d9f300c3c7375cdd33826e
Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
Date: 2017-09-20 (Wed, 20 Sep 2017)
Changed paths:
M src/anvil/anvil-connection.c
M src/auth/mech-winbind.c
M src/auth/userdb-passwd-file.c
M src/director/login-connection.c
M src/doveadm/client-connection.c
M src/doveadm/server-connection.c
M src/imap-urlauth/imap-urlauth-client.c
M src/imap-urlauth/imap-urlauth-worker.c
M src/lib-dns/dns-lookup.c
M src/lib-fs/fs-test.c
M src/lib-fs/istream-fs-file.c
M src/lib-mail/istream-attachment-extractor.c
M src/lib-master/master-login-auth.c
M src/lib-program-client/program-client.c
M src/lib-storage/index/mbox/mbox-file.c
M src/lib-storage/index/mbox/mbox-save.c
M src/lib-storage/index/mbox/mbox-storage.c
M src/lib-storage/index/pop3c/pop3c-client.c
M src/lib-storage/list/subscription-file.c
M src/login-common/login-proxy.c
M src/plugins/fs-compress/fs-compress.c
M src/plugins/mail-crypt/fs-crypt-common.c
M src/plugins/mail-filter/istream-ext-filter.c
M src/plugins/mail-filter/ostream-ext-filter.c
M src/replication/aggregator/notify-connection.c
Log Message:
-----------
global: start relying on [io]_stream_destroy(NULL) being a no-op
Cleanup performed with the following semantic patch:
@@
expression E;
@@
- if (E != NULL) {
- i_stream_destroy(&E);
- }
+ i_stream_destroy(&E);
@@
expression E;
@@
- if (E != NULL) {
- o_stream_destroy(&E);
- }
+ o_stream_destroy(&E);
Commit: b3fc5293379feb3640b23622bcc8f5f8d7f1e81d
https://github.com/dovecot/core/commit/b3fc5293379feb3640b23622bcc8f5f8d7f1e81d
Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
Date: 2017-09-20 (Wed, 20 Sep 2017)
Changed paths:
M src/lib/istream.c
M src/lib/ostream.c
Log Message:
-----------
lib: [io]_stream_unref(NULL) should be a no-op
Commit: 204ee6ed414f5e4eeb6f6c10763b55daf56f11ac
https://github.com/dovecot/core/commit/204ee6ed414f5e4eeb6f6c10763b55daf56f11ac
Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
Date: 2017-09-20 (Wed, 20 Sep 2017)
Changed paths:
M src/auth/auth-master-connection.c
M src/auth/auth-postfix-connection.c
M src/doveadm/doveadm-mail.c
M src/doveadm/dsync/dsync-brain-mails.c
M src/doveadm/dsync/dsync-mailbox-export.c
M src/imap/cmd-append.c
M src/imap/cmd-getmetadata.c
M src/imap/cmd-urlfetch.c
M src/imap/imap-fetch.c
M src/lib-fs/fs-metawrap.c
M src/lib-fs/fs-sis.c
M src/lib-fs/test-fs-metawrap.c
M src/lib-http/http-client-request.c
M src/lib-http/http-message-parser.c
M src/lib-http/http-server-response.c
M src/lib-http/test-http-payload.c
M src/lib-imap-client/test-imapc-client.c
M src/lib-imap-storage/imap-msgpart-url.c
M src/lib-imap-urlauth/imap-urlauth-fetch.c
M src/lib-index/mail-index-strmap.c
M src/lib-mail/istream-attachment-connector.c
M src/lib-program-client/program-client.c
M src/lib-program-client/test-program-client-net.c
M src/lib-program-client/test-program-client-unix.c
M src/lib-smtp/lmtp-client.c
M src/lib-smtp/test-smtp-submit.c
M src/lib-storage/index/cydir/cydir-save.c
M src/lib-storage/index/dbox-common/dbox-mail.c
M src/lib-storage/index/imapc/imapc-mail-fetch.c
M src/lib-storage/index/imapc/imapc-save.c
M src/lib-storage/index/index-mail.c
M src/lib-storage/index/index-storage.c
M src/lib-storage/index/pop3c/pop3c-mail.c
M src/lib/ioloop.c
M src/lib/iostream-rawlog.c
M src/lib/istream-chain.c
M src/lib/istream-seekable.c
M src/lib/istream.c
M src/lib/ostream.c
M src/lmtp/client.c
M src/lmtp/lmtp-proxy.c
M src/login-common/client-common.c
M src/plugins/fs-compress/fs-compress.c
M src/plugins/fts/fts-expunge-log.c
M src/plugins/fts/fts-parser-tika.c
M src/plugins/mail-crypt/fs-crypt-common.c
M src/plugins/mail-crypt/mail-crypt-plugin.c
M src/plugins/zlib/zlib-plugin.c
Log Message:
-----------
global: start relying on [io]_stream_unref(NULL) being a no-op
Cleanup performed with the following semantic patch:
@@
expression E;
@@
- if (E != NULL) {
- i_stream_unref(&E);
- }
+ i_stream_unref(&E);
@@
expression E;
@@
- if (E != NULL) {
- o_stream_unref(&E);
- }
+ o_stream_unref(&E);
Commit: 77eae37a92168171293471dd5eeaab037de54f4a
https://github.com/dovecot/core/commit/77eae37a92168171293471dd5eeaab037de54f4a
Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
Date: 2017-09-20 (Wed, 20 Sep 2017)
Changed paths:
M src/lib/mempool.h
Log Message:
-----------
lib: pool_unref(NULL) shoud be a no-op
Commit: c69a177207ed18d0f0210347430a60957136bd6c
https://github.com/dovecot/core/commit/c69a177207ed18d0f0210347430a60957136bd6c
Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
Date: 2017-09-20 (Wed, 20 Sep 2017)
Changed paths:
M src/auth/db-passwd-file.c
M src/doveadm/dsync/dsync-brain.c
M src/doveadm/dsync/dsync-ibc-pipe.c
M src/lib-dict/dict-sql.c
M src/lib-fts/fts-language.c
M src/lib-http/http-message-parser.c
M src/lib-index/mail-index-map.c
M src/lib-mail/istream-attachment-extractor.c
M src/lib-mail/istream-binary-converter.c
M src/lib-sql/driver-cassandra.c
M src/lib-sql/driver-sqlpool.c
M src/lib-storage/index/dbox-common/dbox-file.c
M src/lib-storage/index/dbox-single/sdbox-file.c
M src/lib-storage/index/index-search-mime.c
M src/lib-storage/index/maildir/maildir-uidlist.c
M src/lib-storage/index/pop3c/pop3c-storage.c
M src/lib-storage/list/mailbox-list-fs-iter.c
M src/lib-storage/mail-storage.c
M src/lib/env-util.c
M src/login-common/client-common.c
M src/login-common/login-proxy.c
M src/plugins/acl/acl-backend-vfile.c
M src/plugins/lazy-expunge/lazy-expunge-plugin.c
M src/pop3/pop3-client.c
Log Message:
-----------
global: start relying on pool_unref(NULL) being a no-op
Cleanup performed with the following semantic patch:
@@
expression E;
@@
- if (E != NULL) {
- pool_unref(&E);
- }
+ pool_unref(&E);
Commit: 1a6ff0beebf0ab0c71081eaff1d5d7fd26015a94
https://github.com/dovecot/core/commit/1a6ff0beebf0ab0c71081eaff1d5d7fd26015a94
Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
Date: 2017-09-20 (Wed, 20 Sep 2017)
Changed paths:
M src/lib/buffer.c
Log Message:
-----------
lib: buffer_free(NULL) should be a no-op
Commit: 6307d76096764e66bddc63d4a3e5a1aa19cc528f
https://github.com/dovecot/core/commit/6307d76096764e66bddc63d4a3e5a1aa19cc528f
Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
Date: 2017-09-20 (Wed, 20 Sep 2017)
Changed paths:
M src/lib-compression/istream-lz4.c
M src/lib-dcrypt/istream-decrypt.c
M src/lib-fts/fts-tokenizer.c
M src/lib-imap-urlauth/imap-urlauth-connection.c
M src/lib-index/mail-cache-transaction.c
M src/lib-index/mail-cache.c
M src/lib-index/mail-index-sync-update.c
M src/lib-index/mail-index-transaction-update.c
M src/lib-index/mail-index-transaction-view.c
M src/lib-index/mail-transaction-log-file.c
M src/lib-mail/istream-attachment-extractor.c
M src/lib-mail/istream-qp-decoder.c
M src/lib-mail/istream-qp-encoder.c
M src/lib-mail/message-header-decode.c
M src/lib-mail/test-istream-attachment.c
M src/lib-ssl-iostream/ostream-openssl.c
M src/lib-storage/index/imapc/imapc-mail.c
M src/lib-storage/index/imapc/imapc-storage.c
M src/lib-storage/index/index-mail.c
M src/lib-test/test-ostream.c
M src/lib/iostream-rawlog.c
M src/lib/iostream-temp.c
M src/lib/istream-seekable.c
M src/lmtp/client.c
M src/plugins/fts/fts-build-mail.c
M src/plugins/fts/fts-parser.c
Log Message:
-----------
global: start relying on buffer_free(NULL) being a no-op
Cleanup performed with the following semantic patch:
@@
expression E;
@@
- if (E != NULL) {
- buffer_free(&E);
- }
+ buffer_free(&E);
Compare: https://github.com/dovecot/core/compare/ce8d63810932...6307d7609676
More information about the dovecot-cvs
mailing list