[dovecot/core] 22e623: lib-storage: Fix error logging after mail_storage_...

[GitHub]

  Branch: refs/heads/master-2.2
  Home:   https://github.com/dovecot/core
  Commit: 22e6232cca7c93db0142202718a7811db394c87d
      https://github.com/dovecot/core/commit/22e6232cca7c93db0142202718a7811db394c87d
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-09-12 (Tue, 12 Sep 2017)

  Changed paths:
    M src/lib-storage/mail-storage.c
    M src/lib-storage/test-mail-storage.c

  Log Message:
  -----------
  lib-storage: Fix error logging after mail_storage_set_internal_error()

The function doesn't actually set the last_internal_error and it also
doesn't update last_error_is_internal, so calling
mail_storage_get_last_internal_error() afterwards could be returning an
error for some different older error.

Since there's no parameter to set the internal error string, just reset
last_error_is_internal=FALSE.


  Commit: 94811d840961229f60df5e0306015d879642087f
      https://github.com/dovecot/core/commit/94811d840961229f60df5e0306015d879642087f
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-09-12 (Tue, 12 Sep 2017)

  Changed paths:
    M src/lib-storage/mail-storage.c

  Log Message:
  -----------
  lib-storage: mailbox_set_index_error() - Set internal error string to index's error


  Commit: c8c87b6136f5ae20c42b0709d69672789d67021b
      https://github.com/dovecot/core/commit/c8c87b6136f5ae20c42b0709d69672789d67021b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-09-12 (Tue, 12 Sep 2017)

  Changed paths:
    M src/lib-storage/mail-storage.c

  Log Message:
  -----------
  lib-storage: mail_set_mail_cache_corrupted() - set also internal error string


  Commit: 969fddbd76655a4d573d8d1f9008e947c9b89d77
      https://github.com/dovecot/core/commit/969fddbd76655a4d573d8d1f9008e947c9b89d77
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-09-12 (Tue, 12 Sep 2017)

  Changed paths:
    M src/lib-storage/index/index-mail.c

  Log Message:
  -----------
  lib-storage: index_mail_set_cache_corrupted() - Don't reset internal error string

It's already set correctly by the earlier functions.


  Commit: 0991c15293982926c4c727eef08cee86d8b037cf
      https://github.com/dovecot/core/commit/0991c15293982926c4c727eef08cee86d8b037cf
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-09-12 (Tue, 12 Sep 2017)

  Changed paths:
    M src/lib-storage/mail-storage-private.h
    M src/lib-storage/mail-storage.c

  Log Message:
  -----------
  lib-storage: Add mail_storage_set_index_error()


  Commit: 291ad7bae145104d8b2031da53c6583a6602901a
      https://github.com/dovecot/core/commit/291ad7bae145104d8b2031da53c6583a6602901a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-09-12 (Tue, 12 Sep 2017)

  Changed paths:
    M src/lib-storage/index/dbox-multi/mdbox-map.c
    M src/lib-storage/index/dbox-multi/mdbox-storage-rebuild.c

  Log Message:
  -----------
  mdbox: Use mail_storage_set_index_error() instead of poorly duplicating it


  Commit: b700b7ffd85a8d033cc34806950d487ff31c18ef
      https://github.com/dovecot/core/commit/b700b7ffd85a8d033cc34806950d487ff31c18ef
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-09-12 (Tue, 12 Sep 2017)

  Changed paths:
    M src/lib-storage/index/dbox-common/dbox-attachment.c
    M src/lib-storage/index/dbox-common/dbox-storage.c

  Log Message:
  -----------
  sdbox: Don't open mail files when expunging

It was done when mail_attachment_fs was non-empty (and default is
non-empty), even though mail_attachment_dir was empty.


Compare: https://github.com/dovecot/core/compare/2dceda4a6b07...b700b7ffd85a