[dovecot/core] 2dec37: dbox: Allow ":" separator between mail_attachment_...

Mon Mar 27 10:30:14 UTC 2017

  Branch: refs/heads/master-2.2
  Home:   https://github.com/dovecot/core
  Commit: 2dec3731d6837dc40366643e3d3a6eb896b5ea44
      https://github.com/dovecot/core/commit/2dec3731d6837dc40366643e3d3a6eb896b5ea44
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-storage/index/dbox-common/dbox-storage.c

  Log Message:
  -----------
  dbox: Allow ":" separator between mail_attachment_fs driver and args.

The ":" separator is nowadays commonly used elsewhere for the separator,
so it should work here as well.

  Commit: 42edee2d75292e639bfd5ef852203fa75fac9bbc
      https://github.com/dovecot/core/commit/42edee2d75292e639bfd5ef852203fa75fac9bbc
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/plugins/quota/quota-status.c
    M src/plugins/quota/quota-storage.c
    M src/plugins/quota/quota.c
    M src/plugins/quota/quota.h

  Log Message:
  -----------
  quota: Introduce quota_alloc_result return type

  Commit: 9edefd429576dc07298d525f7d01feaa755642cd
      https://github.com/dovecot/core/commit/9edefd429576dc07298d525f7d01feaa755642cd
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/plugins/quota/quota-private.h
    M src/plugins/quota/quota.c
    M src/plugins/trash/trash-plugin.c

  Log Message:
  -----------
  quota: Use quota_alloc_result in quota_settings.test_alloc

  Commit: 690f935be61409138e9cd700aff4b2fea9429c08
      https://github.com/dovecot/core/commit/690f935be61409138e9cd700aff4b2fea9429c08
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M doc/example-config/conf.d/90-quota.conf
    M src/plugins/quota/Makefile.am
    M src/plugins/quota/quota-private.h
    M src/plugins/quota/quota-status.c
    M src/plugins/quota/quota-storage.c
    M src/plugins/quota/quota.c
    M src/plugins/quota/quota.h

  Log Message:
  -----------
  quota: Add quota_max_mail_size setting

  Commit: dcf7e4f93a2fbd31d17b4ac71bf8c611fc5d22ae
      https://github.com/dovecot/core/commit/dcf7e4f93a2fbd31d17b4ac71bf8c611fc5d22ae
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-storage/mail-storage-private.h
    M src/lib-storage/mail-storage.c
    M src/lib-storage/mail-storage.h

  Log Message:
  -----------
  lib-storage: Add mail_storage_get_last_internal_error()

This returns the error given to mail_storage_set_critical().

  Commit: 6732ce37da006744404e79c9fde312c10f7ac4cf
      https://github.com/dovecot/core/commit/6732ce37da006744404e79c9fde312c10f7ac4cf
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lmtp/commands.c

  Log Message:
  -----------
  lmtp: Log internal error on STATUS_CHECK_OVER_QUOTA failure

  Commit: 5c556ef3aabed152516b23de04031e78f74f893b
      https://github.com/dovecot/core/commit/5c556ef3aabed152516b23de04031e78f74f893b
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/doveadm/doveadm-mail-altmove.c
    M src/doveadm/doveadm-mail-copymove.c
    M src/doveadm/doveadm-mail-deduplicate.c
    M src/doveadm/doveadm-mail-expunge.c
    M src/doveadm/doveadm-mail-fetch.c
    M src/doveadm/doveadm-mail-flags.c
    M src/doveadm/doveadm-mail-import.c
    M src/doveadm/doveadm-mail-index.c
    M src/doveadm/doveadm-mail-iter.c
    M src/doveadm/doveadm-mail-mailbox-metadata.c
    M src/doveadm/doveadm-mail-mailbox-status.c
    M src/doveadm/doveadm-mail-mailbox.c
    M src/doveadm/doveadm-mail-save.c
    M src/doveadm/doveadm-mail-search.c
    M src/doveadm/doveadm-mail.c
    M src/doveadm/dsync/dsync-brain-mailbox-tree-sync.c
    M src/doveadm/dsync/dsync-brain-mailbox.c
    M src/doveadm/dsync/dsync-brain.c
    M src/doveadm/dsync/dsync-mailbox-export.c
    M src/doveadm/dsync/dsync-mailbox-import.c
    M src/doveadm/dsync/dsync-mailbox-tree-fill.c
    M src/imap/imap-state.c
    M src/indexer/master-connection.c
    M src/lda/main.c
    M src/lib-imap-urlauth/imap-urlauth-backend.c
    M src/lib-lda/mail-deliver.c
    M src/lib-storage/index/dbox-multi/mdbox-storage-rebuild.c
    M src/lib-storage/index/index-mailbox-size.c
    M src/lib-storage/mail-autoexpunge.c
    M src/lib-storage/mail-storage.c
    M src/lib-storage/mailbox-guid-cache.c
    M src/lmtp/commands.c
    M src/plugins/acl/doveadm-acl.c
    M src/plugins/fts-lucene/fts-backend-lucene.c
    M src/plugins/fts-lucene/lucene-wrapper.cc
    M src/plugins/fts/fts-api.c
    M src/plugins/fts/fts-build-mail.c
    M src/plugins/lazy-expunge/lazy-expunge-plugin.c
    M src/plugins/mail-crypt/doveadm-mail-crypt.c
    M src/plugins/mail-crypt/mail-crypt-acl-plugin.c
    M src/plugins/mail-crypt/mail-crypt-key.c
    M src/plugins/mail-crypt/test-mail-key.c
    M src/plugins/pop3-migration/pop3-migration-plugin.c
    M src/plugins/push-notification/push-notification-driver-ox.c
    M src/plugins/push-notification/push-notification-event-mailboxcreate.c
    M src/plugins/quota/quota-count.c
    M src/plugins/quota/quota.c
    M src/pop3/pop3-client.c
    M src/pop3/pop3-commands.c

  Log Message:
  -----------
  global: Log internal storage error on failure

  Commit: b551e46cacdc52de740c532a257e86ba85060b41
      https://github.com/dovecot/core/commit/b551e46cacdc52de740c532a257e86ba85060b41
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/pop3/pop3-client.c

  Log Message:
  -----------
  pop3: Start autoexpunging only after client is disconnected

  Commit: 70d00769d337bd4703b9e40bba7e75652892634b
      https://github.com/dovecot/core/commit/70d00769d337bd4703b9e40bba7e75652892634b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/imap/imap-client.c
    M src/imap/main.c
    M src/lib-storage/mail-storage-service.c
    M src/lib-storage/mail-storage-service.h
    M src/lib-storage/mail-user.c
    M src/lib-storage/mail-user.h
    M src/lmtp/commands.c
    M src/lmtp/main.c
    M src/pop3/main.c
    M src/pop3/pop3-client.c

  Log Message:
  -----------
  lib-storage: Replace MAIL_STORAGE_SERVICE_FLAG_AUTOEXPUNGE with explicit mail_user_autoexpunge()

This allows better control of which users are being autoexpunged. This
patch changes behavior at least in two ways now:

1) After shared folder access, the owner user isn't autoexpunged at deinit.
Although this is a bit questionable of whether it should be or not.

2) LMTP's quota check at RCPT TO stage doesn't trigger autoexpunging.

  Commit: bc72ba681ebc14b5e8384676dc6b74a0abd7840b
      https://github.com/dovecot/core/commit/bc72ba681ebc14b5e8384676dc6b74a0abd7840b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lmtp/commands.c

  Log Message:
  -----------
  lmtp: Trigger autoexpunging only for the last RCPT TO.

Otherwise if the autoexpunging takes a long time, the LMTP client could
disconnect due to a timeout. The mails would still eventually get delivered
though, so it would result in duplicate mails being delivered.

An alternative to this would be to keep all the mail_users referenced until
the delivery is finished and then autoexpunge all of them at the end. It
increases memory usage though and complicates the code, so at least for now
it's not implemented.

  Commit: 35b5cca7a320676f82a8f5a185e4ea890740d44e
      https://github.com/dovecot/core/commit/35b5cca7a320676f82a8f5a185e4ea890740d44e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-storage/mail-autoexpunge.c
    M src/lib-storage/mail-autoexpunge.h

  Log Message:
  -----------
  lib-storage: Change mail_user_autoexpunge() to return number of autoexpunged mails

  Commit: a440c98a2e21f9571c54b6b11314315a562964d9
      https://github.com/dovecot/core/commit/a440c98a2e21f9571c54b6b11314315a562964d9
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-storage/mail-autoexpunge.c

  Log Message:
  -----------
  lib-storage: Fix mail_user_autoexpunge() return value to be initialized properly

  Commit: 5f7ffdbe9f6bf4acea8558f88c06879fad1df1a5
      https://github.com/dovecot/core/commit/5f7ffdbe9f6bf4acea8558f88c06879fad1df1a5
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/imap-login/imap-login-client.c
    M src/login-common/client-common.c
    M src/login-common/client-common.h

  Log Message:
  -----------
  imap-login: Move forward_fields updating code to login-common

This allows using the new client_add_forward_field() in e.g. plugins.

  Commit: 26fde3e2171e414581ac2e8c6b40cdc06e56f615
      https://github.com/dovecot/core/commit/26fde3e2171e414581ac2e8c6b40cdc06e56f615
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M doc/example-config/conf.d/10-ssl.conf

  Log Message:
  -----------
  doc: mention no_ticket in ssl config example

  Commit: dfabd74c045675a1bfc583f7fe0fab7868c789f9
      https://github.com/dovecot/core/commit/dfabd74c045675a1bfc583f7fe0fab7868c789f9
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-mail/message-header-decode.c
    M src/lib-mail/test-message-header-decode.c

  Log Message:
  -----------
  lib-mail: Fix read overflow / crash in message_header_decode()

If the input string was "=?charset?Q|B?text?", the code attempted to look up
the character after it. And if it was "=", the callback was called with
size=-1, which ends up in a crash.

  Commit: e1275ba7add8a8c849551fcba2e6f7511875d34a
      https://github.com/dovecot/core/commit/e1275ba7add8a8c849551fcba2e6f7511875d34a
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/plugins/quota/quota-plugin.c
    M src/plugins/quota/quota-private.h
    M src/plugins/quota/quota.c

  Log Message:
  -----------
  quota: Add backend register/unregister

This way, other mail plugins can register their own
quota backends.

  Commit: a7b684786e67a00a44cf3e4950a437ae4c374de2
      https://github.com/dovecot/core/commit/a7b684786e67a00a44cf3e4950a437ae4c374de2
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-storage.c
    M src/lib-storage/index/imapc/imapc-storage.h

  Log Message:
  -----------
  imapc: Fail user creation if login to imapc_host fails.

This causes imapc to actually wait for the login to succeed or fail.
Such a wait was already done by the imap code, which will be removed by
the next patch.

  Commit: c8e6aa69b7802fbd8f10475e7e359168c045374d
      https://github.com/dovecot/core/commit/c8e6aa69b7802fbd8f10475e7e359168c045374d
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/imap/main.c

  Log Message:
  -----------
  imap: Remove imapc-specific "is connection valid?" code

This is now done by imapc itself in the previous patch

  Commit: 772535ebc559b331101b436113899b407858290d
      https://github.com/dovecot/core/commit/772535ebc559b331101b436113899b407858290d
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-settings.c
    M src/lib-storage/index/imapc/imapc-settings.h
    M src/lib-storage/index/imapc/imapc-storage.c

  Log Message:
  -----------
  imapc: Add imapc_features=delay-login

The connection to imapc_host is delayed until it's actually needed to be
performed.

  Commit: c1b218cd6da5f6efcaedfad14e62c5710d254313
      https://github.com/dovecot/core/commit/c1b218cd6da5f6efcaedfad14e62c5710d254313
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-http/http-client-request.c
    M src/lib-http/test-http-client-errors.c

  Log Message:
  -----------
  lib-http: client: Fix aborting a request that has a delayed error.

Caused by recent changes in delayed error handling.

Compare: https://github.com/dovecot/core/compare/ff271fae9e12...c1b218cd6da5