[dovecot/core] c57b69: pop3-login: Cleanup - move command handling to pop...

GitHub noreply at github.com
Wed Jun 14 00:24:36 EEST 2017


  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: c57b69b830f4302319d7e3fd5647ad5eacbf15c3
      https://github.com/dovecot/core/commit/c57b69b830f4302319d7e3fd5647ad5eacbf15c3
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-14 (Wed, 14 Jun 2017)

  Changed paths:
    M src/pop3-login/client.c

  Log Message:
  -----------
  pop3-login: Cleanup - move command handling to pop3_client_input_next_cmd()


  Commit: edfdc577ffe7408fd6463eb9dba11260d380ab53
      https://github.com/dovecot/core/commit/edfdc577ffe7408fd6463eb9dba11260d380ab53
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-14 (Wed, 14 Jun 2017)

  Changed paths:
    M src/imap-login/imap-login-client.c
    M src/imap-urlauth/imap-urlauth-login.c
    M src/login-common/client-common.h
    M src/pop3-login/client.c

  Log Message:
  -----------
  *-login: Add client_vfuncs.input_next_cmd()

This allows plugins to hook into all the pre-login commands. For example
with imap-login most of the commands could already be hooked into, except
for ID and AUTHENTICATE because their parameters reading is handled
specially. This allows hooking into them as well.

This is actually internal to all the login binaries, so it wouldn't have to
be in login-common. However, login-common already has all the code to handle
overriding functions nicely and this is a rather useful feature for all the
protocols anyway, so it's easier this way and not too ugly.


Compare: https://github.com/dovecot/core/compare/9b2e48654bdf...edfdc577ffe7


More information about the dovecot-cvs mailing list