[dovecot/core] c9d76e: lib: import byte swapping & endian converting func...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: c9d76e2baf653fa5504d6849e5c1aae32eff3c53
      https://github.com/dovecot/core/commit/c9d76e2baf653fa5504d6849e5c1aae32eff3c53
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2017-06-12 (Mon, 12 Jun 2017)

  Changed paths:
    M src/lib/Makefile.am
    A src/lib/byteorder.h
    M src/lib/lib.h
    A src/lib/test-byteorder.c
    M src/lib/test-lib.inc

  Log Message:
  -----------
  lib: import byte swapping & endian converting functions


  Commit: b9e830a81455faf3c0dadfc9dbf0c7dc8aca955c
      https://github.com/dovecot/core/commit/b9e830a81455faf3c0dadfc9dbf0c7dc8aca955c
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2017-06-12 (Mon, 12 Jun 2017)

  Changed paths:
    M src/doveadm/doveadm-dump-mailboxlog.c
    M src/doveadm/dsync/dsync-mailbox-state.c
    M src/lib-compression/istream-lz4.c
    M src/lib-compression/istream-zlib.c
    M src/lib-dcrypt/istream-decrypt.c
    M src/lib-index/mail-index-util.c
    M src/lib-index/mailbox-log.c
    M src/lib-ntlm/ntlm-des.c
    M src/lib/test-guid.c

  Log Message:
  -----------
  global: use new byte ordering API


  Commit: a76f1c806e9ac7d8e0d652dfaef5035d0c677892
      https://github.com/dovecot/core/commit/a76f1c806e9ac7d8e0d652dfaef5035d0c677892
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-12 (Mon, 12 Jun 2017)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-list.c

  Log Message:
  -----------
  imapc: Remove auth_failed check from imapc_list_get_storage_name()

Reverts 9949dc3649ac7a00289f6bf0662c793bee3d4286. It doesn't seem to be
actually needed at least now, and it's breaking:

 * SELECT INBOX -> failure due to remote server being down
 * SELECT INBOX -> NO [CANNOT] Invalid mailbox name: Name is empty


  Commit: be21b9e65a37c29995899f7923f6d7e5771dc3ad
      https://github.com/dovecot/core/commit/be21b9e65a37c29995899f7923f6d7e5771dc3ad
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-12 (Mon, 12 Jun 2017)

  Changed paths:
    M src/lib-imap-client/imapc-client.h
    M src/lib-storage/index/imapc/imapc-list.c
    M src/lib-storage/index/imapc/imapc-storage.c
    M src/lib-storage/index/imapc/imapc-storage.h

  Log Message:
  -----------
  imapc: Change auth_failed boolean to more specific auth_failed_state

Since we now rely on auth_failed_state being initialized to zero,
explicitly set IMAPC_COMMAND_STATE_OK to be defined as 0.


  Commit: 28576b6283287ef3ca6ae0d818ebd4ce6c879107
      https://github.com/dovecot/core/commit/28576b6283287ef3ca6ae0d818ebd4ce6c879107
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-12 (Mon, 12 Jun 2017)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-storage.c
    M src/lib-storage/index/imapc/imapc-storage.h

  Log Message:
  -----------
  imapc: Cleanup - Rename auth_error to auth_failed_reason for consistency


  Commit: ab838f1555795d5766bdaef795a14c98a5437c9e
      https://github.com/dovecot/core/commit/ab838f1555795d5766bdaef795a14c98a5437c9e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-12 (Mon, 12 Jun 2017)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-storage.c

  Log Message:
  -----------
  imapc: Make sure storage error has the proper auth failure error string

The first failed command always had the correct error string, but the
following failed commands just returned -1 without updating storage error.
The storage error could have been something completely different by then.


  Commit: 68e81f0685f3bea85cd0a1b06f35535427f453b5
      https://github.com/dovecot/core/commit/68e81f0685f3bea85cd0a1b06f35535427f453b5
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-12 (Mon, 12 Jun 2017)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-save.c

  Log Message:
  -----------
  imapc: Fix APPEND error message to include APPEND, not COPY


  Commit: d824b1ac42e0bc3779b45e779bc3b6557a227f0a
      https://github.com/dovecot/core/commit/d824b1ac42e0bc3779b45e779bc3b6557a227f0a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-12 (Mon, 12 Jun 2017)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-save.c

  Log Message:
  -----------
  imapc: Check for auth failures when saving messages

First, don't even attempt an APPEND if we've already seen an auth failure.
Second, if APPEND does fail because of auth error, set the correct error to
storage.


  Commit: 77ea60d15c146644da5428e8109e8fa6571af6dd
      https://github.com/dovecot/core/commit/77ea60d15c146644da5428e8109e8fa6571af6dd
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-12 (Mon, 12 Jun 2017)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-list.c
    M src/lib-storage/index/imapc/imapc-list.h

  Log Message:
  -----------
  imapc: Remove root_sep_lookup_failed cache

The auth_failed_* should already be enough for this. This removal also
fixes the storage error message to be auth_failed_reason when possible.


  Commit: f94abb02d228a078defac6d457f15cb6d8f82dda
      https://github.com/dovecot/core/commit/f94abb02d228a078defac6d457f15cb6d8f82dda
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-12 (Mon, 12 Jun 2017)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-storage.c

  Log Message:
  -----------
  imapc: Don't reconnect on STATUS if auth failure was already seen.


  Commit: a2dd3a0de99582744b3d45141cb4d8846054941a
      https://github.com/dovecot/core/commit/a2dd3a0de99582744b3d45141cb4d8846054941a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-12 (Mon, 12 Jun 2017)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-list.c

  Log Message:
  -----------
  imapc: Don't reconnect on DELETE if auth failure was already seen.


  Commit: 873a5bec86c4ee62dad8099cb12465e7aa42e261
      https://github.com/dovecot/core/commit/873a5bec86c4ee62dad8099cb12465e7aa42e261
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-12 (Mon, 12 Jun 2017)

  Changed paths:
    M src/lib-storage/list/mailbox-list-iter.c

  Log Message:
  -----------
  lib-storage: If mailbox list iteration fails, don't add INBOX

It possibly should have been returned by the list iteration itself and we
could be returning it wrong here.

Also calling this causes imapc to lost the error message in mailbox_list.


  Commit: 916c9c1b86c8afc4bfd78e8588675e4c0f3e126c
      https://github.com/dovecot/core/commit/916c9c1b86c8afc4bfd78e8588675e4c0f3e126c
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-12 (Mon, 12 Jun 2017)

  Changed paths:
    M src/lib-storage/list/mailbox-list-iter.c

  Log Message:
  -----------
  lib-storage: Fail mailbox list iteration early if it fails to get INBOX flags

The resulting INBOX reply could be wrong in that case.

Also with imapc if the remote server is down, this causes two connection
errors instead of just one.


  Commit: d82a985d9a1532b14cfb45166cdb0883752420e2
      https://github.com/dovecot/core/commit/d82a985d9a1532b14cfb45166cdb0883752420e2
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-12 (Mon, 12 Jun 2017)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-list.c

  Log Message:
  -----------
  imapc: If mailbox iteration fails, make sure error message isn't lost.


Compare: https://github.com/dovecot/core/compare/0cf3b30b86e6...d82a985d9a15