[dovecot/core] 18a221: lib-mail: test-message-address cleanup

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 18a2214eedb08d043277cf1d3e75c45762014663
      https://github.com/dovecot/core/commit/18a2214eedb08d043277cf1d3e75c45762014663
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-07 (Wed, 07 Jun 2017)

  Changed paths:
    M src/lib-mail/test-message-address.c

  Log Message:
  -----------
  lib-mail: test-message-address cleanup

Merge input and output into the same struct to make it clearer.


  Commit: a8ebb72c0fba1a6a71104e530bf5903d5f149351
      https://github.com/dovecot/core/commit/a8ebb72c0fba1a6a71104e530bf5903d5f149351
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-07 (Wed, 07 Jun 2017)

  Changed paths:
    M src/lib-mail/test-message-address.c

  Log Message:
  -----------
  lib-mail: test-message-address - Test also writing invalid addresses


  Commit: 6a2a171ae0a80ee8883956ac11028199339cda77
      https://github.com/dovecot/core/commit/6a2a171ae0a80ee8883956ac11028199339cda77
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-07 (Wed, 07 Jun 2017)

  Changed paths:
    M src/lib-mail/message-address.c
    M src/lib-mail/test-message-address.c

  Log Message:
  -----------
  lib-mail: message_address_write() - Don't add '@' if domain is missing


  Commit: ffc8c62c46a087a4d30f8704b0a8440d3e4d8916
      https://github.com/dovecot/core/commit/ffc8c62c46a087a4d30f8704b0a8440d3e4d8916
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-07 (Wed, 07 Jun 2017)

  Changed paths:
    M src/lib-mail/message-address.c
    M src/lib-mail/test-message-address.c

  Log Message:
  -----------
  lib-mail: message_address_write() - Don't write empty <>


  Commit: 5a8ee853d0b62692a6e624b125d08d87a79e001f
      https://github.com/dovecot/core/commit/5a8ee853d0b62692a6e624b125d08d87a79e001f
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-07 (Wed, 07 Jun 2017)

  Changed paths:
    M src/lib-mail/message-address.c
    M src/lib-mail/test-message-address.c

  Log Message:
  -----------
  lib-mail: message_address_write() - Always write <user at domain> as output

This is the standard format nowadays, so don't convert <user at domain> into
plain user at domain.


  Commit: dc8c1e74e851357f46f1c938fc45064945f5a1b0
      https://github.com/dovecot/core/commit/dc8c1e74e851357f46f1c938fc45064945f5a1b0
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-07 (Wed, 07 Jun 2017)

  Changed paths:
    M src/lib-mail/message-address.c
    M src/lib-mail/test-message-address.c

  Log Message:
  -----------
  lib-mail: message_address_write() - Write empy username as ""

We can't output <@domain> because that conflicts with the <@route:...>
syntax. Also ""@domain seems to be a valid address.


  Commit: 58a770f1e0ab553a0dba9cad9d6f3a6cdf2dc855
      https://github.com/dovecot/core/commit/58a770f1e0ab553a0dba9cad9d6f3a6cdf2dc855
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-07 (Wed, 07 Jun 2017)

  Changed paths:
    M src/lib-mail/message-address.c
    M src/lib-mail/test-message-address.c

  Log Message:
  -----------
  lib-mail: message_address_parse() - Add INVALID_ROUTE/SYNTAX_ERROR only if fill_missing==TRUE

This allows message_address_write() to write the parsed invalid address in a
way that at least somewhat resembles the original input.


  Commit: 6b8f4863bb2b0938d40f774122baf6528a833ea0
      https://github.com/dovecot/core/commit/6b8f4863bb2b0938d40f774122baf6528a833ea0
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-07 (Wed, 07 Jun 2017)

  Changed paths:
    M src/lib-mail/test-message-address.c

  Log Message:
  -----------
  lib-mail: test-message-address - add more and better organized tests


  Commit: 3cb2f0951e39037319eb12288dde48875abfd004
      https://github.com/dovecot/core/commit/3cb2f0951e39037319eb12288dde48875abfd004
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-07 (Wed, 07 Jun 2017)

  Changed paths:
    M src/lib-mail/message-address.c

  Log Message:
  -----------
  lib-mail: message_address_parse() - Remove unnecessary NULL checks

message_address_parse() always initialized rfc822_parser_init() with
last_comment string.


  Commit: 4c9294fcb17fb12326ff5db29e2f882cf4bd7fed
      https://github.com/dovecot/core/commit/4c9294fcb17fb12326ff5db29e2f882cf4bd7fed
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-07 (Wed, 07 Jun 2017)

  Changed paths:
    M src/lib-mail/message-address.c
    M src/lib-mail/test-message-address.c

  Log Message:
  -----------
  lib-mail: message_address_parse() - Fix reading out-of-bounds read on invalid input


  Commit: 22cf8b6acecb87348e32c6c6d22c863019a34009
      https://github.com/dovecot/core/commit/22cf8b6acecb87348e32c6c6d22c863019a34009
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-07 (Wed, 07 Jun 2017)

  Changed paths:
    M src/lib-mail/message-address.c

  Log Message:
  -----------
  lib-mail: message_address_parse() - don't stop at invalid addresses when parsing group

Also the end-group's message_address shouldn't have invalid_syntax=TRUE,
except when we didn't actually find the ending ';'


  Commit: 52818a09c8c0e9319e6425467f01aa99cd2d017c
      https://github.com/dovecot/core/commit/52818a09c8c0e9319e6425467f01aa99cd2d017c
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-07 (Wed, 07 Jun 2017)

  Changed paths:
    M src/lib-mail/message-address.c

  Log Message:
  -----------
  lib-mail: message_address_parse() - don't stop at <> when parsing address lists

And similarly don't stop at <@domain>


  Commit: f55b07916c82db8b915b28252e44ce6fb2bd3080
      https://github.com/dovecot/core/commit/f55b07916c82db8b915b28252e44ce6fb2bd3080
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-07 (Wed, 07 Jun 2017)

  Changed paths:
    M src/lib-mail/test-message-address.c

  Log Message:
  -----------
  lib-mail: Improve test-message-address to test invalid addresses in lists

Test in both a group and list of addresses.


  Commit: 5430411539347357344f6bf2552731b62f0a14fd
      https://github.com/dovecot/core/commit/5430411539347357344f6bf2552731b62f0a14fd
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-07 (Wed, 07 Jun 2017)

  Changed paths:
    M src/lib-mail/message-address.c
    M src/lib-mail/test-message-address.c

  Log Message:
  -----------
  lib-mail: message_address_parse() - Handle invalid standalone phrases better

We'll treat "local-part" (without quotes) as a mailbox even without
@domain, but if it continues with anything or if it's a quoted-string,
we'll treat it as a display-name instead.

This is probably better than just converting everything to display-name,
since there are likely to exist headers like "To: localuser"


  Commit: e106213aebb4170904697814c168548e1ba97de9
      https://github.com/dovecot/core/commit/e106213aebb4170904697814c168548e1ba97de9
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-06-07 (Wed, 07 Jun 2017)

  Changed paths:
    M src/lib-mail/message-address.c
    M src/lib-mail/test-message-address.c

  Log Message:
  -----------
  lib-mail: message_address_parse() - Fix fill_missing==TRUE handling

Mainly MISSING_DOMAIN wasn't set in all situations. Also added unit tests.


Compare: https://github.com/dovecot/core/compare/c536bf22651c...e106213aebb4