[dovecot/core] b20202: auth: Access always first entry when flushing fail...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: b20202007c06fa77da44d00fbac7f029cb6d8f86
      https://github.com/dovecot/core/commit/b20202007c06fa77da44d00fbac7f029cb6d8f86
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-06-05 (Mon, 05 Jun 2017)

  Changed paths:
    M src/auth/auth-request-handler.c

  Log Message:
  -----------
  auth: Access always first entry when flushing failures

The code is deleting the first item after accessing
it, and then moving forward. It will eventually go
beyond the array and get NULL ptr and fail.

Instead we need to always get the first item,
since the array deletion is moving the queued items
forward.

Broken by e18b4e41