[dovecot/core] 0f0bf4: pop3: move pop3 session locking out of client_crea...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 0f0bf444b82bbc8c9c269a1580f37274121ce5f2
      https://github.com/dovecot/core/commit/0f0bf444b82bbc8c9c269a1580f37274121ce5f2
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2017-06-04 (Sun, 04 Jun 2017)

  Changed paths:
    M src/pop3/main.c
    M src/pop3/pop3-client.c
    M src/pop3/pop3-client.h

  Log Message:
  -----------
  pop3: move pop3 session locking out of client_create

As a result, we can directly return the client structure (instead of
passing it back via a _r arg).

This makes the pop3 client_create look more like the imap version.


  Commit: 813009c4303c095ed66a6a01c110b5cfe84ea3c3
      https://github.com/dovecot/core/commit/813009c4303c095ed66a6a01c110b5cfe84ea3c3
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2017-06-04 (Sun, 04 Jun 2017)

  Changed paths:
    M src/pop3/main.c

  Log Message:
  -----------
  pop3: rename login_client_connected() client arg to login_client

This makes the next commit cleaner.


  Commit: 6616907d9668d9df7bacbd863d439a31084b3d3c
      https://github.com/dovecot/core/commit/6616907d9668d9df7bacbd863d439a31084b3d3c
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2017-06-04 (Sun, 04 Jun 2017)

  Changed paths:
    M src/pop3/main.c

  Log Message:
  -----------
  pop3: client_create_from_input should return the client struct

This makes the code more similar to imap's, making subsequent changes
easier.


  Commit: 11b8ec1586ee7c54c42fdbdf207576b06bb47b90
      https://github.com/dovecot/core/commit/11b8ec1586ee7c54c42fdbdf207576b06bb47b90
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2017-06-04 (Sun, 04 Jun 2017)

  Changed paths:
    M src/pop3/main.c

  Log Message:
  -----------
  pop3: client_create_from_input shouldn't process input

This makes the pop3 code resemble the imap code more.  Making the subsequent
changes easier.


  Commit: bd5cf4556e8a5ffd0b40dbbf404f25a2e840b2d2
      https://github.com/dovecot/core/commit/bd5cf4556e8a5ffd0b40dbbf404f25a2e840b2d2
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2017-06-04 (Sun, 04 Jun 2017)

  Changed paths:
    M src/pop3/main.c
    M src/pop3/pop3-client.c

  Log Message:
  -----------
  pop3: initialize namespaces explicitly

(instead of relying on mail user initialization to instantiate them for
us)


  Commit: 07470e90d392d4bbb77c8f75b852d4497bb9a571
      https://github.com/dovecot/core/commit/07470e90d392d4bbb77c8f75b852d4497bb9a571
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2017-06-04 (Sun, 04 Jun 2017)

  Changed paths:
    M src/pop3/main.c

  Log Message:
  -----------
  pop3: send back auth reply sooner

If possible (i.e., pop3_lock_session=no), we can send back the OK
response earlier.


Compare: https://github.com/dovecot/core/compare/be97d7e54ef5...07470e90d392