[dovecot/core] 40a926: lib-smtp: server: Moved ssl_start argument from sm...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 40a926a1aeae93b3d4944b56eacb013d3059b549
      https://github.com/dovecot/core/commit/40a926a1aeae93b3d4944b56eacb013d3059b549
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-28 (Thu, 28 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-connection.c
    M src/lib-smtp/smtp-server.h
    M src/lib-smtp/test-smtp-payload.c
    M src/lib-smtp/test-smtp-server-errors.c
    M src/lmtp/client.c
    M src/submission-login/client.c
    M src/submission/submission-client.c

  Log Message:
  -----------
  lib-smtp: server: Moved ssl_start argument from smtp_server_connection_start() to smtp_server_connection_create().

This frees smtp_server_connection_start() for general use.


  Commit: b85a1bcaa9f82dd5b326967da5f1a26595173ee9
      https://github.com/dovecot/core/commit/b85a1bcaa9f82dd5b326967da5f1a26595173ee9
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-28 (Thu, 28 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-connection.c
    M src/lib-smtp/smtp-server.h

  Log Message:
  -----------
  lib-smtp: server: Moved smtp_server_connection_start() after smtp_server_connection_login().

Also fixes an indent problem in the header comment implicitly.


  Commit: 6b312949dcd641f1196dd299240dec03b46b5042
      https://github.com/dovecot/core/commit/6b312949dcd641f1196dd299240dec03b46b5042
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-28 (Thu, 28 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-connection.c
    M src/lib-smtp/smtp-server.h
    M src/submission/submission-client.c

  Log Message:
  -----------
  lib-smtp: server: Remove implicit smtp_server_connection_start() from smtp_server_connection_login().


  Commit: 9a3c4a10fddf508c14d19fdc508d86b1be6d145b
      https://github.com/dovecot/core/commit/9a3c4a10fddf508c14d19fdc508d86b1be6d145b
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-28 (Thu, 28 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-connection.c

  Log Message:
  -----------
  lib-smtp: server: Delay handling initial input (from login service) until after smtp_server_connection_start().

Instead, it is now handled in normal io callback.


  Commit: f091dd12d19df22e5403855f93dedee437bd7d87
      https://github.com/dovecot/core/commit/f091dd12d19df22e5403855f93dedee437bd7d87
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-28 (Thu, 28 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-connection.c
    M src/lib-smtp/smtp-server-private.h

  Log Message:
  -----------
  lib-smtp: server: Protect smpt_server_connection_start() from being called multiple times.


  Commit: 3feb1ab03917f2773f379fa79315a0f87db59bc5
      https://github.com/dovecot/core/commit/3feb1ab03917f2773f379fa79315a0f87db59bc5
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-28 (Thu, 28 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-connection.c

  Log Message:
  -----------
  lib-smtp: server: Prevent calling smtp_server_connection_login() after smtp_server_connection_start().

Added assertion.


  Commit: 912e87d5be9dd8895e8cb7c6cb51d8a752edbe8c
      https://github.com/dovecot/core/commit/912e87d5be9dd8895e8cb7c6cb51d8a752edbe8c
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-28 (Thu, 28 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-connection.c
    M src/lib-smtp/smtp-server-private.h
    M src/lib-smtp/smtp-server.h

  Log Message:
  -----------
  lib-smtp: server: Add APIs for halting and resuming connection command handling.

Also adds function to start the connection in a pending (halted) state. This way the greeting can already be sent (over SSL if needed), while deferring command handling until some external activity is completed.


  Commit: d63fbcb367b6de01f5e39d72a825f03a832e308f
      https://github.com/dovecot/core/commit/d63fbcb367b6de01f5e39d72a825f03a832e308f
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-28 (Thu, 28 Dec 2017)

  Changed paths:
    M src/submission/submission-client.c

  Log Message:
  -----------
  submission: Block server input handling until proxy connection to relay server completes.

This makes sure we are aware of the full extent of the backend server's capabilities, before we start handling commands.
Before, only EHLO commands were blocked this way, but this did not account for MAIL/RCPT parameters, which are equally dependent.
Fixes problems with clients that send no EHLO after AUTH, like Thunderbird.


  Commit: 53cb0fe737bce65b3c8334dba43f79427f53f879
      https://github.com/dovecot/core/commit/53cb0fe737bce65b3c8334dba43f79427f53f879
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-28 (Thu, 28 Dec 2017)

  Changed paths:
    M src/submission/cmd-helo.c
    M src/submission/submission-client.h

  Log Message:
  -----------
  submission: EHLO command: Remove obsolete pending_ehlo handling.

This was used to wait with sending an EHLO reply until the proxy connection to the relay server completes.
The previous commit made this functionality obsolete, since command input handling is blocked entirely until the proxy connection is ready.


Compare: https://github.com/dovecot/core/compare/c864fdd520b0...53cb0fe737bc