[dovecot/core] de3742: lib-smtp: server: Fix compile error in smtp-server...

Fri Dec 22 17:55:30 EET 2017

  Branch: refs/heads/release-2.3.0
  Home:   https://github.com/dovecot/core
  Commit: de37420036c9e04c9326f609f94b039c50078e07
      https://github.com/dovecot/core/commit/de37420036c9e04c9326f609f94b039c50078e07
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-helo.c

  Log Message:
  -----------
  lib-smtp: server: Fix compile error in smtp-server-cmd-helo.c.

Error was:
"smtp-server-cmd-helo.c", line 140: void function cannot return value

  Commit: 3f3d3c649afc73aa2d4dbd7bbe60887ede30d123
      https://github.com/dovecot/core/commit/3f3d3c649afc73aa2d4dbd7bbe60887ede30d123
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-connection.c

  Log Message:
  -----------
  lib-smtp: server: Fixed assertion in smtp_server_connection_next_reply() checking whether command is fully replied.

It did not handle LMTP DATA/BDAT command correctly, for which there can be multiple replies.

This fixes mixing local/remote recipients in LMTP, which used to crash:
Panic: file smtp-server-connection.c: line 610 (smtp_server_connection_next_reply): assertion failed: (cmd->state == SMTP_SERVER_COMMAND_STATE_READY_TO_REPLY && smtp_server_command_is_replied(cmd))

  Commit: d0d92f4d430f2f55bc6dd4e9d92a0e710611f11a
      https://github.com/dovecot/core/commit/d0d92f4d430f2f55bc6dd4e9d92a0e710611f11a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M doc/man/doveadm-acl.1.in
    M doc/man/doveadm-altmove.1.in
    M doc/man/doveadm-auth.1.in
    M doc/man/doveadm-batch.1.in
    M doc/man/doveadm-deduplicate.1.in
    M doc/man/doveadm-director.1.in
    M doc/man/doveadm-dump.1.in
    M doc/man/doveadm-exec.1.in
    M doc/man/doveadm-expunge.1.in
    M doc/man/doveadm-fetch.1.in
    M doc/man/doveadm-flags.1.in
    M doc/man/doveadm-force-resync.1.in
    M doc/man/doveadm-fs.1.in
    M doc/man/doveadm-fts.1.in
    M doc/man/doveadm-help.1.in
    M doc/man/doveadm-import.1.in
    M doc/man/doveadm-index.1.in
    M doc/man/doveadm-instance.1.in
    M doc/man/doveadm-kick.1.in
    M doc/man/doveadm-log.1.in
    M doc/man/doveadm-mailbox-cryptokey.1.in
    M doc/man/doveadm-mailbox.1.in
    M doc/man/doveadm-move.1.in
    M doc/man/doveadm-penalty.1.in
    M doc/man/doveadm-proxy.1.in
    M doc/man/doveadm-purge.1.in
    M doc/man/doveadm-pw.1.in
    M doc/man/doveadm-quota.1.in
    M doc/man/doveadm-replicator.1.in
    M doc/man/doveadm-save.1.in
    M doc/man/doveadm-search-query.7
    M doc/man/doveadm-search.1.in
    M doc/man/doveadm-stats.1.in
    M doc/man/doveadm-sync.1.in
    M doc/man/doveadm-user.1.in
    M doc/man/doveadm-who.1.in
    M doc/man/doveadm.1.in
    M doc/man/doveconf.1.in
    M doc/man/dovecot-lda.1.in
    M doc/man/dovecot.1.in

  Log Message:
  -----------
  man: Update version number to v2.3

  Commit: b1de00590435fe5189d2057126cebe5b24db36d2
      https://github.com/dovecot/core/commit/b1de00590435fe5189d2057126cebe5b24db36d2
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-starttls.c
    M src/lib-smtp/smtp-server.h
    M src/submission-login/client.c

  Log Message:
  -----------
  lib-smtp: server: Change conn_start_tls() connection callback to return a success status.

  Commit: d076bd977c935693da271118b985879a91b9a145
      https://github.com/dovecot/core/commit/d076bd977c935693da271118b985879a91b9a145
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-connection.c
    M src/lib-smtp/smtp-server.h

  Log Message:
  -----------
  lib-smtp: server: Add smtp_server_connection_set_ssl_streams().

It wraps smtp_server_connection_set_streams() and additionally marks the connection as SSL-secured.

  Commit: 7adffef212c70393f5ed5d8275b3c2552b965a97
      https://github.com/dovecot/core/commit/7adffef212c70393f5ed5d8275b3c2552b965a97
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-starttls.c

  Log Message:
  -----------
  lib-smtp: server: STARTTLS command: Call smtp_server_connection_set_ssl_streams() after calling the conn_start_tls() connection callback.

This is called instead smtp_server_connection_set_streams(), so that the connection is now marked as SSL-secured.
This fixes a submission-login bug that prevented client login when ssl=required.

  Commit: 71965c144dee09d88346a99d7eb3f608ea01a529
      https://github.com/dovecot/core/commit/71965c144dee09d88346a99d7eb3f608ea01a529
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M m4/want_sodium.m4
    M src/auth/Makefile.am

  Log Message:
  -----------
  auth: Don't include LIBSODIUM_LIBS in dependencies

Put it into AUTH_LIBS among other libraries that are used by auth.

  Commit: 6bc16cfd5794d3c6af30f58ff0986d34dfcff2a1
      https://github.com/dovecot/core/commit/6bc16cfd5794d3c6af30f58ff0986d34dfcff2a1
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M src/doveadm/client-connection-tcp.c

  Log Message:
  -----------
  doveadm-server: Fix potential hangs with SSL connections

  Commit: a8369d9326626da19eb8aeec6d6d8cf18ef0ce82
      https://github.com/dovecot/core/commit/a8369d9326626da19eb8aeec6d6d8cf18ef0ce82
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M doc/example-config/conf.d/15-lda.conf

  Log Message:
  -----------
  example-config: Fix postmaster_address comment

The default value was wrong.

  Commit: 21a6bcd6a2ce1201290705584f53d1941b3267d4
      https://github.com/dovecot/core/commit/21a6bcd6a2ce1201290705584f53d1941b3267d4
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M m4/cc_fortify.m4

  Log Message:
  -----------
  m4: Avoid _FORTIFY_SOURCE redefinition warnings

Some source based distros like Gentoo already enable -D_FORTIFY_SOURCE=2
by default resulting in the following warnings during build:

<command-line>:0:0: warning: "_FORTIFY_SOURCE" redefined
<built-in>: note: this is the location of the previous definition

Patch by Eray Aslan

  Commit: cb2feda28091bb5e670ebaf551b4379ce052234e
      https://github.com/dovecot/core/commit/cb2feda28091bb5e670ebaf551b4379ce052234e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M m4/want_sodium.m4

  Log Message:
  -----------
  m4: Fix detecting libsodium to use LIBS instead of LDFLAGS

Patch by Eray Aslan

  Commit: c471ce9506206778ab9db02f6fef0893d6d3eab6
      https://github.com/dovecot/core/commit/c471ce9506206778ab9db02f6fef0893d6d3eab6
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M src/plugins/imap-old-stats/imap-stats-plugin.c
    M src/plugins/imap-old-stats/imap-stats-plugin.h

  Log Message:
  -----------
  imap-old-stats plugin: Finish renaming the plugin

The init functions and dependency were named wrong, so it didn't work.

  Commit: 96dd47c9e393c5f88967e3dfb5fa65e134fa8ad2
      https://github.com/dovecot/core/commit/96dd47c9e393c5f88967e3dfb5fa65e134fa8ad2
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M src/auth/db-lua.c
    M src/auth/passdb-lua.c

  Log Message:
  -----------
  auth: Fix password and scheme handling in Lua db

This was only partially fixed in c86575ac9776d0995355d03719c82e7ceac802e6

  Commit: 818b09ec564cf17eafa1495cc3021b4ee8836802
      https://github.com/dovecot/core/commit/818b09ec564cf17eafa1495cc3021b4ee8836802
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M src/lib-master/master-service-settings.c
    M src/lib-master/stats-client.c
    M src/lib-master/stats-client.h

  Log Message:
  -----------
  lib-master: Hide connect(stats-writer) errors when running via CLI

Only hide errors that occur if the stats process isn't running, i.e. when
socket isn't found or there's no listener. This way e.g. permission errors
are still logged, which points to a wrong configuration.

  Commit: e71a080beeadae03f21317e7ce27a928c2b1d0e7
      https://github.com/dovecot/core/commit/e71a080beeadae03f21317e7ce27a928c2b1d0e7
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M src/lib-master/master-service-settings.c
    M src/lib-master/master-service.c
    M src/lib-master/master-service.h

  Log Message:
  -----------
  lib-master: Add master_service_init_stats_client()

This allows initializing the stats client after master_service_init() if
necessary.

  Commit: c0dd00d8f50399c1c9b60c99260f9782cdc0e869
      https://github.com/dovecot/core/commit/c0dd00d8f50399c1c9b60c99260f9782cdc0e869
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M src/doveadm/doveadm.c

  Log Message:
  -----------
  doveadm: Don't connect to stats-writer for the "quick init" commands

  Commit: 93fd68aa4f3dddbf4e8281e5bd67309532a73dc4
      https://github.com/dovecot/core/commit/93fd68aa4f3dddbf4e8281e5bd67309532a73dc4
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M src/doveadm/server-connection.c

  Log Message:
  -----------
  doveadm: Fix potential crash or reading garbage from doveadm-server

The connection's input buffer may have been reallocated or otherwise moved
while checking for log input.

  Commit: 56c43d37cb1237d65545bf781ebaff77a861856e
      https://github.com/dovecot/core/commit/56c43d37cb1237d65545bf781ebaff77a861856e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M src/lib/istream-multiplex.c

  Log Message:
  -----------
  lib: istream-multiplex - Return error if the last packet wasn't fully read

  Commit: 70b1a3544341f3e46338eee311124abbb9625ece
      https://github.com/dovecot/core/commit/70b1a3544341f3e46338eee311124abbb9625ece
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M src/doveadm/doveadm-dump.c

  Log Message:
  -----------
  doveadm dump: Allow doveadm_cmd_dump.test() to be NULL

This means that there's no auto-detection for the dump type.

  Commit: dfc19b468a62622685f8ce8607c9f0704ae4ad86
      https://github.com/dovecot/core/commit/dfc19b468a62622685f8ce8607c9f0704ae4ad86
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M src/doveadm/doveadm-dump.c

  Log Message:
  -----------
  doveadm dump: Add "multiplex" dump type

This allows dumping all channels from istream-multiplex stream.

  Commit: c8b89eb9968980589904a58e8bd72fc8c00039be
      https://github.com/dovecot/core/commit/c8b89eb9968980589904a58e8bd72fc8c00039be
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M NEWS
    M configure.ac

  Log Message:
  -----------
  Released v2.3.0.

Compare: https://github.com/dovecot/core/compare/12aba5948b36...c8b89eb99689