[dovecot/core] ba6eb8: lib-smtp: server: Fix compile error in smtp-server...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: ba6eb871706bc913ab94ee3a67f4f1901acaf2ed
      https://github.com/dovecot/core/commit/ba6eb871706bc913ab94ee3a67f4f1901acaf2ed
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-18 (Mon, 18 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-helo.c

  Log Message:
  -----------
  lib-smtp: server: Fix compile error in smtp-server-cmd-helo.c.

Error was:
"smtp-server-cmd-helo.c", line 140: void function cannot return value


  Commit: 3bded60597c6c3bf09eaa09790c36d439cb3a018
      https://github.com/dovecot/core/commit/3bded60597c6c3bf09eaa09790c36d439cb3a018
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-18 (Mon, 18 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-connection.c

  Log Message:
  -----------
  lib-smtp: server: Fixed assertion in smtp_server_connection_next_reply() checking whether command is fully replied.

It did not handle LMTP DATA/BDAT command correctly, for which there can be multiple replies.

This fixes mixing local/remote recipients in LMTP, which used to crash:
Panic: file smtp-server-connection.c: line 610 (smtp_server_connection_next_reply): assertion failed: (cmd->state == SMTP_SERVER_COMMAND_STATE_READY_TO_REPLY && smtp_server_command_is_replied(cmd))


Compare: https://github.com/dovecot/core/compare/0ac0c93af1bb...3bded60597c6