[dovecot/pigeonhole] 16f16b: lib-sieve: program client: Significantly improved ...

Thu Jun 23 20:21:15 UTC 2016

  Branch: refs/heads/master-0.4
  Home:   https://github.com/dovecot/pigeonhole
  Commit: 16f16bde7b6283ada45ddd394f14ef93c22e1222
      https://github.com/dovecot/pigeonhole/commit/16f16bde7b6283ada45ddd394f14ef93c22e1222
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-06-23 (Thu, 23 Jun 2016)

  Changed paths:
    M src/lib-sieve/util/program-client-local.c
    M src/lib-sieve/util/program-client-private.h
    M src/lib-sieve/util/program-client-remote.c
    M src/lib-sieve/util/program-client.c

  Log Message:
  -----------
  lib-sieve: program client: Significantly improved error handling.

Stream errors were never logged properly.
Streams now have a name that makes sense.
Timeout errors were handled in a rather stupid fashion.

  Commit: 8918308da7edcb99b8ce605e6cc362fab6a0ded1
      https://github.com/dovecot/pigeonhole/commit/8918308da7edcb99b8ce605e6cc362fab6a0ded1
  Author: Stephan Bosch <stephan at dovecot.fi>
  Date:   2016-06-23 (Thu, 23 Jun 2016)

  Changed paths:
    M src/managesieve/managesieve-client.c

  Log Message:
  -----------
  managesieve: Free mail_user only after client is disconnected.

Mimics Dovecot/IMAP change 1001bda65e9f592d852a26ddd6a993f7973050bf.

  Commit: f1981177c0c1f8c6548b359c6ad62bdfea5d6a8e
      https://github.com/dovecot/pigeonhole/commit/f1981177c0c1f8c6548b359c6ad62bdfea5d6a8e
  Author: Stephan Bosch <stephan at dovecot.fi>
  Date:   2016-06-23 (Thu, 23 Jun 2016)

  Changed paths:
    M src/managesieve/managesieve-client.c

  Log Message:
  -----------
  managesieve: Avoid crashing at deinit if mail_user_unref() triggers mail_storage_callbacks

This could have happened with Maildir/mbox and autoexpunging.
Mimics Dovecot/IMAP change ddffbb277e212adb9d594b3d7d1e1d39fa78f7c6.

  Commit: ee90b797cd5b33657a27fe10d0374d52606790d2
      https://github.com/dovecot/pigeonhole/commit/ee90b797cd5b33657a27fe10d0374d52606790d2
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-06-23 (Thu, 23 Jun 2016)

  Changed paths:
    M src/lib-sieve/storage/ldap/sieve-ldap-db.c

  Log Message:
  -----------
  lib-sieve: ldap storage: Fixed compiler warning occurring under specific configuration conditions.

  Commit: 27fca192eda4e73c8ace142768734744a4a3bbfa
      https://github.com/dovecot/pigeonhole/commit/27fca192eda4e73c8ace142768734744a4a3bbfa
  Author: Stephan Bosch <stephan at dovecot.fi>
  Date:   2016-06-23 (Thu, 23 Jun 2016)

  Changed paths:
    M src/lib-sieve/plugins/variables/ext-variables-common.c

  Log Message:
  -----------
  lib-sieve: variables extensions: Fixed handling of importing a variable into a scope that is already imported earlier.

This allocated a new variable entry every time.

  Commit: 3278187adc573ed92c91707a6019d306a7048264
      https://github.com/dovecot/pigeonhole/commit/3278187adc573ed92c91707a6019d306a7048264
  Author: Stephan Bosch <stephan at dovecot.fi>
  Date:   2016-06-23 (Thu, 23 Jun 2016)

  Changed paths:
    M src/lib-sieve/sieve-extensions.c

  Log Message:
  -----------
  lib-sieve: Handle duplicate registrations of capabilities better.

This would uselessly allocate a new entry with the same content.

  Commit: 8cf77787bf53b43369c352642f26d1ab66a1aed6
      https://github.com/dovecot/pigeonhole/commit/8cf77787bf53b43369c352642f26d1ab66a1aed6
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-06-23 (Thu, 23 Jun 2016)

  Changed paths:
    M src/managesieve-login/managesieve-proxy.c

  Log Message:
  -----------
  managesieve-login: proxy: Did not handle zero return value from managesieve_parser_read_args() correctly.

  Commit: 18b993280ad1e80d9235f46fe5f0fc425aa52ddf
      https://github.com/dovecot/pigeonhole/commit/18b993280ad1e80d9235f46fe5f0fc425aa52ddf
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-06-23 (Thu, 23 Jun 2016)

  Changed paths:
    M src/lib-sieve/plugins/include/ext-include-variables.c
    M src/lib-sieve/plugins/variables/ext-variables-arguments.c
    M src/lib-sieve/plugins/variables/ext-variables-common.c
    M src/lib-sieve/plugins/variables/ext-variables-common.h
    M src/lib-sieve/plugins/variables/sieve-ext-variables.h

  Log Message:
  -----------
  lib-sieve: variables extension: Changed declaration of new variables to avoid useless memory allocation.

Also prevents assert failures with new hash_table_insert() assertion against existing entries.
This changes the API for the variables extension.

  Commit: 8796a685870cdcd6d06df8c3628f13bf862337e4
      https://github.com/dovecot/pigeonhole/commit/8796a685870cdcd6d06df8c3628f13bf862337e4
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-06-23 (Thu, 23 Jun 2016)

  Changed paths:
    M src/plugins/imapsieve/imap-sieve.c

  Log Message:
  -----------
  imapsieve plugin: Removed dead assignment reported by scan-build.

  Commit: 44de7323eba69f63db41d54f7be93ce6ec6c5d13
      https://github.com/dovecot/pigeonhole/commit/44de7323eba69f63db41d54f7be93ce6ec6c5d13
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-06-23 (Thu, 23 Jun 2016)

  Changed paths:
    M src/lib-sieve/ext-envelope.c

  Log Message:
  -----------
  lib-sieve: envelope extension: Mixed up bool and int for sieve_ast_stringlist_map() return type.

  Commit: e9969e3f2edbf81d15462d43f8c65c0d3aa6f132
      https://github.com/dovecot/pigeonhole/commit/e9969e3f2edbf81d15462d43f8c65c0d3aa6f132
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-06-23 (Thu, 23 Jun 2016)

  Changed paths:
    M src/plugins/imapsieve/imap-sieve-storage.c

  Log Message:
  -----------
  imapsieve plugin: Prevent possible NULL pointer dereference at transaction commit.

  Commit: ecff7a940af5feeaa566937b127b6e414d41b3b9
      https://github.com/dovecot/pigeonhole/commit/ecff7a940af5feeaa566937b127b6e414d41b3b9
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-06-23 (Thu, 23 Jun 2016)

  Changed paths:
    M src/lib-sieve/tst-address.c

  Log Message:
  -----------
  lib-sieve: address test: Mixed up bool and int for sieve_ast_stringlist_map() return type.

  Commit: aa4da9660f128838397b0274e1d52f624afe05ac
      https://github.com/dovecot/pigeonhole/commit/aa4da9660f128838397b0274e1d52f624afe05ac
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-06-23 (Thu, 23 Jun 2016)

  Changed paths:
    M src/plugins/imapsieve/imap-sieve.c

  Log Message:
  -----------
  imapsieve plugin: Restructured imap_sieve_run_scripts() function such that the compile error code is never used uninitialized.

  Commit: 6b64c24e40c57768c2587a4a2bc4fb4799ea873b
      https://github.com/dovecot/pigeonhole/commit/6b64c24e40c57768c2587a4a2bc4fb4799ea873b
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-06-23 (Thu, 23 Jun 2016)

  Changed paths:
    M src/lib-sieve/plugins/enotify/mailto/uri-mailto.c

  Log Message:
  -----------
  lib-sieve: enotify extension: Fixed instances where FALSE was returned rather than NULL.

  Commit: 8ce7fd5bbc8463d60ac20af6f22baa04d3fc104b
      https://github.com/dovecot/pigeonhole/commit/8ce7fd5bbc8463d60ac20af6f22baa04d3fc104b
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-06-23 (Thu, 23 Jun 2016)

  Changed paths:
    M src/lib-sieve/plugins/variables/ext-variables-common.c

  Log Message:
  -----------
  lib-sieve: variables extesnion: Fixed instances where FALSE was returned rather than NULL.

  Commit: ea993c5a76b6ea3b88ed7abae16bbc7faed715d7
      https://github.com/dovecot/pigeonhole/commit/ea993c5a76b6ea3b88ed7abae16bbc7faed715d7
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-06-23 (Thu, 23 Jun 2016)

  Changed paths:
    M src/lib-sieve/util/edit-mail.c

  Log Message:
  -----------
  lib-sieve: edit-mail: Passed FALSE for normalizer argument of message_header_decode_utf8() rather than NULL.

  Commit: eef375d09201539c07367e1907691309d9bfe104
      https://github.com/dovecot/pigeonhole/commit/eef375d09201539c07367e1907691309d9bfe104
  Author: Stephan Bosch <stephan at dovecot.fi>
  Date:   2016-06-23 (Thu, 23 Jun 2016)

  Changed paths:
    M src/plugins/imapsieve/imap-sieve-storage.c

  Log Message:
  -----------
  imapsieve plugin: During transaction run the synchronized version of the target mailbox was opened too early.

This meant opening a mailbox a second time even if it did not match any mailbox rules.

Compare: https://github.com/dovecot/pigeonhole/compare/d85babbf2a86...eef375d09201