[dovecot/core] 4b1448: lib-dcrypt: Assert-crash if impossible private/pub...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 4b14487036d9dfd953192f0d13a054c92c587eed
      https://github.com/dovecot/core/commit/4b14487036d9dfd953192f0d13a054c92c587eed
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-06-21 (Tue, 21 Jun 2016)

  Changed paths:
    M src/lib-dcrypt/dcrypt-openssl.c

  Log Message:
  -----------
  lib-dcrypt: Assert-crash if impossible private/public keys are seen.


  Commit: f85f12e3f9a4da8ce5e282530ce377410eabfb46
      https://github.com/dovecot/core/commit/f85f12e3f9a4da8ce5e282530ce377410eabfb46
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-06-21 (Tue, 21 Jun 2016)

  Changed paths:
    M src/lib-dcrypt/dcrypt-openssl.c

  Log Message:
  -----------
  lib-dcrypt: Assert-crash if key parameter is NULL.

If it happens, it's a bug.


  Commit: 955c276b9de538cfbfe4cff19f2a610f57e8d5c7
      https://github.com/dovecot/core/commit/955c276b9de538cfbfe4cff19f2a610f57e8d5c7
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-06-21 (Tue, 21 Jun 2016)

  Changed paths:
    M src/lib-dcrypt/dcrypt-openssl.c
    M src/lib-dcrypt/dcrypt-private.h
    M src/lib-dcrypt/dcrypt.c
    M src/lib-dcrypt/dcrypt.h
    M src/lib-dcrypt/test-crypto.c

  Log Message:
  -----------
  lib-dcrypt: dcrypt_key_convert_private_to_public() can no longer fail.

Removed unnecessary failure handling.


  Commit: 394391e78f26cba1d7fca19d4b8617453a7041b8
      https://github.com/dovecot/core/commit/394391e78f26cba1d7fca19d4b8617453a7041b8
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-06-21 (Tue, 21 Jun 2016)

  Changed paths:
    M src/lib-dcrypt/dcrypt-openssl.c
    M src/lib-dcrypt/dcrypt-private.h
    M src/lib-dcrypt/dcrypt.c
    M src/lib-dcrypt/dcrypt.h
    M src/lib-dcrypt/ostream-encrypt.c

  Log Message:
  -----------
  lib-dcrypt: dcrypt_key_type_public/private() can no longer fail.

Removed unnecessary failure handling.


  Commit: 0eaf77d8c22c542d5bd474bf1460d811876629d7
      https://github.com/dovecot/core/commit/0eaf77d8c22c542d5bd474bf1460d811876629d7
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-06-21 (Tue, 21 Jun 2016)

  Changed paths:
    M src/lib-dcrypt/dcrypt-openssl.c

  Log Message:
  -----------
  lib-dcrypt: Don't ignore BIO errors.

Might happen due to out of memory?


  Commit: b9240a9115fc91f95e49565600e6b4d6fc55c2ea
      https://github.com/dovecot/core/commit/b9240a9115fc91f95e49565600e6b4d6fc55c2ea
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-06-21 (Tue, 21 Jun 2016)

  Changed paths:
    M src/lib-dcrypt/dcrypt-openssl.c

  Log Message:
  -----------
  lib-dcrypt: Added missing error handling.

Most of these are probably unnecessary now that malloc() no longer fails.
Also some of the NULL checks may not be needed since OpenSSL functions
(usually?) return failure on NULL parameters, but sometimes they perform
a different operation. So overall, probably safer to include these checks.


  Commit: 6b136bb200a5f803d0ef5af225ad891e862b6b75
      https://github.com/dovecot/core/commit/6b136bb200a5f803d0ef5af225ad891e862b6b75
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-06-21 (Tue, 21 Jun 2016)

  Changed paths:
    M src/lib-dcrypt/test-crypto.c
    M src/lib-dcrypt/test-stream.c

  Log Message:
  -----------
  lib-dcrypt: Check for all the return values in unit tests


  Commit: fbf29f41d25c13d9ad772facdf047e2bd8370ba1
      https://github.com/dovecot/core/commit/fbf29f41d25c13d9ad772facdf047e2bd8370ba1
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-06-21 (Tue, 21 Jun 2016)

  Changed paths:
    M src/lib-dcrypt/dcrypt.c

  Log Message:
  -----------
  lib-dcrypt: dcrypt_keypair_generate() no longer assumes pair_r to be initialized.

It wasn't clear that it should have been zeroed. It also likely isn't very
useful to be able to place the generated key to existing keys.


Compare: https://github.com/dovecot/core/compare/035d6e469a65...fbf29f41d25c