[dovecot/core] 5b6559: lib: istream's max_buffer_size=0 means 0, not unli...

Thu Jun 2 13:00:16 UTC 2016

  Branch: refs/heads/master-2.2
  Home:   https://github.com/dovecot/core
  Commit: 5b6559c3d7441ba222b59ae796260373fd7f0cc6
      https://github.com/dovecot/core/commit/5b6559c3d7441ba222b59ae796260373fd7f0cc6
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-06-02 (Thu, 02 Jun 2016)

  Changed paths:
    M src/lib/istream.c

  Log Message:
  -----------
  lib: istream's max_buffer_size=0 means 0, not unlimited.

Make sure we don't grow the buffer size then.

  Commit: a69f79313c926c2597c46d1e49356725c7955a38
      https://github.com/dovecot/core/commit/a69f79313c926c2597c46d1e49356725c7955a38
  Author: Stephan Bosch <stephan at dovecot.fi>
  Date:   2016-06-02 (Thu, 02 Jun 2016)

  Changed paths:
    M src/lib-mail/istream-qp-decoder.c

  Log Message:
  -----------
  lib-mail: istream-qp-decoder: For efficiency, avoid copying data between decode buffer and stream buffer.

Instead, use the decode buffer directly as stream buffer.

  Commit: 5f4111f3c49fff8c6bab322dd4b13d60ac79fe1b
      https://github.com/dovecot/core/commit/5f4111f3c49fff8c6bab322dd4b13d60ac79fe1b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-06-02 (Thu, 02 Jun 2016)

  Changed paths:
    M src/lib-fs/fs-api.c
    M src/lib-fs/fs-api.h

  Log Message:
  -----------
  lib-fs: Added fs_write_stream_abort_async()

  Commit: d0105748597c604474355f1a5441ddf105efce23
      https://github.com/dovecot/core/commit/d0105748597c604474355f1a5441ddf105efce23
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-06-02 (Thu, 02 Jun 2016)

  Changed paths:
    M src/lib-fs/fs-api-private.h
    M src/lib-fs/fs-api.c
    M src/lib-fs/fs-api.h

  Log Message:
  -----------
  lib-fs: Clarified fs_write_stream_abort() API and dropped its _async().

We can't handle an abort after an async fs_write_stream_finish() is already
going.

  Commit: 90ec94c78789b0697d65cda8209879deb31323b6
      https://github.com/dovecot/core/commit/90ec94c78789b0697d65cda8209879deb31323b6
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-06-02 (Thu, 02 Jun 2016)

  Changed paths:
    M src/lib-fs/fs-api.c

  Log Message:
  -----------
  lib-fs: Added more asserts

  Commit: f412ee7c6f0ef70cec05c9865c0320b7bbff761f
      https://github.com/dovecot/core/commit/f412ee7c6f0ef70cec05c9865c0320b7bbff761f
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-06-02 (Thu, 02 Jun 2016)

  Changed paths:
    M src/lib-fs/fs-metawrap.c

  Log Message:
  -----------
  fs-metawrap: Removed unnecessary code.

The caller already set success==FALSE if ostream was closed.

  Commit: 1d29d49c74b47a53c098e01daf221bd6b79e35f9
      https://github.com/dovecot/core/commit/1d29d49c74b47a53c098e01daf221bd6b79e35f9
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-06-02 (Thu, 02 Jun 2016)

  Changed paths:
    M src/lib-fs/Makefile.am
    A src/lib-fs/fs-test-async.c
    M src/lib-fs/fs-test.c
    M src/lib-fs/fs-test.h
    M src/lib-fs/test-fs-metawrap.c

  Log Message:
  -----------
  lib-fs: Improved unit tests.

  Commit: 3ffc655f0a4f8db2315c3de3553156f8bf99db75
      https://github.com/dovecot/core/commit/3ffc655f0a4f8db2315c3de3553156f8bf99db75
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-06-02 (Thu, 02 Jun 2016)

  Changed paths:
    M src/lib-fs/fs-metawrap.c

  Log Message:
  -----------
  fs-metawrap: Removed unnecessary code.

As mentioned in a0cf7d392, this can't happen.

  Commit: 6bd205f9a45cf649d2174292c4feb35bba5b7943
      https://github.com/dovecot/core/commit/6bd205f9a45cf649d2174292c4feb35bba5b7943
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-06-02 (Thu, 02 Jun 2016)

  Changed paths:
    M src/lib-compression/istream-bzlib.c
    M src/lib-compression/istream-lzma.c
    M src/lib-compression/istream-zlib.c

  Log Message:
  -----------
  lib-compression: istream.max_buffer_size == 0 isn't unlimited.

  Commit: 51dcb33a339e369de7c6e62b77f049c77bdb1f7e
      https://github.com/dovecot/core/commit/51dcb33a339e369de7c6e62b77f049c77bdb1f7e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-06-02 (Thu, 02 Jun 2016)

  Changed paths:
    M src/lib/istream-chain.c

  Log Message:
  -----------
  lib: istream-chain didn't update its max_buffer_size

I had this code at some point earlier, but looks like it got lost from the
final commit.

  Commit: 41a18c16c728751acb5efc002bff64b433c18de5
      https://github.com/dovecot/core/commit/41a18c16c728751acb5efc002bff64b433c18de5
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-06-02 (Thu, 02 Jun 2016)

  Changed paths:
    M src/lib/istream.c
    M src/lib/istream.h

  Log Message:
  -----------
  lib: i_stream_get_max_buffer_size() checks also parents' max sizes

This fixes i_stream_get_max_buffer_size() to work correctly with
istream-chain.

  Commit: f67f6de07a5e3120e25b3eaaed5730cdb7a25f1d
      https://github.com/dovecot/core/commit/f67f6de07a5e3120e25b3eaaed5730cdb7a25f1d
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-06-02 (Thu, 02 Jun 2016)

  Changed paths:
    M src/lib-compression/istream-bzlib.c
    M src/lib-compression/istream-lz4.c
    M src/lib-compression/istream-lzma.c
    M src/lib-compression/istream-zlib.c
    M src/lib-fs/istream-fs-file.c
    M src/lib-mail/istream-attachment-extractor.c
    M src/lib-mail/istream-binary-converter.c
    M src/lib-mail/istream-header-filter.c
    M src/lib-mail/istream-qp-decoder.c
    M src/lib-ssl-iostream/istream-openssl.c
    M src/lib-test/test-common.c
    M src/lib/istream-concat.c
    M src/lib/istream.c

  Log Message:
  -----------
  global: Use i_stream_get_max_buffer_size() wherever possible

After 7be8ba0c0 it's no longer correct to access stream->max_buffer_size
directly. These changes fix using istream-chain with various wrapper
streams.

  Commit: 72f0027d99c4441c6ceb89f13b1944e64b0f1f01
      https://github.com/dovecot/core/commit/72f0027d99c4441c6ceb89f13b1944e64b0f1f01
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-06-02 (Thu, 02 Jun 2016)

  Changed paths:
    M src/dict/dict-connection.c

  Log Message:
  -----------
  dict: Fixed crash when reaching max (5) pending commands.

  Commit: 8b895d07ddd7044050267a5db3b1272183152307
      https://github.com/dovecot/core/commit/8b895d07ddd7044050267a5db3b1272183152307
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-06-02 (Thu, 02 Jun 2016)

  Changed paths:
    M src/dict/dict-commands.c

  Log Message:
  -----------
  dict: Pipelined iteration replies may have been hanging.

For example:
 - lookup start
 - iterate start
 - iterate finished, but can't reply yet
 - lookup finished
 - iterate reply can be sent now, but wasn't previously

Compare: https://github.com/dovecot/core/compare/3dafbab91728...8b895d07ddd7