[dovecot/core] 2cf7f1: lib-http: client: Prevent infinite event loop invo...

Tue Dec 20 08:00:14 UTC 2016

  Branch: refs/heads/master-2.2
  Home:   https://github.com/dovecot/core
  Commit: 2cf7f1b1de7e7a46a5658d8a415a904f00d4493b
      https://github.com/dovecot/core/commit/2cf7f1b1de7e7a46a5658d8a415a904f00d4493b
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2016-12-20 (Tue, 20 Dec 2016)

  Changed paths:
    M src/lib-http/http-client-peer.c

  Log Message:
  -----------
  lib-http: client: Prevent infinite event loop involving the request handler.

Could happen when a backoff time is active.

  Commit: adbc1f7242a684a933ae291e4f1e1b104a1e38cb
      https://github.com/dovecot/core/commit/adbc1f7242a684a933ae291e4f1e1b104a1e38cb
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2016-12-20 (Tue, 20 Dec 2016)

  Changed paths:
    M src/lib-http/http-client-peer.c

  Log Message:
  -----------
  lib-http: client: Moved connection backoff timer management to separate functions.

  Commit: bee4ea836522b5ba644810d75608cae8c8d7a16f
      https://github.com/dovecot/core/commit/bee4ea836522b5ba644810d75608cae8c8d7a16f
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2016-12-20 (Tue, 20 Dec 2016)

  Changed paths:
    M src/lib-http/http-client-connection.c
    M src/lib-http/http-client-private.h

  Log Message:
  -----------
  lib-http: client: Consolidated connection loss handling into a single function.

  Commit: 4710cc0b19fe0fa604d586cd3825c34af0c114a0
      https://github.com/dovecot/core/commit/4710cc0b19fe0fa604d586cd3825c34af0c114a0
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2016-12-20 (Tue, 20 Dec 2016)

  Changed paths:
    M src/lib-http/http-client-connection.c
    M src/lib-http/http-client-peer.c
    M src/lib-http/http-client-private.h

  Log Message:
  -----------
  lib-http: client: Treat connections that get disconnected prematurely as connection failures.

This means that the backoff time is increased when this happens.
A premature disconnection happens when the connection is disconnected before any data is received from the server.

  Commit: 6650976aa15aeaf3994dd13577b0a03035c319e5
      https://github.com/dovecot/core/commit/6650976aa15aeaf3994dd13577b0a03035c319e5
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2016-12-20 (Tue, 20 Dec 2016)

  Changed paths:
    M src/lib-http/test-http-client-errors.c

  Log Message:
  -----------
  lib-http: client: Added test for normal connection backoff behavior to test-http-client-errors.

  Commit: 4ba0369a50476b2b1055f636f0386dff5e864a7d
      https://github.com/dovecot/core/commit/4ba0369a50476b2b1055f636f0386dff5e864a7d
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2016-12-20 (Tue, 20 Dec 2016)

  Changed paths:
    M src/lib-http/test-http-client-errors.c

  Log Message:
  -----------
  lib-http: client: Added test for premature connection loss to test-http-client-errors.

  Commit: 28f5ddb56a78d68ec25de4cf55ea846ae87bfa8a
      https://github.com/dovecot/core/commit/28f5ddb56a78d68ec25de4cf55ea846ae87bfa8a
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2016-12-20 (Tue, 20 Dec 2016)

  Changed paths:
    M src/lib-imap-client/imapc-connection.c

  Log Message:
  -----------
  lib-imap-client: Fixed boolean vs integer mixup in debug message format argument.

Found with Clang -Wstrict-bool.

  Commit: c38f69924b6fd2ff697ee87a3371ade4fd66ae15
      https://github.com/dovecot/core/commit/c38f69924b6fd2ff697ee87a3371ade4fd66ae15
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-12-20 (Tue, 20 Dec 2016)

  Changed paths:
    M src/lib/printf-format-fix.c

  Log Message:
  -----------
  lib: Optimize printf_format_fix_noalloc()

Using strchr() is faster than looping through the characters manually.
Since this function is being called a lot, it's worth optimizing.

  Commit: 966ae459220d45a8b7c56efed4916ac18137c8cf
      https://github.com/dovecot/core/commit/966ae459220d45a8b7c56efed4916ac18137c8cf
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-12-20 (Tue, 20 Dec 2016)

  Changed paths:
    M src/lib/printf-format-fix.c
    M src/lib/test-printf-format-fix.c

  Log Message:
  -----------
  lib: Fix %n detection in printf_format_fix_noalloc()

It's undefined how flags, precision or length modifiers are handled with %n,
so make sure we catch all of them to detect an unwanted %n.

  Commit: 92f2c8bf45ce2de930393fca3dfd43d039807128
      https://github.com/dovecot/core/commit/92f2c8bf45ce2de930393fca3dfd43d039807128
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-12-20 (Tue, 20 Dec 2016)

  Changed paths:
    M src/lib/printf-format-fix.c

  Log Message:
  -----------
  lib: Allow only known %chars in printf_format_fix_noalloc()

Otherwise if some libc adds a new unsupported character, our %n check might
break.

  Commit: 2d53d80b9274eb0b616f42842bd8577dcbba14d4
      https://github.com/dovecot/core/commit/2d53d80b9274eb0b616f42842bd8577dcbba14d4
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-12-20 (Tue, 20 Dec 2016)

  Changed paths:
    M src/lib/test-malloc-overflow.c

  Log Message:
  -----------
  lib: Remove dead code from unit test

  Commit: a9f1d66140724e7db0264b3ff2e2bcf364464f43
      https://github.com/dovecot/core/commit/a9f1d66140724e7db0264b3ff2e2bcf364464f43
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-12-20 (Tue, 20 Dec 2016)

  Changed paths:
    M src/master/main.c

  Log Message:
  -----------
  master: Update assert to make sure optind != 0

Hopefully prevents Coverity warning about "doubleops[optind]" access being
uninitialized.

  Commit: 88f7ecdbd88f18da6a0ed22f3f03fba89efece1c
      https://github.com/dovecot/core/commit/88f7ecdbd88f18da6a0ed22f3f03fba89efece1c
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-12-20 (Tue, 20 Dec 2016)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  configure: Define __STDC_LIMIT_MACROS for CXXFLAGS

Fixes SIZE_MAX being undefined when building fts-lucene.

  Commit: eb0308e25bb81c691b21d8036b9c5f77eca9ca76
      https://github.com/dovecot/core/commit/eb0308e25bb81c691b21d8036b9c5f77eca9ca76
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-12-20 (Tue, 20 Dec 2016)

  Changed paths:
    M src/lib-index/mail-transaction-log-file.c

  Log Message:
  -----------
  lib-index: Make sure buffer is not null before freeing

Fixes signal 11 crash under stress.

Compare: https://github.com/dovecot/core/compare/9bc8d9b2047f...eb0308e25bb8