[dovecot/core] f549b4: lib-imap: imap-bodystructure: Prevent writing erro...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: f549b400d50935754cbeb6ceabd922ab777b4d77
      https://github.com/dovecot/core/commit/f549b400d50935754cbeb6ceabd922ab777b4d77
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2016-12-14 (Wed, 14 Dec 2016)

  Changed paths:
    M src/lib-imap/imap-bodystructure.c
    M src/lib-imap/test-imap-bodystructure.c

  Log Message:
  -----------
  lib-imap: imap-bodystructure: Prevent writing erroneous whitespace between items in an envelope address list.

Both imap_bodystructure_write() and imap_body_parse_from_bodystructure() produced such invalid output.
This caused an RFC 3501 violation in IMAP FETCH BODY and BODYSTRUCTURE responses.

Test suite is amended to test this situation.


  Commit: 60bea13e11a4e95e915c64112783d86204697b19
      https://github.com/dovecot/core/commit/60bea13e11a4e95e915c64112783d86204697b19
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-12-14 (Wed, 14 Dec 2016)

  Changed paths:
    M src/doveadm/doveadm-mail-save.c

  Log Message:
  -----------
  doveadm-save: Set exit code to EX_TEMPFAIL on open error

Prevents potential crash on doveadm_mail_next_user


  Commit: b0e6a65a4b3971c6e00c97c8be19222165899cb7
      https://github.com/dovecot/core/commit/b0e6a65a4b3971c6e00c97c8be19222165899cb7
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-12-14 (Wed, 14 Dec 2016)

  Changed paths:
    M src/doveadm/doveadm-mail.c

  Log Message:
  -----------
  doveadm-mail: Set exit code to EX_TEMPFAIL on timeout

When running `doveadm save` command on proxy/director
and the remote command execution times out, exit code
must be set to EX_TEMPFAIL.

Fixes Panic: file doveadm-mail.c: line 405 (doveadm_mail_next_user):
assertion failed: (ctx->exit_code != 0)


  Commit: ec8e55a73623e40dfce9bfb5a60abf047788b222
      https://github.com/dovecot/core/commit/ec8e55a73623e40dfce9bfb5a60abf047788b222
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2016-12-14 (Wed, 14 Dec 2016)

  Changed paths:
    M src/auth/db-ldap.c

  Log Message:
  -----------
  auth: silence var_expand_with_funcs in db-ldap

This needs to be silenced since it's logging errors of variable
expansions that are not meant to be successful. The function is used
here just for filling the attr_names array in ldap_field_find_context
and the resulting string is not used.


  Commit: 76d4cc8e7aea32e91a48c83dabcccb196ea8019b
      https://github.com/dovecot/core/commit/76d4cc8e7aea32e91a48c83dabcccb196ea8019b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-12-14 (Wed, 14 Dec 2016)

  Changed paths:
    M src/lib-test/test-common.c
    M src/lib-test/test-common.h

  Log Message:
  -----------
  lib-test: Introduce test_fatal_func_t as typedef and comment how it works.


  Commit: bc15567c91fb9d3915b04013ee0cc744c7a18eab
      https://github.com/dovecot/core/commit/bc15567c91fb9d3915b04013ee0cc744c7a18eab
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-12-14 (Wed, 14 Dec 2016)

  Changed paths:
    M src/lib-test/test-common.c
    M src/lib-test/test-common.h

  Log Message:
  -----------
  lib-test: test_run_with_fatals() now takes a const array


  Commit: 957d34edbe3599fbb4e7c0bcf3785bd7fd4862c4
      https://github.com/dovecot/core/commit/957d34edbe3599fbb4e7c0bcf3785bd7fd4862c4
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-12-14 (Wed, 14 Dec 2016)

  Changed paths:
    M src/lib-test/test-common.c
    M src/lib-test/test-common.h
    M src/lib/test-array.c
    M src/lib/test-data-stack.c
    M src/lib/test-mempool-alloconly.c
    M src/lib/test-printf-format-fix.c

  Log Message:
  -----------
  lib-test: Change test_fatal_func_t to take unsigned int stage as parameter.

It could never be -1, so this makes it clearer. It also removes annoying
casts when comparing stage to e.g. N_ELEMENTS().


  Commit: 182093c9a4e02a1c6672597da45767625c6b970e
      https://github.com/dovecot/core/commit/182093c9a4e02a1c6672597da45767625c6b970e
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-12-14 (Wed, 14 Dec 2016)

  Changed paths:
    M src/lib/sha3.c

  Log Message:
  -----------
  sha3: Fix typo in ifdef

The code was supposed to be used with big endian
machines.

Reported by than at redhat.com


  Commit: 5afa9b93dad70209afe9340f036a65d3da978f8f
      https://github.com/dovecot/core/commit/5afa9b93dad70209afe9340f036a65d3da978f8f
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-12-14 (Wed, 14 Dec 2016)

  Changed paths:
    M src/auth/auth-policy.c

  Log Message:
  -----------
  auth-policy: Allow unsupported attributes in response

Do not choke if we receive unsupported attributes in
response. This allows better interoperability with
different systems that are getting signals from
auth policy server that are not (yet) supported by
dovecot.


  Commit: beec8b0a6a3ece557c9acec524e82542a9641662
      https://github.com/dovecot/core/commit/beec8b0a6a3ece557c9acec524e82542a9641662
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-12-14 (Wed, 14 Dec 2016)

  Changed paths:
    M src/plugins/mail-crypt/test-mail-global-key.c
    M src/plugins/mail-crypt/test-mail-key.c

  Log Message:
  -----------
  mail-crypt: Skip tests if dcrypt cannot be initialized

Avoids breaking tests on system without working
ECC keys.


Compare: https://github.com/dovecot/core/compare/d0ed540d897d...beec8b0a6a3e